From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 2/4 RFCv2] net: dsa: Add bindings for Realtek SMI DSAs Date: Tue, 29 May 2018 12:30:41 -0700 Message-ID: References: <20180528174752.6806-1-linus.walleij@linaro.org> <20180528174752.6806-3-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20180528174752.6806-3-linus.walleij@linaro.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Linus Walleij , Andrew Lunn , Vivien Didelot Cc: netdev@vger.kernel.org, openwrt-devel@lists.openwrt.org, LEDE Development List , =?UTF-8?B?QW50dGkgU2VwcMOkbMOk?= , Roman Yeryomin , Colin Leitner , Gabor Juhos , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 05/28/2018 10:47 AM, Linus Walleij wrote: > The Realtek SMI family is a set of DSA chips that provide > switching in routers. This binding just follows the pattern > set by other switches but with the introduction of an embedded > irqchip to demux and handle the interrupts fired by the single > line from the chip. > > This interrupt construction is similar to how we handle > interrupt controllers inside PCI bridges etc. > > Cc: Antti Seppälä > Cc: Roman Yeryomin > Cc: Colin Leitner > Cc: Gabor Juhos > Cc: Florian Fainelli > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij > --- > + > + mdio { > + compatible = "realtek,smi-mdio", "dsa-mdio"; You should drop the "dsa-mdio" compatible string here since it both non documented and not matched either. Other than that, this looks great, with that fixed: Reviewed-by: Florian Fainelli -- Florian