* [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B
@ 2023-04-04 17:41 Shreeya Patel
2023-04-04 19:02 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Shreeya Patel @ 2023-04-04 17:41 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, heiko
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
kernel, Shreeya Patel, Christopher Obbard
Add DT node to enable RTC support for Rock 5B board.
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>
---
.../boot/dts/rockchip/rk3588-rock-5b.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 95805cb0adfa..fcb5af09e49b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
};
};
+&i2c6 {
+ status = "okay";
+
+ hym8563: hym8563@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-frequency = <32768>;
+ clock-output-names = "hym8563";
+ pinctrl-names = "default";
+ pinctrl-0 = <&hym8563_int>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+ wakeup-source;
+ };
+};
+
+&pinctrl {
+ hym8563 {
+ hym8563_int: hym8563-int {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
&sdhci {
bus-width = <8>;
no-sdio;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B
2023-04-04 17:41 [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B Shreeya Patel
@ 2023-04-04 19:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-04 19:02 UTC (permalink / raw)
To: Shreeya Patel, robh+dt, krzysztof.kozlowski+dt, heiko
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
kernel, Christopher Obbard
On 04/04/2023 19:41, Shreeya Patel wrote:
> Add DT node to enable RTC support for Rock 5B board.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>
> ---
> .../boot/dts/rockchip/rk3588-rock-5b.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 95805cb0adfa..fcb5af09e49b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
> };
> };
>
> +&i2c6 {
> + status = "okay";
> +
> + hym8563: hym8563@51 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-04 19:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 17:41 [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B Shreeya Patel
2023-04-04 19:02 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).