From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE41210F62 for ; Tue, 10 Dec 2024 09:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733824615; cv=none; b=incekVxKK2OnviZqP9zn6u2fOFM9v34dvgpkCvdPYaU67O8VYsKT/HuDFyMMXEJZSAlp5S69ag1pxeJ3RKa4ZQ1liiIFtnjBuDYBf/z6T8auiTt791rtMUyuwdiS5YV2ylQ57nznRuiP74avenxL+d3iLfV0JmBqqUnLGydDdzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733824615; c=relaxed/simple; bh=xK73O0f7blSrEgwODgrtk4L4kIN4+OvcHPN1VpbRQfI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WnLTxLyNunjWWnZst92mPq+7TgnfjybNu4sTTIOBXVmFf4rO83sQ/gNh1khw0ZZW9mqxV0BgBwXgZbVdqPpdQ0Uasz7IkPOuTjAZta7ls92DWRwNwFRrZ6Uwc/202ksdiKIsTtW4PKsMmgtFsxi/OsKaUsRdc2Hg/fG8SkPLyQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org; spf=fail smtp.mailfrom=beagleboard.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b=GCIv+E3q; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b="GCIv+E3q" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-725f4623df7so1627160b3a.2 for ; Tue, 10 Dec 2024 01:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1733824613; x=1734429413; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kVRuXdDQ8ceHGh69+Xr1H0loAqY9s+XHZx32Oyfx7ZA=; b=GCIv+E3qS45vlgMGyv4j+vcl47FfHL3AdiK9t9WN5AJHv7NFePcR7Zdh7jCxQC2iCy vqLqOBKVhZ6z0SegiTTELEdvpue3vNZULVDGeMo9SrP7tbtxLXHpbJvs6TjvcHsnIiiB GVaELQKS7wE5YD3cRZDsINVO5uJKgSzUgrb9ZhfbCh1am65Jm+T+UBOYKKU0sP2utT2Q NXPDlzj226TyltQZVjilhUrnraPtX7hm+eg37OqawNTsUrZMH5iT4lo0C+OG3YlX8em7 WHhe+Cz8cN48IK2y9MXpt75fGHlfzuWt0vmgaOdsXqygFn9TIYv42CMnMbxITfu/dYnI qbDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733824613; x=1734429413; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kVRuXdDQ8ceHGh69+Xr1H0loAqY9s+XHZx32Oyfx7ZA=; b=XvGHmBWdHWSx3CRdw6KOYKyti1JwCuhwPObr9axfxBUm8fmqUtCEYI1nTcsJj+5aam JK4fiS9unQPPsm+ur4bWcWshC5ZZTnrtya8lvJGzp365NO40rnRkkxOPFnSLMiBJwuXy 5hjIErZng6LecM8kCbCiqSB6z1g+yinPlP5hssKXHgLJYqBlv3/f2jQEgD9ViAplw4YU aXYpe9iTtt6Hi3wMvhISzgGBb7bEQKqUV4IOVHprHMJf2O2BxjP+wNZwhnGLWmJMjexO c+c7Nl5LnhPKjB3Ayk44A+b/OJ00DyHud6gF4lNhUCTgequQKx/mwdklEcahorEuCUgX jUNg== X-Forwarded-Encrypted: i=1; AJvYcCV74DYbz64EVV7dhVTJAUEkmLVZr4hARKqVsg/VwoaAZwR6QAaFIMz0s1+YALQWnV0xvvCzrwK6cF2j@vger.kernel.org X-Gm-Message-State: AOJu0YyqXvNKPGIILBIJzVPE8Hio43GkoqWNuQP4E9p1qPLfhhBbKX06 sYhhQagR61vySUECjJc+aUA07gwSsNgl13Oj1FHqUVJP1GA6UXLsfMqZGOvreA== X-Gm-Gg: ASbGnculgXjCvvjDbkzLnf8CM0TPtLG8NPQ8kX9H5m6RMG/7gd9f34JvYfWGsfASAQB byF9u09QEFC5cGXOy6CYAs3Vjrh1p4FuEyJamTY44VByQAagEeYNWLwtcMW8F00MT6iJebYjyfd 9pkWXLQCZB3k0NFkPLL76RcpQXvLjijw7Ipf/2MLuH0wS0AW540xctvBjLRXf6Kcq02JZRHJg+p greAQUA3deb1C2GTNhzDptyDbLU+AAR6hULbxPzp81GkHE20Tk31EA4Z+ze5pnkRQnkBu4/NDLQ hC2mAZOGmBFNAGTXHkmkGaxMu5de X-Google-Smtp-Source: AGHT+IHe+Tktbs6gzSr+HibLWo7BRUgyGJ8rAz95UU0Btgi1QAR6b+87ABh2JIWUw8KcY0eLIvyJqA== X-Received: by 2002:a05:6a20:4322:b0:1e1:a0b6:9861 with SMTP id adf61e73a8af0-1e1b1aa024fmr4818821637.12.1733824613547; Tue, 10 Dec 2024 01:56:53 -0800 (PST) Received: from ?IPV6:2401:4900:4451:8982:a0c3:dcc6:3a8d:184? ([2401:4900:4451:8982:a0c3:dcc6:3a8d:184]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725df133a56sm4784841b3a.69.2024.12.10.01.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 01:56:52 -0800 (PST) Message-ID: Date: Tue, 10 Dec 2024 15:26:44 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] of: overlay: Add support for export-symbols node feature To: Herve Codina Cc: Andrew Davis , Geert Uytterhoeven , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Ceresoli , Thomas Petazzoni References: <20241209151830.95723-1-herve.codina@bootlin.com> <33c61b28-c0b8-478d-8107-c6ed1ff9e466@beagleboard.org> <20241210104141.39acffb1@bootlin.com> Content-Language: en-US From: Ayush Singh In-Reply-To: <20241210104141.39acffb1@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/12/24 15:11, Herve Codina wrote: > Hi Ayush, > > On Tue, 10 Dec 2024 14:52:22 +0530 > Ayush Singh wrote: > > ... >> >> What is the reason for not using symbols directly as described here [3]? >> >> I do like this approach since it does not pollute the global symbols. >> Just want to know if there are any other reasons for it. >> > > Modifying the __symbols__ node at runtime (adding / removing properties in > it) exposes memory leaks if __symbols__ already exist in the live DT. > This __symbols__ node exist if the dtb was compiled with '-@' or if you > chain the overlay (i.e. __symbols__ node created by the first overlay). Yeah, that is a problem, specially in a setup which might involve hot-plugging. > > I think also that some conflicts can appears. What happens if you want to > add a new label but this label is already present for some other purpose? I do not think that actually is a problem. As described in the original patch [0], the symbol and connector overlay is supposed to be applied as a group (overwriting any conflicting symbols in the process). The reason why this is not a problem is that `__symbols__` are only used to resolve the phandles (overlays do not support path references yet), but do not really have a purpose in the livetree (at least far as I know, but I can be wrong). > > Best regards, > Hervé [0]: https://lore.kernel.org/lkml/20240702164403.29067-1-afd@ti.com/ Ayush Singh