From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEE969443 for ; Fri, 27 Jun 2025 15:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751037652; cv=none; b=gXnzs+0Q/We/T/5YI5Rv2IzQjPdYjSviZ+WxjwemsEAGbuFFAocdw8NxXeBf2Dw3+JwzdmrLBV2rKoNWuVeOUCeuUbjimulz1OdMG3zm5/uWwckgdwNDTxDiICNrk/hFMLWQSLi7PMGBp2GKTzs98m5j7q/68DsUWLhUvqweXSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751037652; c=relaxed/simple; bh=SmowlgYgwftaa1tGjB6GIpsGIQtJnbKf0ZX7Hg6O1Y4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aWNT8o4fFzeWKafcNcoIgiXq/axYoyqLEiYTCStfD9pCag6uSXUNngw9+TLoj5X/EQvFnvm0Q+9dPb6MwLPVAXS5Ils5D70L/HOvAG6lCxC//6qdgyzGsrn5G8Zmog3KyvjSE3oGoSC4dyzgmeob8zLEfI4ZbVHcTQz0Pj99z0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mH1LHRYX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mH1LHRYX" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55RCoDaj011390 for ; Fri, 27 Jun 2025 15:20:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mJP/7NC1EgD6Mantj/U98kyV+WF9inn7RXWXzWXfQ4E=; b=mH1LHRYXFnA6OrsN Ku1CNwMoOU9kr9BqAPBrGoo06RGDsg2U73MqUzC2bbhDUVRuu1pG0eNih1U2bDCD Ed0mnRcmgq3NfrItpyyLfaj5MfMdoLZiTMjorE8BKeE11WYEk18fqRy7zyiZ3WHs OMjYdRSSB55NhrP7wv5Kui1z9vKE2yluh8D8cz34WutvCpuPVFViBvWDtTFxu6xs Jedwe33pBMRBq0RN/woBw0zzzIVMhCcLp2Gkjp75xkcmfd/mAO7l9n/xye7ISeBm aRyS9l9gNh1HCPpT8xDKql1FlvxN6hH1GQiaOmb5M9vMk/uBLrpjn1XmTL/Yujrs J0q6eQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47f3bgq7j8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 27 Jun 2025 15:20:49 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d094e04aa4so54773085a.1 for ; Fri, 27 Jun 2025 08:20:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751037649; x=1751642449; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mJP/7NC1EgD6Mantj/U98kyV+WF9inn7RXWXzWXfQ4E=; b=hGojeEB6pN7XZkzjvkIC00kgxKNxNCLiFnbosAzlJ+1pvNLKseKGrDxXQ0XXQmIicT S9mmWMFR/gqIP0+AOtPcbNstzv1nYP3jvCsnSTJlEi9DjKXDO5iX13WiTL28+FsSBWa5 tMEMrhP/uJtImSosltf9LKqtESq9yMWlGXI6+603um2ehpRyoj3rrupYKmqXlCzqcnji c2AYw+l1zM2fNToQVyLeBqJqLgEcJ1BBeAxIEXc6KIX7/jyPJZ/sfl9jTZ4W3DhPRCzG 884Xl4LbIbxCguNpDN4N/nYHYViIsX1/kfSQtxCjcQx6nUGPbxgahkBDTt4KET56AjOg k8jQ== X-Forwarded-Encrypted: i=1; AJvYcCWnPw51FYp41prr0Y9S3960/yqk+tKLT0D2Wh3RKIqLVmibjh2HGENmi7eju1qsH95JwWhdQzVJ3JSr@vger.kernel.org X-Gm-Message-State: AOJu0YymxNaLmargsxl3i6lQRza6n8+azlFhvIu2dK6E/G1+OwDsMg9V 5hUZMRAtqnkYQe9fL9fBaWUuuhk4SdxSBh4uMXKemp+6Sc33kRW4jDxPxM7kA/8jSvv3LhUgT8F g4UzoghdhpzxKiv/mWnOyE4KjX9uC4XAgwGZAPHSEUzqKcYzEIJhtASf/I5aFFuqg X-Gm-Gg: ASbGnctQIPfQGlkl4TFFFr0D6/N9VkWUI+r6QVenNyXGtLiBrD2FwY+pIWVMcADgdWr 15wvBawre/TiJ9OCTOxDmRizzCb4njwq0ZLOEFslAli8x6vOlPtPV+eIuk74TnLRZyfizejZ4pY vsGXriBFIw4UXCguMd5ks6tx3fKBdx71kBfnb9bjOBsCtXCbRW66u8Iiu6qP/mf/qIij6JIUlKN e3qAV+1RaHC3PwefnxmxBbTgBMgl+Q61IhO6cNKOGaWvfAdcQsv3F2tah3AXwdcxpnHpJhMm9UK hKyuH6ZVVyuB9L/dc3CZS8STHu3Hvil8f9rCRfLTXcHkrBz9OdursWg0PtcBNnJU7FgD24ZBC9W Jfmw= X-Received: by 2002:a05:620a:45ac:b0:7c5:9ab7:3012 with SMTP id af79cd13be357-7d4439b767amr185726185a.11.1751037648688; Fri, 27 Jun 2025 08:20:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvYr5ZAb1cByhMi5gKad8nYzi7xL26bnBk3yQVC7jOo75b6I73FUUwQBAIvCOdDq0/tcE4Hw== X-Received: by 2002:a05:620a:45ac:b0:7c5:9ab7:3012 with SMTP id af79cd13be357-7d4439b767amr185723785a.11.1751037647943; Fri, 27 Jun 2025 08:20:47 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c01511sm137712266b.82.2025.06.27.08.20.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 08:20:47 -0700 (PDT) Message-ID: Date: Fri, 27 Jun 2025 17:20:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/5] arm64: dts: qcom: qcm2290: Add venus video node To: Vikash Garodia , Jorge Ramirez Cc: krzk+dt@kernel.org, bryan.odonoghue@linaro.org, quic_dikshita@quicinc.com, mchehab@kernel.org, robh@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250626135931.700937-1-jorge.ramirez@oss.qualcomm.com> <20250626135931.700937-6-jorge.ramirez@oss.qualcomm.com> <6e330e8f-5856-ef8e-5fe3-52bd61b59e02@quicinc.com> <2722e70a-1080-c9f3-eb56-4a6e79084bdc@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: FoswFoAebaYPV9LdFe2q9KCBjl8Vhdr2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI3MDEyNSBTYWx0ZWRfXwvd0mD+FKDTg hwhqGkj/yJ3yFGGaEQCELxpoA0vo/+neJAhbB3jgJh0vpFRij8JGKeJBKz+GFFRvuXtZMBynZK4 jn0r9dSPA0tZU/5hWwuoiKiQ7IG7weDHVLmrdiO3HLEN/imjtRWmmDgMvVsBcqE2pLkCTLn6kHs +3BOF8NaOG7+wJcZRF1U2e5R0pl/i3bvGGME5ZWpjJfjdUulXOO+ixz0kY+PFQ3xn3nnq4qMpNK TXDgUc0tRRKfn9PygS9cgZo0y/TV1LA09i6FCsF1fA1NHX27COxjYjLzfL1RYGiy9KrjfbqgAXG iGis+orZdy4Hrami2V9ofgDk1I0oyow16d4XjIhTkjAkl806+4NudAlfOrsIfBtfbGnSOZMB20D 8ftq6px5rF3DpzO7KSCZXBx8u0PLuiv9Hm27laErO8UgoYaAI5VZv8yT7irKng3jF+OLP96T X-Authority-Analysis: v=2.4 cv=L4kdQ/T8 c=1 sm=1 tr=0 ts=685eb6d1 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=vc-yO3o8YnYlDIzLKG0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: FoswFoAebaYPV9LdFe2q9KCBjl8Vhdr2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-27_04,2025-06-26_05,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506270125 On 6/27/25 5:12 PM, Vikash Garodia wrote: > > On 6/27/2025 8:38 PM, Jorge Ramirez wrote: >> On 27/06/25 20:28:29, Vikash Garodia wrote: >>> >>> On 6/27/2025 6:03 PM, Jorge Ramirez wrote: >>>> On 27/06/25 17:40:19, Vikash Garodia wrote: >>>>> >>>>> On 6/26/2025 7:29 PM, Jorge Ramirez-Ortiz wrote: >>>>>> Add DT entries for the qcm2290 venus encoder/decoder. >>>>>> >>>>>> Co-developed-by: Loic Poulain >>>>>> Signed-off-by: Loic Poulain >>>>>> Signed-off-by: Jorge Ramirez-Ortiz >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/qcm2290.dtsi | 57 +++++++++++++++++++++++++++ >>>>>> 1 file changed, 57 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi >>>>>> index f49ac1c1f8a3..5326c91a0ff0 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi >>>>>> +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi >>>>>> @@ -1628,6 +1628,63 @@ adreno_smmu: iommu@59a0000 { >>>>>> #iommu-cells = <2>; >>>>>> }; >>>>>> >>>>>> + venus: video-codec@5a00000 { >>>>>> + compatible = "qcom,qcm2290-venus"; >>>>>> + reg = <0 0x5a00000 0 0xf0000>; >>>>>> + interrupts = ; >>>>>> + >>>>>> + power-domains = <&gcc GCC_VENUS_GDSC>, >>>>>> + <&gcc GCC_VCODEC0_GDSC>, >>>>>> + <&rpmpd QCM2290_VDDCX>; >>>>>> + power-domain-names = "venus", >>>>>> + "vcodec0", >>>>>> + "cx"; >>>>>> + operating-points-v2 = <&venus_opp_table>; >>>>>> + >>>>>> + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, >>>>>> + <&gcc GCC_VIDEO_AHB_CLK>, >>>>>> + <&gcc GCC_VENUS_CTL_AXI_CLK>, >>>>>> + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, >>>>>> + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, >>>>>> + <&gcc GCC_VCODEC0_AXI_CLK>; >>>>>> + clock-names = "core", >>>>>> + "iface", >>>>>> + "bus", >>>>>> + "throttle", >>>>>> + "vcodec0_core", >>>>>> + "vcodec0_bus"; >>>>>> + >>>>>> + memory-region = <&pil_video_mem>; >>>>>> + iommus = <&apps_smmu 0x860 0x0>, >>>>>> + <&apps_smmu 0x880 0x0>, >>>>>> + <&apps_smmu 0x861 0x04>, >>>>>> + <&apps_smmu 0x863 0x0>, >>>>>> + <&apps_smmu 0x804 0xe0>; >>>>> keep only the non secure ones. >>>> >>>> ok >>>> >>>>>> + >>>>>> + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 RPM_ALWAYS_TAG >>>>>> + &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>, >>>>>> + <&bimc MASTER_APPSS_PROC RPM_ACTIVE_TAG >>>>>> + &config_noc SLAVE_VENUS_CFG RPM_ACTIVE_TAG>; >>>>>> + interconnect-names = "video-mem", >>>>>> + "cpu-cfg"; >>>>>> + >>>>>> + status = "okay"; >>>>>> + >>>>>> + venus_opp_table: opp-table { >>>>>> + compatible = "operating-points-v2"; >>>>>> + >>>>>> + opp-133000000 { >>>>>> + opp-hz = /bits/ 64 <133000000>; >>>>>> + required-opps = <&rpmpd_opp_low_svs>; >>>>>> + }; >>>>> Fix the corner freq value >>>> >>>> can you add some reference please? >>>> >>>> I took this data from an internal document - not sure why the downstream >>>> driver supports different values or where those were taken from (AFAIK >>>> they are not supported) >>> Most likely you have referred incorrect downstream file. Refer scuba-vidc.dtsi. >> >> I took them from actual documents (which might or might not be obsolete, >> hard to say but they were the latest version and as such, they >> contradict the downstream dtsi). >> >> So I'd rather not use downstream - could you point me to the reference >> you used please - I wonder if the fix is required downstream instead of here? > > You can look for this file gcc-scuba.c and refer gcc_video_venus_clk_src which > is the src for different venus clocks. This is not a good source in general, GCC often has more rates defined than the consumer is supposed to finally run at (because they were deemed power-inefficient or similar, you can pretty much set any rate you want on the clocks fwiw) Konrad