From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B20FC2BA83 for ; Wed, 12 Feb 2020 06:24:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E7A820714 for ; Wed, 12 Feb 2020 06:24:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="sBHFiUbR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728191AbgBLGXe (ORCPT ); Wed, 12 Feb 2020 01:23:34 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:49462 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728187AbgBLGXd (ORCPT ); Wed, 12 Feb 2020 01:23:33 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581488612; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=+MeToIl2UVuSzBxG95x4EhHM10yDLWzdMfdITlc4I5M=; b=sBHFiUbRflwVLY9WfiA05vJhgWgoJlPgwY4Q+PIyaKLbQFyCT+8pKgt2LrtyGuSyhx1/1rAz ISYAZW1aQzByk/YQD1k9D0QDM68t6NS9xK2skrvnh4z2zK9ic858wDyYeSBRnGMJugVF0zT2 i1tlx/He40f68zSq89Bmu3OagbY= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e4399e3.7fc9851bf618-smtp-out-n02; Wed, 12 Feb 2020 06:23:31 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 803D0C433A2; Wed, 12 Feb 2020 06:23:31 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bgodavar) by smtp.codeaurora.org (Postfix) with ESMTPSA id BA43CC43383; Wed, 12 Feb 2020 06:23:29 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 12 Feb 2020 11:53:29 +0530 From: bgodavar@codeaurora.org To: Matthias Kaehlcke Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, hemantg@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, gubbaven@codeaurora.org Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990 In-Reply-To: <20200211173323.GE18972@google.com> References: <20200211121612.29075-1-bgodavar@codeaurora.org> <20200211173323.GE18972@google.com> Message-ID: X-Sender: bgodavar@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Matthias, On 2020-02-11 23:03, Matthias Kaehlcke wrote: > On Tue, Feb 11, 2020 at 05:46:12PM +0530, Balakrishna Godavarthi wrote: > >> subject: arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990 > > Preferably say in the subjct that the node is added for the IDP board. > [Bala]: will update >> Add node for bluetooth soc wcn3990. >> >> Signed-off-by: Balakrishna Godavarthi >> --- >> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> index 388f50ad4fde..19f82ddc1f09 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> @@ -19,6 +19,7 @@ >> aliases { >> hsuart0 = &uart3; >> serial0 = &uart8; >> + bluetooth0 = &bluetooth; >> }; >> >> chosen { >> @@ -256,6 +257,16 @@ >> >> &uart3 { >> status = "okay"; > > nit: add a blank line > [Bala]: will update >> + bluetooth: wcn3990-bt { >> + compatible = "qcom,wcn3990-bt"; >> + vddio-supply = <&vreg_l10a_1p8>; >> + vddxo-supply = <&vreg_l1c_1p8>; >> + vddrf-supply = <&vreg_l2c_1p3>; >> + vddch0-supply = <&vreg_l10c_3p3>; >> + max-speed = <3200000>; >> + clocks = <&rpmhcc RPMH_RF_CLK2>; >> + status = "okay"; > > status is not needed here AFAIK. [Bala]: true, will update