From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Marty E. Plummer" <hanetzer@startmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: hisilicon: add CRG driver Hi3521a SoC
Date: Tue, 3 May 2022 11:41:49 +0200 [thread overview]
Message-ID: <bacc123d-bedc-0034-6591-3ef0caf270ae@linaro.org> (raw)
In-Reply-To: <20220501113215.rh6he5344hssziy7@proprietary-killer>
On 01/05/2022 13:36, Marty E. Plummer wrote:
> On Sun, May 01, 2022 at 10:35:37AM +0200, Krzysztof Kozlowski wrote:
>> On 01/05/2022 07:10, Marty E. Plummer wrote:
>>> Add CRG driver for Hi3521A SoC. CRG (Clock and Reset Generator) module
>>> generates clock and reset signals used by other module blocks on SoC.
>>>
>>>
>> (...)
>>
>>> + return;
>>> +
>>> + hisi_clk_register_mux(hi3521a_sysctrl_mux_clks,
>>> + ARRAY_SIZE(hi3521a_sysctrl_mux_clks),
>>> + clk_data);
>>> +}
>>> +CLK_OF_DECLARE(hi3521a_sysctrl, "hisilicon,hi3521a-sysctrl", hi3521a_sysctrl_init);
>> Missing bindings.
>>
> Assume you mean the Documentation/dt/binding/... file? Will do. I
> probably should have prefixed it with RFC, as I'm mostly hoping to get
> the attention of the hisi people to see what's the deal with the mtd
> reads being borked.
Then just don't Cc devicetree folks and put in cover letter disclaimer
that this was intentionally omitted and will be later fixed.
It is a waste of time of reviewers to look/filter/organize such email,
if it is intentionally not for us.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-03 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220501051020.2432338-1-hanetzer@startmail.com>
2022-05-01 5:10 ` [PATCH 1/2] clk: hisilicon: add CRG driver Hi3521a SoC Marty E. Plummer
2022-05-01 8:35 ` Krzysztof Kozlowski
2022-05-01 11:36 ` Marty E. Plummer
2022-05-03 9:41 ` Krzysztof Kozlowski [this message]
2022-05-03 10:08 ` Marty E. Plummer
2022-05-01 5:10 ` [PATCH 2/2] arm: hisi: enable Hi3521a soc Marty E. Plummer
2022-05-01 8:32 ` kernel test robot
2022-05-01 8:36 ` Krzysztof Kozlowski
2022-05-01 11:37 ` Marty E. Plummer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bacc123d-bedc-0034-6591-3ef0caf270ae@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hanetzer@startmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox