* [PATCH] arm64: dts: broadcom: bcm4908: add I2C block
@ 2022-02-11 10:33 Rafał Miłecki
2022-02-11 17:12 ` Florian Fainelli
2022-02-15 6:36 ` [PATCH V2] " Rafał Miłecki
0 siblings, 2 replies; 4+ messages in thread
From: Rafał Miłecki @ 2022-02-11 10:33 UTC (permalink / raw)
To: Florian Fainelli, Rob Herring
Cc: linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 uses the same I2C hw as BCM63xx / BCM67xx / BCM68xx SoCs.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index b0bc5262beca..9ae298e7d6cf 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -464,6 +464,15 @@ nandcs: nand@0 {
};
};
+ i2c@2100 {
+ compatible = "brcm,brcmstb-i2c";
+ reg = <0x2100 0x58>;
+ clock-frequency = <97500>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pins_i2c_a>;
+ status = "disabled";
+ };
+
misc@2600 {
compatible = "brcm,misc", "simple-mfd";
reg = <0x2600 0xe4>;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: bcm4908: add I2C block
2022-02-11 10:33 [PATCH] arm64: dts: broadcom: bcm4908: add I2C block Rafał Miłecki
@ 2022-02-11 17:12 ` Florian Fainelli
2022-02-15 6:36 ` [PATCH V2] " Rafał Miłecki
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-02-11 17:12 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli, Rob Herring,
Kamal Dasu
Cc: linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
+Kamal,
On 2/11/22 2:33 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 uses the same I2C hw as BCM63xx / BCM67xx / BCM68xx SoCs.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> index b0bc5262beca..9ae298e7d6cf 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> @@ -464,6 +464,15 @@ nandcs: nand@0 {
> };
> };
>
> + i2c@2100 {
> + compatible = "brcm,brcmstb-i2c";
We should be making it clearer in the DT binding, but this should be
brcm,brcmper-i2c since that was the compatible string added for the DSL
class of chips, I forgot whether Kamal had to key off that compatible or
not, it does not look it.
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V2] arm64: dts: broadcom: bcm4908: add I2C block
2022-02-11 10:33 [PATCH] arm64: dts: broadcom: bcm4908: add I2C block Rafał Miłecki
2022-02-11 17:12 ` Florian Fainelli
@ 2022-02-15 6:36 ` Rafał Miłecki
2022-02-15 21:52 ` Florian Fainelli
1 sibling, 1 reply; 4+ messages in thread
From: Rafał Miłecki @ 2022-02-15 6:36 UTC (permalink / raw)
To: Florian Fainelli, Rob Herring
Cc: linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Kamal Dasu, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 uses the same I2C hw as BCM63xx / BCM67xx / BCM68xx SoCs.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
This patch is based on (and targets):
https://github.com/Broadcom/stblinux.git devicetree-arm64/next
V2: Use correct binding that implies 8 B max transfer size. See commit
e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
for details.
---
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index b0bc5262beca..5158143a9018 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -464,6 +464,15 @@ nandcs: nand@0 {
};
};
+ i2c@2100 {
+ compatible = "brcm,brcmper-i2c";
+ reg = <0x2100 0x58>;
+ clock-frequency = <97500>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pins_i2c_a>;
+ status = "disabled";
+ };
+
misc@2600 {
compatible = "brcm,misc", "simple-mfd";
reg = <0x2600 0xe4>;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2] arm64: dts: broadcom: bcm4908: add I2C block
2022-02-15 6:36 ` [PATCH V2] " Rafał Miłecki
@ 2022-02-15 21:52 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-02-15 21:52 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki, Rob Herring
Cc: linux-arm-kernel, devicetree, Kamal Dasu, Rafał Miłecki
On Tue, 15 Feb 2022 07:36:39 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 uses the same I2C hw as BCM63xx / BCM67xx / BCM68xx SoCs.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-15 21:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-11 10:33 [PATCH] arm64: dts: broadcom: bcm4908: add I2C block Rafał Miłecki
2022-02-11 17:12 ` Florian Fainelli
2022-02-15 6:36 ` [PATCH V2] " Rafał Miłecki
2022-02-15 21:52 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).