From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A1DB6F2EF; Wed, 19 Jun 2024 06:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718780146; cv=none; b=eR3kuHKfRzkDvvjVgr6RN/Mj0Cs1ArZ9p67Q9dtJikA++ytsl6XywI0LugvjACDNPDQ5W+MmHLv+hkljy1I6LN1wZHSO/kBZZvgQ3zYYeh0tzmY4DZwK3fguuNq78J2XmDjA0B0/+9AEe/JPuVGVtzeZJ5oEhHmBi7WFj432IpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718780146; c=relaxed/simple; bh=hgH4DDDvAA9kgOZ2n3TjfNXg8eHsBsoYv2LJciY4Ixw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ouJJbsuKZWTr9rxa1/hngkaOvo2C7TKzbFVTfjGmab5TKae/SFzvlFQUi3mYT76C4ryVxYHhbhjEuB5zz6Dv+jEj2VqCFzl7jzcdZ6Htb+2LyE/Nc83hsIOxlinUw4WQZKQzg0RdjzlrgSlmu0y3ISzswk8z0oBS++OPOI2mBHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=WTIOUwKR; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="WTIOUwKR" Received: from pecola.lan (unknown [159.196.93.152]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 2112C20127; Wed, 19 Jun 2024 14:55:35 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1718780136; bh=hgH4DDDvAA9kgOZ2n3TjfNXg8eHsBsoYv2LJciY4Ixw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=WTIOUwKRVPebDE+XFoyICYbLin7nX/vvQXC3AKRpUd3b0uxE/GDSDvyMybgzRCTFA XWz7D6Xw+kLwrrsq0WgD0pMPLdJHz4DTMP8bbs11PjVC+k7Sii4vPzRlPB0jWfF0S4 gVIs5drwwyCeUrJdGWsyE4eAGafdpf56kYUcLC/HBRRpCvCJg7MPf6Fap0yKMpyTeo I0Ladfm5LUXJWleJl40TjU5ek/Jj2Iwh7yq0Bc4qmzaavWU7NekEBhz+VReWH10Dvw AnuhpmvXCVf6T3oQXIMfPzcLqzRKGuNMoeSyEkej2v9OE2BvYVcO0EOz1TMcyMdNXa Urz5aAipwmYnQ== Message-ID: Subject: Re: [PATCH 2/2] i3c: i3c-hub: Add Renesas RG3MxxB12A1 I3C HUB driver From: Jeremy Kerr To: Steven Niu , alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org Cc: zbigniew.lukwinski@linux.intel.com Date: Wed, 19 Jun 2024 14:55:35 +0800 In-Reply-To: <20240217131412.4145506-2-steven.niu.uj@renesas.com> References: <20240217131412.4145506-1-steven.niu.uj@renesas.com> <20240217131412.4145506-2-steven.niu.uj@renesas.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Steven, > RG3MxxB12A1 I3C HUB is smart device which provide multiple > functionality: > * Enabling voltage compatibility across I3C Controller and Target > Device. > * Enabling voltage compatibility across I3C Controller and Target > devices. > * Bus capacitance isolation. > * Address conflict isolation. > * I3C port expansion. > * Two controllers in a single I3C bus. > * I3C and SMBus device compatibility. > * GPIO expansion. Do you plan any more work on this driver? It would be great to have this included upstream, but looks like there's a fairly large amount of work required to get to that point, particularly in regards to using existing kernel infrastructure to support the device functions. Anything I can do to help there? Would a (further) review on this series be useful? Cheers, Jeremy