From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH] arm64: dts: rockchip: add USB 2.0 and 3.0 support on Ficus board Date: Thu, 12 Jul 2018 20:57:28 -0300 Message-ID: References: <20180712160008.30972-1-ezequiel@collabora.com> <1807608.jKivtyaJVm@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1807608.jKivtyaJVm@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Heiko Stuebner Cc: Mark Rutland , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Enric Balletbo i Serra , kernel@collabora.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thu, 2018-07-12 at 23:45 +0200, Heiko Stuebner wrote: > Hi, > > Am Donnerstag, 12. Juli 2018, 18:00:08 CEST schrieb Ezequiel Garcia: > > From: Enric Balletbo i Serra > > > > The board exposes two types A ports, one is USB 3.0, up to 5.0Gbps and > > another one is USB 2.0 up to 480Mbps. Enable the USB PHYs and the USB > > controllers to enable theses devices. > > > > Signed-off-by: Enric Balletbo i Serra > > Signed-off-by: Ezequiel Garcia > > --- > > Heiko, > > > > Enric finally had some time to take a look at the schematics, > > and help with the USB stuff. Thanks to him, USB host > > is working now! \o/ > > great to hear that > One issue below though. > > > > USB Type-C will have to wait until we have some spare time > > to debug the fusb302 driver. > > > > arch/arm64/boot/dts/rockchip/rk3399-ficus.dts | 85 +++++++++++++++++++ > > 1 file changed, 85 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts b/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > > index 0d14183dd4a9..d0631c02749c 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > > @@ -61,6 +61,16 @@ > > vin-supply = <&vcc3v3_sys>; > > }; > > > > + vcc5v0_host: vcc5v0-host-regulator { > > + compatible = "regulator-fixed"; > > + enable-active-high; > > + gpio = <&gpio4 27 GPIO_ACTIVE_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&host_vbus_drv>; > > + regulator-name = "vcc5v0_host"; > > + regulator-always-on; > > missing voltages and also a vin-supply. Indeed. > These 5V don't come from thin air ;-) and I really like > seeing sane regulator trees. > Oh, right. And vcc3v3_pcie is also missing the min/max voltages, so I'll add them. I guess it's better to have these voltage properties -- despite they are listed as optional. Thanks for reviewing, Eze