From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA13E1E9B00; Tue, 7 Jan 2025 14:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736260485; cv=none; b=VSgkjGSR16fX9xA3XCBTX9jJf+1Lmg4UWpQd8D0Nw4e1oyqlidRNFGk7yh8ICIVWk/5F0AmukuCSjPmSaxAMhANe8+LIqFFK87nyvEsh6a/KyvMLuebAK8riVKyMSUu3/rkojexI3LeXBOv8lAEQ4D409WT0ODFCiWUWedurVBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736260485; c=relaxed/simple; bh=NnEuU732Q2GHB9/XmZ0w1TBbyujLhtEnhhQNwBl2Ylk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pQBLUQRATZjIPvzo6HVs1b3AtTftM8mW+35sjTn/9tGlHlqvz8DYscUpgc4X1RHvwThjLS12CpFzeFOgTjQr0jH3eXrOLBHQbs5mzqe7dCPe8F0+/wA3f4HgRUvFM01JwbZ7b+ntm9j0Thyx8pHeHAQqOCrcAocKRCxetVDOd4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 520CC1424; Tue, 7 Jan 2025 06:35:10 -0800 (PST) Received: from [10.57.4.77] (unknown [10.57.4.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 40AF73F59E; Tue, 7 Jan 2025 06:34:40 -0800 (PST) Message-ID: Date: Tue, 7 Jan 2025 14:34:38 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] arm64: dts: morello: Add support for common functionalities Content-Language: en-GB To: Jessica Clarke , Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Krzysztof Kozlowski , Conor Dooley , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Russell King References: <20250103181623.1980433-1-vincenzo.frascino@arm.com> <20250103181623.1980433-3-vincenzo.frascino@arm.com> From: Vincenzo Frascino In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Jessica, Thank you for your review. On 07/01/2025 12:56, Jessica Clarke wrote: > On Fri, Jan 03, 2025 at 04:14:31PM -0600, Rob Herring wrote: >> On Fri, Jan 3, 2025 at 12:16 PM Vincenzo Frascino >> wrote: >>> + cpus { >>> + #address-cells = <2>; >>> + #size-cells = <0>; >>> + >>> + cpu0: cpu@0 { >>> + compatible = "arm,neoverse-n1"; >> >> I'm pretty sure the N1 doesn't support CHERI/morello. Perhaps >> "arm,neoverse-n1-morello" if we want to capture what it is derived >> from and since "arm,morello" is taken already. > > Rainier is the codename of the core itself, and Morello LLVM recognises > -mcpu=rainier not -mcpu=morello (there's -march=morello instead), so > perhaps it should really be "arm,rainier". Though SMBIOS reports it as > Morello-R0P1 so it may be best to use "arm,morello" here. > We agree on the concept. It should either be "arm,rainier" or "arm,morello-r0p1" if we want to capture the information of SMBIOS. When we reach consensus I will update the patches accordingly (Please have a look at my reply to Rob). > The real problem is that the board compatible has changed to include a > generic "arm,morello" node, with the argument that a v2 board could > appear. So why not instead change *that* to be something like: > > compatible = "arm,morello-sdp-v1", "arm,morello-sdp"; > > Then you can use "arm,morello" here for the cores.> The name morello on its own is too overloaded of meaning if we do not specify to what we are referring to. > Though some of this may depend on what the FVP's DTS looks like; is it > going to claim to be a Morello SDP, or does there need to be a common > denominator compatible beneath that it can use? > I still did not start bringing up to speed the DTS for FVP but I think that we should distinguish in between SDP and FVP since not everything is the same, hence it should have something similar to: compatible = "arm,morello-fvp", "arm,morello"; > Please CC me on future versions of this series. > Will do. > Jess -- Regards, Vincenzo