From: Scott Wood <oss@buserror.net>
To: andy.tang@nxp.com, mturquette@baylibre.com
Cc: sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] powerpc: t102x: upgrade the legacy clock node
Date: Sat, 20 Oct 2018 18:53:58 -0500 [thread overview]
Message-ID: <bb158670f1556156f17c3a9eefaa0a5e35c1591e.camel@buserror.net> (raw)
In-Reply-To: <20180919073906.34187-2-andy.tang@nxp.com>
On Wed, 2018-09-19 at 15:39 +0800, andy.tang@nxp.com wrote:
> +clockgen: global-utilities@e1000 {
> + compatible = "fsl,qoriq-clockgen";
Where does this compatible string come from?
> + compatible = "fsl,t1023-clockgen";
> };
And here you overwrite it with only the chip-specific compatible?
Is t1023 incompatible with both fsl,qoriq-clockgen-1.0 and fsl,qoriq-clockgen-
2.0? The existing dts says 2.0; is that wrong?
BTW, assuming it is 2.0 compatible and thus the use of qoriq-clockgen2.dtsi is
correct, the best course of action is probably to to remove the legacy stuff
from all fsl chips, rather than introduce a new dtsi. In fact it'd be nice to
see it all removed in any case. :-)
Also, please post any patches that you want me to apply to the linuxppc-dev
mailing list.
-Scott
next prev parent reply other threads:[~2018-10-20 23:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 7:39 [PATCH 1/3] clk: qoriq: add t1023 soc support andy.tang
2018-09-19 7:39 ` [PATCH 2/3] powerpc: t102x: upgrade the legacy clock node andy.tang
2018-09-19 7:39 ` [PATCH 3/3] clk: qoriq: add t1023 soc support andy.tang
2018-10-20 23:53 ` Scott Wood [this message]
2018-10-22 1:34 ` [PATCH 2/3] powerpc: t102x: upgrade the legacy clock node Andy Tang
2018-10-22 5:20 ` Scott Wood
2018-10-22 7:48 ` Andy Tang
2018-10-16 6:17 ` [PATCH 1/3] clk: qoriq: add t1023 soc support Andy Tang
2018-10-17 15:27 ` Stephen Boyd
2018-10-18 1:00 ` Andy Tang
2018-10-19 6:28 ` Scott Wood
2018-10-19 6:47 ` Andy Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb158670f1556156f17c3a9eefaa0a5e35c1591e.camel@buserror.net \
--to=oss@buserror.net \
--cc=andy.tang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).