From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch
Date: Thu, 27 Oct 2022 21:28:15 -0400 [thread overview]
Message-ID: <bb23a9e0-1264-702e-a646-8de5afedb23e@linaro.org> (raw)
In-Reply-To: <20221027134034.2343230-2-yoshihiro.shimoda.uh@renesas.com>
On 27/10/2022 09:40, Yoshihiro Shimoda wrote:
> Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0).
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> +
> + ethernet-ports:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + '#address-cells':
> + description: Port number of ETHA (TSNA).
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> + patternProperties:
> + "^port@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/net/ethernet-controller.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + description:
> + Port number of ETHA (TSNA).
I think you need here "maxItems: 1" as no schema sets the limit. I did
not notice it before.
> +
> + phys:
> + maxItems: 1
> + description:
> + Phandle of an Ethernet SERDES.
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-28 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 13:40 [PATCH v5 0/3] net: ethernet: renesas: Add support for "Ethernet Switch" Yoshihiro Shimoda
2022-10-27 13:40 ` [PATCH v5 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch Yoshihiro Shimoda
2022-10-28 1:28 ` Krzysztof Kozlowski [this message]
2022-10-28 4:17 ` Yoshihiro Shimoda
2022-10-27 13:40 ` [PATCH v5 2/3] net: ethernet: renesas: Add support for "Ethernet Switch" Yoshihiro Shimoda
2022-10-27 13:40 ` [PATCH v5 3/3] net: ethernet: renesas: rswitch: Add R-Car Gen4 gPTP support Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb23a9e0-1264-702e-a646-8de5afedb23e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).