From: Lucas Tanure <tanure@linux.com>
To: neil.armstrong@linaro.org, Huqiang Qin <huqiang.qin@amlogic.com>,
tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, hkallweit1@gmail.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: Add gpio_intc node for Amlogic-T7 SoCs
Date: Wed, 27 Sep 2023 07:07:02 +0100 [thread overview]
Message-ID: <bb37e3ec-d0b9-4b73-ac6e-183b55e8814f@linux.com> (raw)
In-Reply-To: <4c1566e0-a502-4379-b360-9e6ef374af04@linaro.org>
On 14-09-2023 09:26, neil.armstrong@linaro.org wrote:
> On 13/09/2023 10:09, Huqiang Qin wrote:
>> Add GPIO interrupt controller device.
>>
>> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
>> ---
>> arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> index dae3465bd39b..21b2436c47e2 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> @@ -155,6 +155,16 @@ watchdog@2100 {
>> clocks = <&xtal>;
>> };
>> + gpio_intc: interrupt-controller@4080 {
>> + compatible = "amlogic,t7-gpio-intc",
>> + "amlogic,meson-gpio-intc";
>> + reg = <0x0 0x4080 0x0 0x20>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + amlogic,channel-interrupts =
>> + <10 11 12 13 14 15 16 17 18 19 20 21>;
>> + };
>> +
>> uart_a: serial@78000 {
>> compatible = "amlogic,t7-uart",
>> "amlogic,meson-s4-uart";
>> reg = <0x0 0x78000 0x0 0x18>;
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
I re-tested this today with Vim4 and works fine.
By works I mean, vim4 is able to boot without panics but drops to
emergency shell as expected.
Tested-by: Lucas Tanure <tanure@linux.com>
next prev parent reply other threads:[~2023-09-27 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 8:09 [PATCH 0/3] Add GPIO interrupt support for Amlogic-T7 SoCs Huqiang Qin
2023-09-13 8:09 ` [PATCH 1/3] dt-bindings: interrupt-controller: Add " Huqiang Qin
2023-09-13 14:32 ` Conor Dooley
2023-09-13 8:09 ` [PATCH 2/3] irqchip: " Huqiang Qin
2023-09-14 8:26 ` neil.armstrong
2023-09-27 6:07 ` Lucas Tanure
2023-09-13 8:09 ` [PATCH 3/3] arm64: dts: Add gpio_intc node " Huqiang Qin
2023-09-14 8:26 ` neil.armstrong
2023-09-27 6:07 ` Lucas Tanure [this message]
2023-11-13 6:03 ` [PATCH 0/3] Add GPIO interrupt support " Huqiang Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb37e3ec-d0b9-4b73-ac6e-183b55e8814f@linux.com \
--to=tanure@linux.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=maz@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).