* [PATCH 1/3] dt-bindings: interrupt-controller: Add support for Amlogic-T7 SoCs
2023-09-13 8:09 [PATCH 0/3] Add GPIO interrupt support for Amlogic-T7 SoCs Huqiang Qin
@ 2023-09-13 8:09 ` Huqiang Qin
2023-09-13 14:32 ` Conor Dooley
2023-09-13 8:09 ` [PATCH 2/3] irqchip: " Huqiang Qin
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Huqiang Qin @ 2023-09-13 8:09 UTC (permalink / raw)
To: tglx, maz, robh+dt, krzysztof.kozlowski+dt, conor+dt,
neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic,
Huqiang Qin
Update dt-binding document for GPIO interrupt controller
of Amlogic-T7 SoCs.
Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
---
.../bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
index 3d06db98e978..a93744763787 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
@@ -36,6 +36,7 @@ properties:
- amlogic,meson-a1-gpio-intc
- amlogic,meson-s4-gpio-intc
- amlogic,c3-gpio-intc
+ - amlogic,t7-gpio-intc
- const: amlogic,meson-gpio-intc
reg:
--
2.37.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] dt-bindings: interrupt-controller: Add support for Amlogic-T7 SoCs
2023-09-13 8:09 ` [PATCH 1/3] dt-bindings: interrupt-controller: Add " Huqiang Qin
@ 2023-09-13 14:32 ` Conor Dooley
0 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-09-13 14:32 UTC (permalink / raw)
To: Huqiang Qin
Cc: tglx, maz, robh+dt, krzysztof.kozlowski+dt, conor+dt,
neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1,
linux-kernel, devicetree, linux-arm-kernel, linux-amlogic
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
On Wed, Sep 13, 2023 at 04:09:22PM +0800, Huqiang Qin wrote:
> Update dt-binding document for GPIO interrupt controller
> of Amlogic-T7 SoCs.
>
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> .../bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> index 3d06db98e978..a93744763787 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> @@ -36,6 +36,7 @@ properties:
> - amlogic,meson-a1-gpio-intc
> - amlogic,meson-s4-gpio-intc
> - amlogic,c3-gpio-intc
> + - amlogic,t7-gpio-intc
> - const: amlogic,meson-gpio-intc
>
> reg:
> --
> 2.37.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] irqchip: Add support for Amlogic-T7 SoCs
2023-09-13 8:09 [PATCH 0/3] Add GPIO interrupt support for Amlogic-T7 SoCs Huqiang Qin
2023-09-13 8:09 ` [PATCH 1/3] dt-bindings: interrupt-controller: Add " Huqiang Qin
@ 2023-09-13 8:09 ` Huqiang Qin
2023-09-14 8:26 ` neil.armstrong
2023-09-13 8:09 ` [PATCH 3/3] arm64: dts: Add gpio_intc node " Huqiang Qin
2023-11-13 6:03 ` [PATCH 0/3] Add GPIO interrupt support " Huqiang Qin
3 siblings, 1 reply; 10+ messages in thread
From: Huqiang Qin @ 2023-09-13 8:09 UTC (permalink / raw)
To: tglx, maz, robh+dt, krzysztof.kozlowski+dt, conor+dt,
neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic,
Huqiang Qin
The Amlogic-T7 SoCs support 12 GPIO IRQ lines compared with previous
serial chips and have something different, details are as below.
IRQ Number:
- 156 1 pin on bank TESTN
- 155:148 8 pins on bank H
- 147:129 19 pins on bank Y
- 128:115 14 pins on bank M
- 114:91 24 pins on bank T
- 90:77 14 pins on bank Z
- 76:70 7 pins on bank E
- 69:57 13 pins on bank D
- 56:40 17 pins on bank W
- 39:20 20 pins on bank X
- 19:13 7 pins on bank C
- 12:0 13 pins on bank B
Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
---
drivers/irqchip/irq-meson-gpio.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
index f88df39f4129..9a1791908598 100644
--- a/drivers/irqchip/irq-meson-gpio.c
+++ b/drivers/irqchip/irq-meson-gpio.c
@@ -154,6 +154,10 @@ static const struct meson_gpio_irq_params c3_params = {
INIT_MESON_S4_COMMON_DATA(55)
};
+static const struct meson_gpio_irq_params t7_params = {
+ INIT_MESON_S4_COMMON_DATA(157)
+};
+
static const struct of_device_id meson_irq_gpio_matches[] __maybe_unused = {
{ .compatible = "amlogic,meson8-gpio-intc", .data = &meson8_params },
{ .compatible = "amlogic,meson8b-gpio-intc", .data = &meson8b_params },
@@ -165,6 +169,7 @@ static const struct of_device_id meson_irq_gpio_matches[] __maybe_unused = {
{ .compatible = "amlogic,meson-a1-gpio-intc", .data = &a1_params },
{ .compatible = "amlogic,meson-s4-gpio-intc", .data = &s4_params },
{ .compatible = "amlogic,c3-gpio-intc", .data = &c3_params },
+ { .compatible = "amlogic,t7-gpio-intc", .data = &t7_params },
{ }
};
--
2.37.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] irqchip: Add support for Amlogic-T7 SoCs
2023-09-13 8:09 ` [PATCH 2/3] irqchip: " Huqiang Qin
@ 2023-09-14 8:26 ` neil.armstrong
2023-09-27 6:07 ` Lucas Tanure
0 siblings, 1 reply; 10+ messages in thread
From: neil.armstrong @ 2023-09-14 8:26 UTC (permalink / raw)
To: Huqiang Qin, tglx, maz, robh+dt, krzysztof.kozlowski+dt, conor+dt,
khilman, jbrunet, martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic
On 13/09/2023 10:09, Huqiang Qin wrote:
> The Amlogic-T7 SoCs support 12 GPIO IRQ lines compared with previous
> serial chips and have something different, details are as below.
>
> IRQ Number:
> - 156 1 pin on bank TESTN
> - 155:148 8 pins on bank H
> - 147:129 19 pins on bank Y
> - 128:115 14 pins on bank M
> - 114:91 24 pins on bank T
> - 90:77 14 pins on bank Z
> - 76:70 7 pins on bank E
> - 69:57 13 pins on bank D
> - 56:40 17 pins on bank W
> - 39:20 20 pins on bank X
> - 19:13 7 pins on bank C
> - 12:0 13 pins on bank B
>
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
> ---
> drivers/irqchip/irq-meson-gpio.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
> index f88df39f4129..9a1791908598 100644
> --- a/drivers/irqchip/irq-meson-gpio.c
> +++ b/drivers/irqchip/irq-meson-gpio.c
> @@ -154,6 +154,10 @@ static const struct meson_gpio_irq_params c3_params = {
> INIT_MESON_S4_COMMON_DATA(55)
> };
>
> +static const struct meson_gpio_irq_params t7_params = {
> + INIT_MESON_S4_COMMON_DATA(157)
> +};
> +
> static const struct of_device_id meson_irq_gpio_matches[] __maybe_unused = {
> { .compatible = "amlogic,meson8-gpio-intc", .data = &meson8_params },
> { .compatible = "amlogic,meson8b-gpio-intc", .data = &meson8b_params },
> @@ -165,6 +169,7 @@ static const struct of_device_id meson_irq_gpio_matches[] __maybe_unused = {
> { .compatible = "amlogic,meson-a1-gpio-intc", .data = &a1_params },
> { .compatible = "amlogic,meson-s4-gpio-intc", .data = &s4_params },
> { .compatible = "amlogic,c3-gpio-intc", .data = &c3_params },
> + { .compatible = "amlogic,t7-gpio-intc", .data = &t7_params },
> { }
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] irqchip: Add support for Amlogic-T7 SoCs
2023-09-14 8:26 ` neil.armstrong
@ 2023-09-27 6:07 ` Lucas Tanure
0 siblings, 0 replies; 10+ messages in thread
From: Lucas Tanure @ 2023-09-27 6:07 UTC (permalink / raw)
To: neil.armstrong, Huqiang Qin, tglx, maz, robh+dt,
krzysztof.kozlowski+dt, conor+dt, khilman, jbrunet,
martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic
On 14-09-2023 09:26, neil.armstrong@linaro.org wrote:
> On 13/09/2023 10:09, Huqiang Qin wrote:
>> The Amlogic-T7 SoCs support 12 GPIO IRQ lines compared with previous
>> serial chips and have something different, details are as below.
>>
>> IRQ Number:
>> - 156 1 pin on bank TESTN
>> - 155:148 8 pins on bank H
>> - 147:129 19 pins on bank Y
>> - 128:115 14 pins on bank M
>> - 114:91 24 pins on bank T
>> - 90:77 14 pins on bank Z
>> - 76:70 7 pins on bank E
>> - 69:57 13 pins on bank D
>> - 56:40 17 pins on bank W
>> - 39:20 20 pins on bank X
>> - 19:13 7 pins on bank C
>> - 12:0 13 pins on bank B
>>
>> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
>> ---
>> drivers/irqchip/irq-meson-gpio.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/irqchip/irq-meson-gpio.c
>> b/drivers/irqchip/irq-meson-gpio.c
>> index f88df39f4129..9a1791908598 100644
>> --- a/drivers/irqchip/irq-meson-gpio.c
>> +++ b/drivers/irqchip/irq-meson-gpio.c
>> @@ -154,6 +154,10 @@ static const struct meson_gpio_irq_params
>> c3_params = {
>> INIT_MESON_S4_COMMON_DATA(55)
>> };
>> +static const struct meson_gpio_irq_params t7_params = {
>> + INIT_MESON_S4_COMMON_DATA(157)
>> +};
>> +
>> static const struct of_device_id meson_irq_gpio_matches[]
>> __maybe_unused = {
>> { .compatible = "amlogic,meson8-gpio-intc", .data =
>> &meson8_params },
>> { .compatible = "amlogic,meson8b-gpio-intc", .data =
>> &meson8b_params },
>> @@ -165,6 +169,7 @@ static const struct of_device_id
>> meson_irq_gpio_matches[] __maybe_unused = {
>> { .compatible = "amlogic,meson-a1-gpio-intc", .data = &a1_params },
>> { .compatible = "amlogic,meson-s4-gpio-intc", .data = &s4_params },
>> { .compatible = "amlogic,c3-gpio-intc", .data = &c3_params },
>> + { .compatible = "amlogic,t7-gpio-intc", .data = &t7_params },
>> { }
>> };
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.orgTested-by: Lucas Tanure <tanure@linux.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: dts: Add gpio_intc node for Amlogic-T7 SoCs
2023-09-13 8:09 [PATCH 0/3] Add GPIO interrupt support for Amlogic-T7 SoCs Huqiang Qin
2023-09-13 8:09 ` [PATCH 1/3] dt-bindings: interrupt-controller: Add " Huqiang Qin
2023-09-13 8:09 ` [PATCH 2/3] irqchip: " Huqiang Qin
@ 2023-09-13 8:09 ` Huqiang Qin
2023-09-14 8:26 ` neil.armstrong
2023-11-13 6:03 ` [PATCH 0/3] Add GPIO interrupt support " Huqiang Qin
3 siblings, 1 reply; 10+ messages in thread
From: Huqiang Qin @ 2023-09-13 8:09 UTC (permalink / raw)
To: tglx, maz, robh+dt, krzysztof.kozlowski+dt, conor+dt,
neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic,
Huqiang Qin
Add GPIO interrupt controller device.
Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
---
arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
index dae3465bd39b..21b2436c47e2 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
@@ -155,6 +155,16 @@ watchdog@2100 {
clocks = <&xtal>;
};
+ gpio_intc: interrupt-controller@4080 {
+ compatible = "amlogic,t7-gpio-intc",
+ "amlogic,meson-gpio-intc";
+ reg = <0x0 0x4080 0x0 0x20>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ amlogic,channel-interrupts =
+ <10 11 12 13 14 15 16 17 18 19 20 21>;
+ };
+
uart_a: serial@78000 {
compatible = "amlogic,t7-uart", "amlogic,meson-s4-uart";
reg = <0x0 0x78000 0x0 0x18>;
--
2.37.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] arm64: dts: Add gpio_intc node for Amlogic-T7 SoCs
2023-09-13 8:09 ` [PATCH 3/3] arm64: dts: Add gpio_intc node " Huqiang Qin
@ 2023-09-14 8:26 ` neil.armstrong
2023-09-27 6:07 ` Lucas Tanure
0 siblings, 1 reply; 10+ messages in thread
From: neil.armstrong @ 2023-09-14 8:26 UTC (permalink / raw)
To: Huqiang Qin, tglx, maz, robh+dt, krzysztof.kozlowski+dt, conor+dt,
khilman, jbrunet, martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic
On 13/09/2023 10:09, Huqiang Qin wrote:
> Add GPIO interrupt controller device.
>
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
> ---
> arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> index dae3465bd39b..21b2436c47e2 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> @@ -155,6 +155,16 @@ watchdog@2100 {
> clocks = <&xtal>;
> };
>
> + gpio_intc: interrupt-controller@4080 {
> + compatible = "amlogic,t7-gpio-intc",
> + "amlogic,meson-gpio-intc";
> + reg = <0x0 0x4080 0x0 0x20>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + amlogic,channel-interrupts =
> + <10 11 12 13 14 15 16 17 18 19 20 21>;
> + };
> +
> uart_a: serial@78000 {
> compatible = "amlogic,t7-uart", "amlogic,meson-s4-uart";
> reg = <0x0 0x78000 0x0 0x18>;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] arm64: dts: Add gpio_intc node for Amlogic-T7 SoCs
2023-09-14 8:26 ` neil.armstrong
@ 2023-09-27 6:07 ` Lucas Tanure
0 siblings, 0 replies; 10+ messages in thread
From: Lucas Tanure @ 2023-09-27 6:07 UTC (permalink / raw)
To: neil.armstrong, Huqiang Qin, tglx, maz, robh+dt,
krzysztof.kozlowski+dt, conor+dt, khilman, jbrunet,
martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic
On 14-09-2023 09:26, neil.armstrong@linaro.org wrote:
> On 13/09/2023 10:09, Huqiang Qin wrote:
>> Add GPIO interrupt controller device.
>>
>> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
>> ---
>> arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> index dae3465bd39b..21b2436c47e2 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> @@ -155,6 +155,16 @@ watchdog@2100 {
>> clocks = <&xtal>;
>> };
>> + gpio_intc: interrupt-controller@4080 {
>> + compatible = "amlogic,t7-gpio-intc",
>> + "amlogic,meson-gpio-intc";
>> + reg = <0x0 0x4080 0x0 0x20>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + amlogic,channel-interrupts =
>> + <10 11 12 13 14 15 16 17 18 19 20 21>;
>> + };
>> +
>> uart_a: serial@78000 {
>> compatible = "amlogic,t7-uart",
>> "amlogic,meson-s4-uart";
>> reg = <0x0 0x78000 0x0 0x18>;
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
I re-tested this today with Vim4 and works fine.
By works I mean, vim4 is able to boot without panics but drops to
emergency shell as expected.
Tested-by: Lucas Tanure <tanure@linux.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add GPIO interrupt support for Amlogic-T7 SoCs
2023-09-13 8:09 [PATCH 0/3] Add GPIO interrupt support for Amlogic-T7 SoCs Huqiang Qin
` (2 preceding siblings ...)
2023-09-13 8:09 ` [PATCH 3/3] arm64: dts: Add gpio_intc node " Huqiang Qin
@ 2023-11-13 6:03 ` Huqiang Qin
3 siblings, 0 replies; 10+ messages in thread
From: Huqiang Qin @ 2023-11-13 6:03 UTC (permalink / raw)
To: tglx, maz, robh+dt, krzysztof.kozlowski+dt, conor+dt,
neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1
Cc: linux-kernel, devicetree, linux-arm-kernel, linux-amlogic
Hi Thomas, Marc
Friendly ping.
On 2023/9/13 16:09, Huqiang Qin wrote:
> This patch adds GPIO interrupt support for Amloigc-T7 SoC (A311D2)
>
> Huqiang Qin (3):
> dt-bindings: interrupt-controller: Add support for Amlogic-T7 SoCs
> irqchip: Add support for Amlogic-T7 SoCs
> arm64: dts: Add gpio_intc node for Amlogic-T7 SoCs
>
> .../interrupt-controller/amlogic,meson-gpio-intc.yaml | 1 +
> arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 10 ++++++++++
> drivers/irqchip/irq-meson-gpio.c | 5 +++++
> 3 files changed, 16 insertions(+)
>
>
> base-commit: e143016b56ecb0fcda5bb6026b0a25fe55274f56
Best Regards,
Huqiang
^ permalink raw reply [flat|nested] 10+ messages in thread