From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
imx@lists.linux.dev, Jiri Slaby <jirislaby@kernel.org>,
joe@perches.com, krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org, linux-i3c@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
miquel.raynal@bootlin.com, robh@kernel.org,
zbigniew.lukwinski@linux.intel.com
Subject: Re: [PATCH v4 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h
Date: Wed, 24 Jan 2024 16:59:36 +0200 (EET) [thread overview]
Message-ID: <bb434214-0607-4054-dd04-a870db9e7f5d@linux.intel.com> (raw)
In-Reply-To: <20240123231043.3891847-5-Frank.Li@nxp.com>
On Tue, 23 Jan 2024, Frank Li wrote:
> SVC i3c is a dual role controller. Move probe() into svc-i3c-main.c. This
> prepares to support target probe depending on dts "mode" settings.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/i3c/master/Makefile | 3 +-
> drivers/i3c/master/svc-i3c-main.c | 52 +++++++++++++++++++++++++++++
> drivers/i3c/master/svc-i3c-master.c | 34 ++++---------------
> drivers/i3c/master/svc-i3c.h | 11 ++++++
> 4 files changed, 71 insertions(+), 29 deletions(-)
> create mode 100644 drivers/i3c/master/svc-i3c-main.c
> create mode 100644 drivers/i3c/master/svc-i3c.h
>
> diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile
> index 3e97960160bc8..484cb81f45821 100644
> --- a/drivers/i3c/master/Makefile
> +++ b/drivers/i3c/master/Makefile
> @@ -2,5 +2,6 @@
> obj-$(CONFIG_CDNS_I3C_MASTER) += i3c-master-cdns.o
> obj-$(CONFIG_DW_I3C_MASTER) += dw-i3c-master.o
> obj-$(CONFIG_AST2600_I3C_MASTER) += ast2600-i3c-master.o
> -obj-$(CONFIG_SVC_I3C_MASTER) += svc-i3c-master.o
> +svc-i3c-objs += svc-i3c-main.o svc-i3c-master.o
> +obj-$(CONFIG_SVC_I3C_MASTER) += svc-i3c.o
> obj-$(CONFIG_MIPI_I3C_HCI) += mipi-i3c-hci/
> diff --git a/drivers/i3c/master/svc-i3c-main.c b/drivers/i3c/master/svc-i3c-main.c
> new file mode 100644
> index 0000000000000..053b2bd9d8317
> --- /dev/null
> +++ b/drivers/i3c/master/svc-i3c-main.c
...
> +module_platform_driver(svc_i3c_master);
> \ No newline at end of file
> diff --git a/drivers/i3c/master/svc-i3c.h b/drivers/i3c/master/svc-i3c.h
> new file mode 100644
> index 0000000000000..0bd1f0112a071
> --- /dev/null
> +++ b/drivers/i3c/master/svc-i3c.h
...
> +#endif
> \ No newline at end of file
Add the trailing newline characters.
--
i.
next prev parent reply other threads:[~2024-01-24 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 23:10 [PATCH v4 0/8] I3C target mode support Frank Li
2024-01-23 23:10 ` [PATCH v4 1/8] i3c: add " Frank Li
2024-01-23 23:10 ` [PATCH v4 2/8] dt-bindings: i3c: svc: add proptery mode Frank Li
2024-01-23 23:10 ` [PATCH v4 3/8] Documentation: i3c: Add I3C target mode controller and function Frank Li
2024-01-23 23:10 ` [PATCH v4 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h Frank Li
2024-01-24 14:59 ` Ilpo Järvinen [this message]
2024-01-23 23:10 ` [PATCH v4 5/8] i3c: target: add svc target controller support Frank Li
2024-01-27 0:58 ` kernel test robot
2024-01-23 23:10 ` [PATCH v4 6/8] i3c: target: func: add tty driver Frank Li
2024-01-24 15:15 ` Ilpo Järvinen
2024-01-23 23:10 ` [PATCH v4 7/8] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
2024-01-23 23:10 ` [PATCH v4 8/8] tty: i3c: add TTY over I3C master support Frank Li
2024-01-24 15:26 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb434214-0607-4054-dd04-a870db9e7f5d@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=joe@perches.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=robh@kernel.org \
--cc=zbigniew.lukwinski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).