From: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/1] devicetree: of_node_put() does not require holding devtree_lock
Date: Tue, 28 Feb 2017 08:36:32 +0200 [thread overview]
Message-ID: <bb5607dc-0055-a188-945b-ab385b573acb@linux.intel.com> (raw)
In-Reply-To: <CAL_JsqJyMqaaMDU81Jes-M8jvxewJnyFD33pqd9NUCZFa0HYcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Rob and Frank,
Rob Herring wrote:
> On Mon, Feb 27, 2017 at 8:54 AM, Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 02/22/17 01:29, Sakari Ailus wrote:
>>> While holding a reference to a device_node it is allowed to put that node
>>> without holding devtree_lock spinlock. Move of_node_put() after releasing
>>> the spinlock.
>>>
>>> Signed-off-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>>
>> I would rather leave this code the way it is.
>>
>> The change is a micro-optimization that is not going to have any real
>> impact on performance.
>
> I have the same feelings.
Fair enough. Feel free to ignore the patch then.
--
Kind regards,
Sakari Ailus
sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-02-28 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 9:29 [PATCH 1/1] devicetree: of_node_put() does not require holding devtree_lock Sakari Ailus
2017-02-23 16:02 ` Rob Herring
[not found] ` <1487755758-6066-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-26 21:08 ` Frank Rowand
[not found] ` <58B343C6.9060604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-27 10:08 ` Sakari Ailus
2017-02-27 14:54 ` Frank Rowand
[not found] ` <58B43DB6.4040009-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-28 0:42 ` Rob Herring
[not found] ` <CAL_JsqJyMqaaMDU81Jes-M8jvxewJnyFD33pqd9NUCZFa0HYcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-28 6:36 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5607dc-0055-a188-945b-ab385b573acb@linux.intel.com \
--to=sakari.ailus-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).