From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C76C54EE9 for ; Tue, 20 Sep 2022 07:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbiITH0A (ORCPT ); Tue, 20 Sep 2022 03:26:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiITHZ4 (ORCPT ); Tue, 20 Sep 2022 03:25:56 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E24043337 for ; Tue, 20 Sep 2022 00:25:55 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id s6so2306782lfo.7 for ; Tue, 20 Sep 2022 00:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=TMSVmhoNQ+EVx6VuvGV7GoC7OCus+JONwHUFK5MPIiA=; b=PThj4PJ6jYkYYO9TZGLcFdngNjOP/nQjGMvwuQMKbc+bmRqAjWWHuOCGxyKACZ57yy 91HPR0Tj+Mfd3Ep6uHTXJwrXdIHVrNfi/EkS3mYq4PeFDkzJOtPrL/lQPfacI96vsLwm AWRYw1Ep78RQaBX/wfXExS/ENl56JVLTNgt7kkSxNTn5Db1J/5pnyfwHVIrT8g+8b10M aNZUAgQ9albYsIjDRvsXnclJXSyYsV6hJr9cdESh/PuU7Bbo+ozsk7Uc9/668jziUlwW mHjAK4NB33WRUTUn4YIi82gK62JS3GEVMzU8yhfwK4MvNBKzbD7yQwaVwbBm7JGXKVrP qhZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=TMSVmhoNQ+EVx6VuvGV7GoC7OCus+JONwHUFK5MPIiA=; b=CXYlBYaskj2YCOjD2iWBoYeFPif52CR+0YWO0nqmZtYyiKGUbonpX5VIGq9Gk9b3An 1JL8Hl5dZmnRCTenqfJjV1yRQMFYZDq/I3+LUi/d+LsG+NumzVvKcxCA2mK2h5w3zPyf CAVh+ATmK85x7xeMylV+rd6zkA/VzVHC22Ckgal/4d+iwR+6N+FFL8vlQvGovBfY4zY7 DewObvNkwBMt1gPV7Ovb9XXQf4dRYUWsyipEjatJEqhDSXpokZwvHw3EPhkTDIaXS4E2 hbPyOBMR/bTzLwg+DdEz7XJiS3aJ1zehtptZlkRq6LLUU3TpYrzHrwIvLy4iJO8+ChVv 8CBA== X-Gm-Message-State: ACrzQf13M9IOdQ6dQrsq+3OqRnNZf1wdnM6Q7kCe90DNwbp6Mbs4p40T e0oELTWdjP+JjDhRWct7AGk9Fg== X-Google-Smtp-Source: AMsMyM5EHjB+cTmf8WPbUI9j9R50LpVkSqhwQo5FmkPm/75jGLSQhXhUgF3Nxxfh7Ed/mLF+o2/nNw== X-Received: by 2002:a05:6512:3608:b0:49a:75c0:5146 with SMTP id f8-20020a056512360800b0049a75c05146mr7958042lfs.398.1663658753671; Tue, 20 Sep 2022 00:25:53 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id x16-20020a056512079000b00497a2815d8dsm169165lfr.195.2022.09.20.00.25.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 00:25:52 -0700 (PDT) Message-ID: Date: Tue, 20 Sep 2022 09:25:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v6 1/4 RESEND] ARM: dts: qcom: Use new compatibles for crypto nodes Content-Language: en-US To: Bhupesh Sharma , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: agross@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, thara.gopinath@gmail.com, devicetree@vger.kernel.org, robh@kernel.org, andersson@kernel.org, bhupesh.linux@gmail.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, Jordan Crouse References: <20220919221509.1057574-1-bhupesh.sharma@linaro.org> <20220919221509.1057574-2-bhupesh.sharma@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220919221509.1057574-2-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/09/2022 00:15, Bhupesh Sharma wrote: > Since we are using soc specific qce crypto IP compatibles > in the bindings now, use the same in the device tree files > which include the crypto nodes. > > Cc: Bjorn Andersson > Cc: Rob Herring > Tested-by: Jordan Crouse > Signed-off-by: Bhupesh Sharma > --- > arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi > index b23591110bd2..9c40714562d5 100644 > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi > @@ -314,7 +314,7 @@ cryptobam: dma-controller@8e04000 { > }; > > crypto: crypto@8e3a000 { > - compatible = "qcom,crypto-v5.1"; > + compatible = "qcom,ipq4019-qce"; There are few issues here: 1. Compatible is not documented. 2. Compatible is not supported by old kernel - ABI break. 3. Everything won't be bisectable... The same in other places. Best regards, Krzysztof