From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenmeng Liu <quic_wenmliu@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
bryan.odonoghue@linaro.org, todor.too@gmail.com,
rfoss@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs8300: Add support for camss
Date: Tue, 20 May 2025 11:47:17 +0200 [thread overview]
Message-ID: <bb5c40be-85f0-497e-90de-7f7282f851e4@kernel.org> (raw)
In-Reply-To: <db562aa7-98dc-4f0e-8b9c-4348b4c16384@kernel.org>
On 20/05/2025 11:45, Krzysztof Kozlowski wrote:
> On 20/05/2025 11:40, Wenmeng Liu wrote:
>> This change enables camera driver for QCS8300 RIDE board.
>>
>> ---
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> ---
>> This patch series depends on patch series:
>> - https://lore.kernel.org/all/20250214095611.2498950-1-quic_vikramsa@quicinc.com/
>> - https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-1-3f76c5f8431f@quicinc.com/
>> - https://lore.kernel.org/all/20250217-qcs8300_tpg-v1-1-6e0f4dd3ad1f@quicinc.com/
>> - https://lore.kernel.org/all/20250214094747.2483058-1-quic_vikramsa@quicinc.com/
> No, please stop for now and see my other comments. You cannot send patch
> which depends on 4 different patchsets! This is making merging
> impossible and puts effort on maintainer to track these dependencies.
>
> Plus this was not even tested.
>
... and:
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
I suggest to read your internal guideline before posting. It is quite
comprehensive.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-20 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 9:40 [PATCH] arm64: dts: qcom: qcs8300: Add support for camss Wenmeng Liu
2025-05-20 9:45 ` Krzysztof Kozlowski
2025-05-20 9:47 ` Krzysztof Kozlowski [this message]
2025-05-20 10:12 ` Wenmeng Liu
2025-05-21 6:34 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5c40be-85f0-497e-90de-7f7282f851e4@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=quic_wenmliu@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox