From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 19/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock
Date: Fri, 6 Oct 2023 09:07:36 +0000 [thread overview]
Message-ID: <bb5cf458f77d2bed98958543a1955527f3b8cae3.camel@mediatek.com> (raw)
In-Reply-To: <20231006073831.10402-20-shawn.sung@mediatek.com>
Hi, Hsiao-chien:
On Fri, 2023-10-06 at 15:38 +0800, Hsiao Chien Sung wrote:
> Return the result of clk_prepare_enable() instead of
> always returns 0.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: f8946e2b6bb2 ("drm/mediatek: Add display MDP RDMA support for
> MT8195")
>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> index c3adaeefd551..c7233d0ac210 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> @@ -246,8 +246,7 @@ int mtk_mdp_rdma_clk_enable(struct device *dev)
> {
> struct mtk_mdp_rdma *rdma = dev_get_drvdata(dev);
>
> - clk_prepare_enable(rdma->clk);
> - return 0;
> + return clk_prepare_enable(rdma->clk);
> }
>
> void mtk_mdp_rdma_clk_disable(struct device *dev)
next prev parent reply other threads:[~2023-10-06 9:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 7:38 [PATCH v7 00/23] Add display driver for MT8188 VDOSYS1 Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 01/23] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188 Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 02/23] dt-bindings: display: mediatek: mdp-rdma: " Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 03/23] dt-bindings: display: mediatek: merge: " Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 04/23] dt-bindings: display: mediatek: padding: Add MT8188 Hsiao Chien Sung
2023-10-13 16:26 ` Daniel Stone
2023-10-16 4:23 ` Shawn Sung (宋孝謙)
2023-10-16 10:47 ` Daniel Stone
2023-10-17 4:19 ` Shawn Sung (宋孝謙)
2023-10-06 7:38 ` [PATCH v7 05/23] dt-bindings: arm: mediatek: Add compatible for MT8188 Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 06/23] dt-bindings: reset: mt8188: Add VDOSYS reset control bits Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 07/23] soc: mediatek: Support MT8188 VDOSYS1 in mtk-mmsys Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 08/23] soc: mediatek: Support MT8188 VDOSYS1 Padding " Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 09/23] soc: mediatek: Support reset bit mapping in mmsys driver Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 10/23] soc: mediatek: Add MT8188 VDOSYS reset bit map Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 11/23] drm/mediatek: Rename OVL_ADAPTOR_TYPE_RDMA Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 12/23] drm/mediatek: Refine device table of OVL adaptor Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 13/23] drm/mediatek: Sort OVL adaptor components Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 14/23] drm/mediatek: Add component ID to component match structure Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 15/23] drm/mediatek: Manage component's clock with function pointers Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 16/23] drm/mediatek: Start/Stop components " Hsiao Chien Sung
2023-10-06 8:58 ` CK Hu (胡俊光)
2023-10-06 7:38 ` [PATCH v7 17/23] drm/mediatek: Support MT8188 Padding in display driver Hsiao Chien Sung
2023-10-06 8:40 ` CK Hu (胡俊光)
2023-10-06 7:38 ` [PATCH v7 18/23] drm/mediatek: Add Padding to OVL adaptor Hsiao Chien Sung
2023-10-06 8:54 ` CK Hu (胡俊光)
2023-10-06 7:38 ` [PATCH v7 19/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock Hsiao Chien Sung
2023-10-06 9:07 ` CK Hu (胡俊光) [this message]
2023-10-06 7:38 ` [PATCH v7 20/23] drm/mediatek: Remove the redundant driver data for DPI Hsiao Chien Sung
2023-10-06 9:11 ` CK Hu (胡俊光)
2023-10-06 7:38 ` [PATCH v7 21/23] drm/mediatek: Fix underrun in VDO1 when switches off the layer Hsiao Chien Sung
2023-10-06 7:38 ` [PATCH v7 22/23] drm/mediatek: Power on devices in OVL adaptor when atomic enable Hsiao Chien Sung
2023-10-06 9:47 ` CK Hu (胡俊光)
2023-10-06 7:38 ` [PATCH v7 23/23] drm/mediatek: Support MT8188 VDOSYS1 in display driver Hsiao Chien Sung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5cf458f77d2bed98958543a1955527f3b8cae3.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Jason-JH.Lin@mediatek.com \
--cc=Nancy.Lin@mediatek.com \
--cc=Shawn.Sung@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).