From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5908C6FA82 for ; Thu, 29 Sep 2022 07:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235079AbiI2HDM (ORCPT ); Thu, 29 Sep 2022 03:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235020AbiI2HCj (ORCPT ); Thu, 29 Sep 2022 03:02:39 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB18912FF39 for ; Thu, 29 Sep 2022 00:02:37 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id a8so839852lff.13 for ; Thu, 29 Sep 2022 00:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=XOvSHmFJKeh5yRkDJlU1n6MZZmHObV6hSAVG20Km+VE=; b=If7jJbfMCHwm4H071OfjzvYgNquTh0WVRQ+kk4g0SIxFHdM2UApkmcsxC0++Y7MFMV uyRGlgUgMBiwlklRxUS2z+tLyTPhW/6masPNggNR2mCOZpuDV4i48P/So8pXoxQ+hLte jz8PQ3EXAPHiXMKLFCGycw0WtinBeV8dS6+17h0ELImTp5cDr/RHVNeK3SgJSbCXNtOd SrJiwpZ9sUdOWa0vHVp1TaTOfMZEnXmn/kQKECke9vf9j0E4Z+ghuDgCqvTew0oqyzIp V1yBdslbyFJFwT6ClHDwfJiZfBxyGdDFbC8so5cBVJrXTxlt+Du3NWVoRsQ1V+rdmLf2 CUWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=XOvSHmFJKeh5yRkDJlU1n6MZZmHObV6hSAVG20Km+VE=; b=mKABw1VG23Iax3lps7cjnzqlg2TSzTZ5DAO9Sxs4IriZuAfh5JaoPR/ywR1UfW9V3o f7XKqkudhTcJpv0DXnAv7W7Zdx30c6RqLKNeqM8UnwurZB2x080WB3W/CvhlQBdg04t+ wrsjUIZVEaD8LxE722daf/Uf1zYY2CV+LOrukY5Y3/lIYJHy7R0Z6Y5vu7lNmJieTzX8 R6TrjVuKKfKE8uDsF4XlqKFdzj7NHG2mOwA5RgaG0BxaHX6RpYtGtaWlC4ERB7koFEyF Mr5cocQkqxwEI+GwLtO0t4kKvS6/diWWHrWvZ64cHipPTdQnIqglxZqaDCHNSdVBjL1l EJGQ== X-Gm-Message-State: ACrzQf2RwA0jXgs2vJG/oXlyzj/3bNIsNFMaYrXcyJgQocTSPKZm2pYa YRYMSm4m2XSRr8yBxuoWN7zU9w== X-Google-Smtp-Source: AMsMyM7qkTQ53z7i1O+hV2ggXn4sNG0CVBxtHUC2ppRVlPra834JZuvv/OrKYbCu+8i5QOEIewzSKw== X-Received: by 2002:a05:6512:3f29:b0:4a1:c920:ebad with SMTP id y41-20020a0565123f2900b004a1c920ebadmr758260lfa.574.1664434956034; Thu, 29 Sep 2022 00:02:36 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q16-20020a194310000000b004946bb30469sm697275lfa.82.2022.09.29.00.02.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 00:02:35 -0700 (PDT) Message-ID: Date: Thu, 29 Sep 2022 09:02:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/3] dt-bindings: gpio: Conver Unisoc GPIO controller binding to yaml Content-Language: en-US To: Chunyan Zhang Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Baolin Wang , Orson Zhai , LKML References: <20220928092937.27120-1-zhang.lyra@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/09/2022 04:29, Chunyan Zhang wrote: > Hi Krzysztof, > > On Wed, 28 Sept 2022 at 19:31, Krzysztof Kozlowski > wrote: >> >> On 28/09/2022 11:29, Chunyan Zhang wrote: >>> From: Chunyan Zhang >>> >>> Convert the Unisoc gpio controller binding to DT schema format. >>> >> >> >> Thank you for your patch. There is something to discuss/improve. >> >>> diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml >>> new file mode 100644 >>> index 000000000000..c0cd1ed9809b >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml >>> @@ -0,0 +1,70 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright 2022 Unisoc Inc. >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/gpio/sprd,gpio.yaml# >> >> Use compatible as filename, so sprd,sc9860-gpio.yaml > > Humm... This is not only for SC9860, also for other IPs, UMS512 as an > example which added in this patchset. > Then it's ok. It seems you have also typo in commit subject (Conver). Best regards, Krzysztof