* [PATCH v2 0/2] Add kukui-jacuzzi-cerise and kukui-jacuzzi-stern DT and dt-binding
@ 2024-07-31 6:26 Hsin-Te Yuan
2024-07-31 6:26 ` [PATCH v2 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards Hsin-Te Yuan
2024-07-31 6:26 ` [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board Hsin-Te Yuan
0 siblings, 2 replies; 8+ messages in thread
From: Hsin-Te Yuan @ 2024-07-31 6:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Hsin-Te Yuan
Cerise is known as ASUS Chromebook CZ1.
Stern is known as ASUS Chromebook Flip CZ1.
They are almost identical. The only difference is that Cerise is a
clamshell device without touchscreen and Stern is a convertible device.
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
Changes in v2:
- Add more SKUs.
- Remove unnecessary property.
- Specify classis-type in the dts files.
- Add dt-bindings for these devices.
- Include these dts file in Makefile.
- Link to v1: https://lore.kernel.org/r/20240723-jacuzzi_dt-v1-1-3e994a2b5e24@chromium.org
---
Hsin-Te Yuan (2):
arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards
dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board
.../devicetree/bindings/arm/mediatek.yaml | 14 +++++++++++
arch/arm64/boot/dts/mediatek/Makefile | 4 +++
.../mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts | 26 +++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts | 26 +++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi | 21 ++++++++++++++++
.../mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts | 29 ++++++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-stern.dts | 29 ++++++++++++++++++++++
7 files changed, 149 insertions(+)
---
base-commit: 66ebbdfdeb093e097399b1883390079cd4c3022b
change-id: 20240723-jacuzzi_dt-06cd0bfd5422
Best regards,
--
Hsin-Te Yuan <yuanhsinte@chromium.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards
2024-07-31 6:26 [PATCH v2 0/2] Add kukui-jacuzzi-cerise and kukui-jacuzzi-stern DT and dt-binding Hsin-Te Yuan
@ 2024-07-31 6:26 ` Hsin-Te Yuan
2024-07-31 8:21 ` AngeloGioacchino Del Regno
2024-07-31 6:26 ` [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board Hsin-Te Yuan
1 sibling, 1 reply; 8+ messages in thread
From: Hsin-Te Yuan @ 2024-07-31 6:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Hsin-Te Yuan
Cerise is known as ASUS Chromebook CZ1.
Stern is known as ASUS Chromebook Flip CZ1.
They are almost identical. The only difference is that Cerise is a
clamshell device without touchscreen and Stern is a convertible device.
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
arch/arm64/boot/dts/mediatek/Makefile | 4 +++
.../mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts | 26 +++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts | 26 +++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi | 21 ++++++++++++++++
.../mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts | 29 ++++++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi-stern.dts | 29 ++++++++++++++++++++++
6 files changed, 135 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 8fd7b2bb7a15..17fbe495e4ee 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -28,6 +28,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-burnet.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-cerise.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-cerise-rev3.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-cozmo.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-damu.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel-sku1.dtb
@@ -42,6 +44,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-makomo-sku0.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-makomo-sku1.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-pico.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-pico6.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-stern.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-stern-rev3.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-willow-sku0.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-willow-sku1.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kakadu.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts
new file mode 100644
index 000000000000..c511dd1cc171
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-cerise.dtsi"
+#include "mt8183-kukui-audio-ts3a227e-rt1015p.dtsi"
+
+/ {
+ model = "Google cerise board";
+ chassis-type = "laptop";
+ compatible = "google,cerise-rev3-sku0", "google,cerise", "mediatek,mt8183";
+};
+
+&mt6358codec {
+ mediatek,dmic-mode = <1>; /* one-wire */
+};
+
+&touchscreen {
+ status = "disabled";
+};
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_CERISE";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts
new file mode 100644
index 000000000000..12b97dcaa74a
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-cerise.dtsi"
+#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
+
+/ {
+ model = "Google cerise board";
+ chassis-type = "laptop";
+ compatible = "google,cerise-sku0", "google,cerise", "mediatek,mt8183";
+};
+
+&mt6358codec {
+ mediatek,dmic-mode = <1>; /* one-wire */
+};
+
+&touchscreen {
+ status = "disabled";
+};
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_CERISE";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
new file mode 100644
index 000000000000..087a0ef33e13
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi.dtsi"
+
+&cpu_thermal {
+ sustainable-power = <4500>; /* milliwatts */
+};
+
+&mmc1_pins_uhs {
+ pins-clk {
+ drive-strength = <MTK_DRIVE_6mA>;
+ };
+};
+
+&i2c2 {
+ i2c-scl-internal-delay-ns = <13200>;
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts
new file mode 100644
index 000000000000..19e09da1d166
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-cerise.dtsi"
+#include "mt8183-kukui-audio-ts3a227e-rt1015p.dtsi"
+
+/ {
+ model = "Google stern board";
+ chassis-type = "convertible";
+ compatible = "google,cerise-rev3-sku1", "google,cerise", "mediatek,mt8183";
+};
+
+&mt6358codec {
+ mediatek,dmic-mode = <0>; /* two-wire */
+};
+
+&touchscreen {
+ compatible = "hid-over-i2c";
+
+ post-power-on-delay-ms = <10>;
+ hid-descr-addr = <0x0001>;
+};
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_STERN";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern.dts
new file mode 100644
index 000000000000..72de05ffea86
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern.dts
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-cerise.dtsi"
+#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
+
+/ {
+ model = "Google stern board";
+ chassis-type = "convertible";
+ compatible = "google,cerise-sku1", "google,cerise", "mediatek,mt8183";
+};
+
+&mt6358codec {
+ mediatek,dmic-mode = <0>; /* two-wire */
+};
+
+&touchscreen {
+ compatible = "hid-over-i2c";
+
+ post-power-on-delay-ms = <10>;
+ hid-descr-addr = <0x0001>;
+};
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_STERN";
+};
--
2.46.0.rc1.232.g9752f9e123-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board
2024-07-31 6:26 [PATCH v2 0/2] Add kukui-jacuzzi-cerise and kukui-jacuzzi-stern DT and dt-binding Hsin-Te Yuan
2024-07-31 6:26 ` [PATCH v2 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards Hsin-Te Yuan
@ 2024-07-31 6:26 ` Hsin-Te Yuan
2024-07-31 8:16 ` Krzysztof Kozlowski
2024-07-31 8:19 ` AngeloGioacchino Del Regno
1 sibling, 2 replies; 8+ messages in thread
From: Hsin-Te Yuan @ 2024-07-31 6:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Hsin-Te Yuan
Cerise is known as ASUS Chromebook CZ1.
Stern is known as ASUS Chromebook Flip CZ1.
They are almost identical. The only difference is that Cerise is a
clamshell device without touchscreen and Stern is a convertible device.
Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 1d4bb50fcd8d..087773a43673 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -146,6 +146,20 @@ properties:
items:
- const: google,burnet
- const: mediatek,mt8183
+ - description: Google Cerise (ASUS Chromebook CZ1)
+ items:
+ - enum:
+ - google,cerise-sku0
+ - google,cerise-rev3-sku0
+ - const: google,cerise
+ - const: mediatek,mt8183
+ - description: Google Stern (ASUS Chromebook Flip CZ1)
+ items:
+ - enum:
+ - google,cerise-sku1
+ - google,cerise-rev3-sku1
+ - const: google,cerise
+ - const: mediatek,mt8183
- description: Google Cozmo (Acer Chromebook 314)
items:
- const: google,cozmo
--
2.46.0.rc1.232.g9752f9e123-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board
2024-07-31 6:26 ` [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board Hsin-Te Yuan
@ 2024-07-31 8:16 ` Krzysztof Kozlowski
2024-07-31 8:47 ` AngeloGioacchino Del Regno
2024-07-31 8:19 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-31 8:16 UTC (permalink / raw)
To: Hsin-Te Yuan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
On 31/07/2024 08:26, Hsin-Te Yuan wrote:
> Cerise is known as ASUS Chromebook CZ1.
> Stern is known as ASUS Chromebook Flip CZ1.
>
> They are almost identical. The only difference is that Cerise is a
> clamshell device without touchscreen and Stern is a convertible device.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..087773a43673 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -146,6 +146,20 @@ properties:
> items:
> - const: google,burnet
> - const: mediatek,mt8183
> + - description: Google Cerise (ASUS Chromebook CZ1)
> + items:
> + - enum:
> + - google,cerise-sku0
> + - google,cerise-rev3-sku0
> + - const: google,cerise
> + - const: mediatek,mt8183
> + - description: Google Stern (ASUS Chromebook Flip CZ1)
> + items:
> + - enum:
> + - google,cerise-sku1
> + - google,cerise-rev3-sku1
> + - const: google,cerise
Why not google,stern? If this is not compatible with cerise and has
different name, I think logical would be to have different compatible -
either here or the first one.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board
2024-07-31 6:26 ` [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board Hsin-Te Yuan
2024-07-31 8:16 ` Krzysztof Kozlowski
@ 2024-07-31 8:19 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-07-31 8:19 UTC (permalink / raw)
To: Hsin-Te Yuan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
Il 31/07/24 08:26, Hsin-Te Yuan ha scritto:
> Cerise is known as ASUS Chromebook CZ1.
> Stern is known as ASUS Chromebook Flip CZ1.
>
> They are almost identical. The only difference is that Cerise is a
> clamshell device without touchscreen and Stern is a convertible device.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..087773a43673 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -146,6 +146,20 @@ properties:
> items:
> - const: google,burnet
> - const: mediatek,mt8183
> + - description: Google Cerise (ASUS Chromebook CZ1)
> + items:
> + - enum:
> + - google,cerise-sku0
> + - google,cerise-rev3-sku0
> + - const: google,cerise
> + - const: mediatek,mt8183
> + - description: Google Stern (ASUS Chromebook Flip CZ1)
> + items:
> + - enum:
> + - google,cerise-sku1
> + - google,cerise-rev3-sku1
> + - const: google,cerise
> + - const: mediatek,mt8183
> - description: Google Cozmo (Acer Chromebook 314)
> items:
> - const: google,cozmo
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards
2024-07-31 6:26 ` [PATCH v2 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards Hsin-Te Yuan
@ 2024-07-31 8:21 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-07-31 8:21 UTC (permalink / raw)
To: Hsin-Te Yuan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
Il 31/07/24 08:26, Hsin-Te Yuan ha scritto:
> Cerise is known as ASUS Chromebook CZ1.
> Stern is known as ASUS Chromebook Flip CZ1.
>
> They are almost identical. The only difference is that Cerise is a
> clamshell device without touchscreen and Stern is a convertible device.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 4 +++
> .../mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts | 26 +++++++++++++++++++
> .../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts | 26 +++++++++++++++++++
> .../dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi | 21 ++++++++++++++++
> .../mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts | 29 ++++++++++++++++++++++
> .../dts/mediatek/mt8183-kukui-jacuzzi-stern.dts | 29 ++++++++++++++++++++++
> 6 files changed, 135 insertions(+)
>
..snip..
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
> new file mode 100644
> index 000000000000..087a0ef33e13
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2021 Google LLC
> + */
> +
> +/dts-v1/;
> +#include "mt8183-kukui-jacuzzi.dtsi"
> +
> +&cpu_thermal {
> + sustainable-power = <4500>; /* milliwatts */
> +};
> +
> +&mmc1_pins_uhs {
> + pins-clk {
> + drive-strength = <MTK_DRIVE_6mA>;
Sorry for not noticing that in v1, I have one more nit: please do not use
the MTK_DRIVE_(x)mA definitions.
This is just `drive-strength = <6>`.
Thanks,
Angelo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board
2024-07-31 8:16 ` Krzysztof Kozlowski
@ 2024-07-31 8:47 ` AngeloGioacchino Del Regno
2024-07-31 9:44 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-07-31 8:47 UTC (permalink / raw)
To: Krzysztof Kozlowski, Hsin-Te Yuan, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
Il 31/07/24 10:16, Krzysztof Kozlowski ha scritto:
> On 31/07/2024 08:26, Hsin-Te Yuan wrote:
>> Cerise is known as ASUS Chromebook CZ1.
>> Stern is known as ASUS Chromebook Flip CZ1.
>>
>> They are almost identical. The only difference is that Cerise is a
>> clamshell device without touchscreen and Stern is a convertible device.
>>
>> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
>> ---
>> Documentation/devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index 1d4bb50fcd8d..087773a43673 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -146,6 +146,20 @@ properties:
>> items:
>> - const: google,burnet
>> - const: mediatek,mt8183
>> + - description: Google Cerise (ASUS Chromebook CZ1)
>> + items:
>> + - enum:
>> + - google,cerise-sku0
>> + - google,cerise-rev3-sku0
>> + - const: google,cerise
>> + - const: mediatek,mt8183
>> + - description: Google Stern (ASUS Chromebook Flip CZ1)
>> + items:
>> + - enum:
>> + - google,cerise-sku1
>> + - google,cerise-rev3-sku1
>> + - const: google,cerise
>
> Why not google,stern? If this is not compatible with cerise and has
> different name, I think logical would be to have different compatible -
> either here or the first one.
>
They're both compatible, but the commercial names are different because one
is convertible, one is not... and the bootloader still checks for cerise
even on stern - that's how I read it, and it's not the first time...
...but it doesn't hurt to have a "google,stern" compatible added to the mix,
it's just one more const to add... and I don't have any strong opinion about
that, so, Hsin-Te, it's your call. :-)
Cheers,
Angelo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board
2024-07-31 8:47 ` AngeloGioacchino Del Regno
@ 2024-07-31 9:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-31 9:44 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Hsin-Te Yuan, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
On 31/07/2024 10:47, AngeloGioacchino Del Regno wrote:
> Il 31/07/24 10:16, Krzysztof Kozlowski ha scritto:
>> On 31/07/2024 08:26, Hsin-Te Yuan wrote:
>>> Cerise is known as ASUS Chromebook CZ1.
>>> Stern is known as ASUS Chromebook Flip CZ1.
>>>
>>> They are almost identical. The only difference is that Cerise is a
>>> clamshell device without touchscreen and Stern is a convertible device.
>>>
>>> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
>>> ---
>>> Documentation/devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> index 1d4bb50fcd8d..087773a43673 100644
>>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> @@ -146,6 +146,20 @@ properties:
>>> items:
>>> - const: google,burnet
>>> - const: mediatek,mt8183
>>> + - description: Google Cerise (ASUS Chromebook CZ1)
>>> + items:
>>> + - enum:
>>> + - google,cerise-sku0
>>> + - google,cerise-rev3-sku0
>>> + - const: google,cerise
>>> + - const: mediatek,mt8183
>>> + - description: Google Stern (ASUS Chromebook Flip CZ1)
>>> + items:
>>> + - enum:
>>> + - google,cerise-sku1
>>> + - google,cerise-rev3-sku1
>>> + - const: google,cerise
>>
>> Why not google,stern? If this is not compatible with cerise and has
>> different name, I think logical would be to have different compatible -
>> either here or the first one.
>>
>
> They're both compatible, but the commercial names are different because one
> is convertible, one is not... and the bootloader still checks for cerise
> even on stern - that's how I read it, and it's not the first time...
>
> ...but it doesn't hurt to have a "google,stern" compatible added to the mix,
> it's just one more const to add... and I don't have any strong opinion about
> that, so, Hsin-Te, it's your call. :-)
OK. Such explanations - including that bootloader expect exactly these
strings - should be in commit msg.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-07-31 9:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 6:26 [PATCH v2 0/2] Add kukui-jacuzzi-cerise and kukui-jacuzzi-stern DT and dt-binding Hsin-Te Yuan
2024-07-31 6:26 ` [PATCH v2 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise series boards Hsin-Te Yuan
2024-07-31 8:21 ` AngeloGioacchino Del Regno
2024-07-31 6:26 ` [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add kukui-jacuzzi-cerise board Hsin-Te Yuan
2024-07-31 8:16 ` Krzysztof Kozlowski
2024-07-31 8:47 ` AngeloGioacchino Del Regno
2024-07-31 9:44 ` Krzysztof Kozlowski
2024-07-31 8:19 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).