From: Neil Armstrong <neil.armstrong@linaro.org>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>,
dri-devel@lists.freedesktop.org
Cc: Conor Dooley <conor+dt@kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
David Airlie <airlied@gmail.com>,
Jessica Zhang <jesszhan0024@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>, Rob Herring <robh@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 2/4] drm/panel: ilitek-ili9882t: Make enable GPIO optional
Date: Thu, 24 Sep 2026 15:15:46 +0200 [thread overview]
Message-ID: <bb71b2d6-2462-4351-b6e8-ae8785a24c11@linaro.org> (raw)
In-Reply-To: <20260910181918.31551-2-marek.vasut+renesas@mailbox.org>
On 9/10/26 20:18, Marek Vasut wrote:
> The enable GPIO may not be accessible on the panel, make it optional.
> This is the case on 10" Raspberry Pi Touch Display 2.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Jessica Zhang <jesszhan0024@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: No change
> V3: No change
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
> index d4b383138488a..69f6427bb4ffb 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
> @@ -787,7 +787,7 @@ static int ili9882t_add(struct ili9882t *ili)
> if (IS_ERR(ili->pp1800))
> return PTR_ERR(ili->pp1800);
>
> - ili->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
> + ili->enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
> if (IS_ERR(ili->enable_gpio)) {
> dev_err(dev, "cannot get enable-gpios %ld\n",
> PTR_ERR(ili->enable_gpio));
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
next prev parent reply other threads:[~2026-09-24 13:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 18:18 [PATCH v3 1/4] dt-bindings: display: panel: Document 10" Raspberry Pi Touch Display 2 Marek Vasut
2026-09-10 18:18 ` [PATCH v3 2/4] drm/panel: ilitek-ili9882t: Make enable GPIO optional Marek Vasut
2026-09-24 13:15 ` Neil Armstrong [this message]
2026-09-10 18:18 ` [PATCH v3 3/4] drm/panel: ilitek-ili9882t: Set prepare_prev_first Marek Vasut
2026-09-10 18:18 ` [PATCH v3 4/4] drm/panel: ilitek-ili9882t: Add support for Ilitek IL79600A-based panels Marek Vasut
2026-09-21 20:31 ` Marek Vasut
2026-09-22 6:38 ` Geert Uytterhoeven
2026-09-24 13:16 ` Neil Armstrong
2026-09-24 13:59 ` [PATCH v3 1/4] dt-bindings: display: panel: Document 10" Raspberry Pi Touch Display 2 Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb71b2d6-2462-4351-b6e8-ae8785a24c11@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox