From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v2 3/3] ARM: dts: bcm5301x: Add I2C support to the DT Date: Sun, 5 Mar 2017 17:13:34 -0800 Message-ID: References: <1488500494-20622-1-git-send-email-jon.mason@broadcom.com> <1488500494-20622-4-git-send-email-jon.mason@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1488500494-20622-4-git-send-email-jon.mason@broadcom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jon Mason , Hauke Mehrtens , zajec5@gmail.com Cc: Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , Jon Mason , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 03/02/2017 04:21 PM, Jon Mason wrote: > From: Jon Mason > > Add I2C support to the bcm5301x Device Tree. Since no driver changes > are needed to enable this hardware, only the device tree changes are > required to make this functional. > > Signed-off-by: Jon Mason > --- > arch/arm/boot/dts/bcm5301x.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index 4e3fbce..2a343f2 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -338,6 +338,15 @@ > }; > }; > > + i2c0: i2c@18009000 { > + compatible = "brcm,iproc-i2c"; > + reg = <0x18009000 0x50>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <100000>; Should not this have a: status = "disabled" property by default such that boards can override this by phandle when there are actual I2C devices available? > + }; > + > lcpll0: lcpll0@1800c100 { > #clock-cells = <1>; > compatible = "brcm,nsp-lcpll0"; > -- Florian