From: Krzysztof Kozlowski <krzk@kernel.org>
To: Swamil Jain <s-jain1@ti.com>
Cc: jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devarsht@ti.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
praneeth@ti.com, vigneshr@ti.com
Subject: Re: [PATCH v2] dt-bindings: display: ti,am65x-dss: Fix AM62L DSS reg and clock constraints
Date: Mon, 16 Mar 2026 17:44:02 +0100 [thread overview]
Message-ID: <bb9712c6-a8be-4068-b549-96a12bc55e3c@kernel.org> (raw)
In-Reply-To: <7b3660cf-cc5a-47d6-9cc8-362544cfdb37@ti.com>
On 16/03/2026 13:36, Swamil Jain wrote:
>> description:
>> Addresses to each DSS memory region described in the SoC's TRM.
>> oneOf:
>> - items:
>> - description: common DSS register area
>> - description: VIDL1 light video plane
>> - description: VID video plane
>> - description: OVR1 overlay manager for vp1
>> - description: OVR2 overlay manager for vp2
>> - description: VP1 video port 1
>> - description: VP2 video port 2
>> - description: common1 DSS register area
>> - items:
>> - description: common DSS register area
>> - description: VIDL1 light video plane
>> - description: OVR1 overlay manager for vp1
>> - description: VP1 video port 1
>> - description: common1 DSS register area
>>
>> .....(Similarly for reg-names, clocks, clock-names,...)
>>
>> allOf:
>> - if:
>> properties:
>> compatible:
>> contains:
>> const: ti,am62l-dss
>> then:
>> properties:
>> clock-names:
>> maxItems: 2
>> clocks:
>> maxItems: 2
>> reg:
>> maxItems: 5
>> else:
>> properties:
>> clock-names:
>> minItems: 3
>> clocks:
>> minItems: 3
>> reg:
>> minItems: 8
>>
>> ```
>>
>> Could you please confirm on this?
If there is no common part of each list, then this looks correct. Other
way would be the example I wrote ~2 hours ago on DT IRC (different
patchset) - so the qcom,ufs way. It depends how readable is the final
schema.
>
> Hi Krzysztof,
>
> Gentle ping, could you please confirm on the above design?
If you do not hear from me or other reviewer for some time after asking
"shall I do like that", just send next version implementing what you
think should be done and mentioning in changelog, that this is how you
address reviewers feedback.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-16 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 15:06 [PATCH v2] dt-bindings: display: ti,am65x-dss: Fix AM62L DSS reg and clock constraints Swamil Jain
2026-02-05 13:25 ` Krzysztof Kozlowski
2026-02-06 14:18 ` Swamil Jain
2026-03-16 12:36 ` Swamil Jain
2026-03-16 16:44 ` Krzysztof Kozlowski [this message]
2026-04-10 11:06 ` Swamil Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb9712c6-a8be-4068-b549-96a12bc55e3c@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox