From: Dhananjay Phadke <dphadke@linux.microsoft.com>
To: Neal Liu <neal_liu@aspeedtech.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Johnny Huang <johnny_huang@aspeedtech.com>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
BMC-SW@aspeedtech.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/5] ARM: dts: aspeed: Add HACE device controller node
Date: Mon, 6 Jun 2022 17:50:45 -0700 [thread overview]
Message-ID: <bba832ec-ea64-71db-385a-ab9816e7239c@linux.microsoft.com> (raw)
In-Reply-To: <20220606064935.1458903-4-neal_liu@aspeedtech.com>
On 6/5/2022 11:49 PM, Neal Liu wrote:
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 3d5ce9da42c3..371d2a6b56ef 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -304,6 +304,14 @@ apb {
> #size-cells = <1>;
> ranges;
>
> + hace: crypto@1e6d0000 {
> + compatible = "aspeed,ast2600-hace";
> + reg = <0x1e6d0000 0x200>;
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&syscon ASPEED_CLK_GATE_YCLK>;
> + resets = <&syscon ASPEED_RESET_HACE>;
Shouldn't the left side be also 'crypto', see existing crypto nodes in
arch/arm64/dts for example.
crypto: crypto@1e6d0000 {
...
Regards,
Dhananjay
next prev parent reply other threads:[~2022-06-07 0:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 6:49 [PATCH v2 0/5] Add Aspeed crypto driver for hardware acceleration Neal Liu
2022-06-06 6:49 ` [PATCH v2 1/5] crypto: aspeed: Add HACE hash driver Neal Liu
2022-06-06 14:58 ` Randy Dunlap
2022-06-07 2:54 ` Neal Liu
2022-06-06 18:13 ` Christophe JAILLET
2022-06-07 3:05 ` Neal Liu
2022-06-07 3:11 ` Neal Liu
2022-06-06 19:43 ` Corentin Labbe
2022-06-07 3:43 ` Neal Liu
2022-06-06 6:49 ` [PATCH v2 2/5] dt-bindings: clock: Add AST2600 HACE reset definition Neal Liu
2022-06-06 6:49 ` [PATCH v2 3/5] ARM: dts: aspeed: Add HACE device controller node Neal Liu
2022-06-07 0:50 ` Dhananjay Phadke [this message]
2022-06-07 3:59 ` Neal Liu
2022-06-06 6:49 ` [PATCH v2 4/5] dt-bindings: crypto: add documentation for aspeed hace Neal Liu
2022-06-06 7:22 ` Krzysztof Kozlowski
2022-06-06 6:49 ` [PATCH v2 5/5] crypto: aspeed: add HACE crypto driver Neal Liu
2022-06-06 14:56 ` Randy Dunlap
2022-06-07 2:52 ` Neal Liu
2022-06-06 20:18 ` Christophe JAILLET
2022-06-07 3:53 ` Neal Liu
2022-06-07 5:00 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bba832ec-ea64-71db-385a-ab9816e7239c@linux.microsoft.com \
--to=dphadke@linux.microsoft.com \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=joel@jms.id.au \
--cc=johnny_huang@aspeedtech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).