* [PATCH] ASoC: soc-pcm.c: Add NULL check in BE reparenting
@ 2022-11-21 13:04 Srinivasa Rao Mandadapu
2022-11-21 14:30 ` Cezary Rojewski
0 siblings, 1 reply; 2+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-11-21 13:04 UTC (permalink / raw)
To: agross, andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, linux-kernel, swboyd, judyhsiao,
devicetree, lgirdwood
Cc: Srinivasa Rao Mandadapu
Add NULL check in dpcm_be_reparent API, to handle
kernel NULL pointer dereference error.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
---
sound/soc/soc-pcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 493f003..a7810c7 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -1247,6 +1247,8 @@ static void dpcm_be_reparent(struct snd_soc_pcm_runtime *fe,
return;
be_substream = snd_soc_dpcm_get_substream(be, stream);
+ if (!be_substream)
+ return;
for_each_dpcm_fe(be, stream, dpcm) {
if (dpcm->fe == fe)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: soc-pcm.c: Add NULL check in BE reparenting
2022-11-21 13:04 [PATCH] ASoC: soc-pcm.c: Add NULL check in BE reparenting Srinivasa Rao Mandadapu
@ 2022-11-21 14:30 ` Cezary Rojewski
0 siblings, 0 replies; 2+ messages in thread
From: Cezary Rojewski @ 2022-11-21 14:30 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, linux-kernel, swboyd, judyhsiao,
devicetree
On 2022-11-21 2:04 PM, Srinivasa Rao Mandadapu wrote:
> Add NULL check in dpcm_be_reparent API, to handle
> kernel NULL pointer dereference error.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> sound/soc/soc-pcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index 493f003..a7810c7 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -1247,6 +1247,8 @@ static void dpcm_be_reparent(struct snd_soc_pcm_runtime *fe,
> return;
>
> be_substream = snd_soc_dpcm_get_substream(be, stream);
> + if (!be_substream)
> + return;
>
> for_each_dpcm_fe(be, stream, dpcm) {
> if (dpcm->fe == fe)
Hello,
Could you provide reproduction steps that lead to null-ptr-deref popping
up? Also, please drop '.c' in commit title.
Regards,
Czarek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-21 13:04 [PATCH] ASoC: soc-pcm.c: Add NULL check in BE reparenting Srinivasa Rao Mandadapu
2022-11-21 14:30 ` Cezary Rojewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).