From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
broonie@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org,
dianders@chromium.org, swboyd@chromium.org,
judyhsiao@chromium.org, alsa-devel@alsa-project.org,
quic_rjendra@quicinc.com, konrad.dybcio@somainline.org,
mka@chromium.org, quic_mohs@quicinc.com
Subject: Re: [PATCH v5 2/8] arm64: dts: qcom: sc7280: Add sound node for crd-rev3 board
Date: Thu, 9 Feb 2023 18:00:19 +0100 [thread overview]
Message-ID: <bc02ca87-acc2-d28f-ba75-b5ba4128e70a@linaro.org> (raw)
In-Reply-To: <1675700201-12890-3-git-send-email-quic_srivasam@quicinc.com>
On 06/02/2023 17:16, Srinivasa Rao Mandadapu wrote:
> Add sound node for sc7280 ADSP based audioreach platforms
> such as crd-rev3 board.
>
> Include audioreach dtsi into crd-rev3 platform specific dts file.
> Also remove phandle to sound node, as audio routing is same as
> audioreach specific dtsi file.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Tested-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Thank you for your patch. There is something to discuss/improve.
> +/{
> + /* BOARD-SPECIFIC TOP LEVEL NODES */
> + sound: sound {
> + compatible = "google,sc7280-herobrine";
> + model = "AR-wcd938x-max98360a-1mic";
> + audio-routing =
> + "IN1_HPHL", "HPHL_OUT",
> + "IN2_HPHR", "HPHR_OUT",
> + "AMIC1", "MIC BIAS1",
> + "AMIC2", "MIC BIAS2",
> + "VA DMIC0", "MIC BIAS1",
> + "VA DMIC1", "MIC BIAS1",
> + "VA DMIC2", "MIC BIAS3",
> + "VA DMIC3", "MIC BIAS3",
> + "TX SWR_ADC0", "ADC1_OUTPUT",
> + "TX SWR_ADC1", "ADC2_OUTPUT",
> + "TX SWR_ADC2", "ADC3_OUTPUT",
> + "TX SWR_DMIC0", "DMIC1_OUTPUT",
> + "TX SWR_DMIC1", "DMIC2_OUTPUT",
> + "TX SWR_DMIC2", "DMIC3_OUTPUT",
> + "TX SWR_DMIC3", "DMIC4_OUTPUT",
> + "TX SWR_DMIC4", "DMIC5_OUTPUT",
> + "TX SWR_DMIC5", "DMIC6_OUTPUT",
> + "TX SWR_DMIC6", "DMIC7_OUTPUT",
> + "TX SWR_DMIC7", "DMIC8_OUTPUT";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #sound-dai-cells = <0>;
This line looks incorrect - drop dai cells.
> +
> + dai-link@0 {
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-09 17:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 16:16 [PATCH v5 0/8] Add SC7280 audioreach device tree nodes Srinivasa Rao Mandadapu
2023-02-06 16:16 ` [PATCH v5 1/8] arm64: dts: qcom: sc7280: Extract audio nodes from common idp dtsi file Srinivasa Rao Mandadapu
2023-02-09 16:37 ` Krzysztof Kozlowski
2023-02-09 16:45 ` Krzysztof Kozlowski
2023-02-06 16:16 ` [PATCH v5 2/8] arm64: dts: qcom: sc7280: Add sound node for crd-rev3 board Srinivasa Rao Mandadapu
2023-02-09 17:00 ` Krzysztof Kozlowski [this message]
2023-02-06 16:16 ` [PATCH v5 3/8] arm64: dts: qcom: sc7280: Add LPASS PIL node Srinivasa Rao Mandadapu
2023-02-09 22:55 ` Stephen Boyd
2023-02-10 11:26 ` Krzysztof Kozlowski
2023-02-10 11:12 ` Krzysztof Kozlowski
2023-02-06 16:16 ` [PATCH v5 4/8] arm64: dts: qcom: sc7280: Update VA/RX/TX macro clock nodes Srinivasa Rao Mandadapu
2023-02-10 11:13 ` Krzysztof Kozlowski
2023-02-06 16:16 ` [PATCH v5 5/8] arm64: dts: qcom: sc7280: Update lpass_tlmm node Srinivasa Rao Mandadapu
2023-02-09 23:02 ` Stephen Boyd
2023-02-10 11:17 ` Krzysztof Kozlowski
2023-02-06 16:16 ` [PATCH v5 6/8] arm64: dts: qcom: sc7280: Add qcom,adsp-pil-mode property in clock nodes Srinivasa Rao Mandadapu
2023-02-06 16:16 ` [PATCH v5 7/8] arm64: dts: qcom: sc7280: Modify lpasscc node name Srinivasa Rao Mandadapu
2023-02-09 23:00 ` Stephen Boyd
2023-02-10 11:18 ` Krzysztof Kozlowski
2023-02-06 16:16 ` [PATCH v5 8/8] dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add missing properties Srinivasa Rao Mandadapu
2023-02-10 11:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc02ca87-acc2-d28f-ba75-b5ba4128e70a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_mohs@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).