From: "William-tw Lin (林鼎崴)" <William-tw.Lin@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] soc: mediatek: mtk-socinfo: Add driver for getting chip information
Date: Fri, 22 Dec 2023 08:03:33 +0000 [thread overview]
Message-ID: <bc22f2164445dd02d04f7636171f1f521f998eab.camel@mediatek.com> (raw)
In-Reply-To: <97d54894-7c71-49d8-a456-869c398636ec@linaro.org>
Hi Krzysztof,
Thank you for the comments. The fix regarding module_platform_driver
will be provided in the next version of patches. Thanks a lot!
Best regards,
William
On Wed, 2023-12-20 at 12:34 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 20/12/2023 11:39, William-tw Lin wrote:
> > Add driver for socinfo retrieval. This patch includes the
> following:
> > 1. mtk-socinfo driver for chip info retrieval
> > 2. Related changes to Makefile and Kconfig
> >
> > Signed-off-by: William-tw Lin <william-tw.lin@mediatek.com>
>
> ...
>
> > +static struct platform_driver mtk_socinfo = {
> > +.probe = mtk_socinfo_probe,
> > +.remove_new = mtk_socinfo_remove,
> > +.driver = {
> > +.name = "mtk-socinfo",
> > +},
> > +};
> > +builtin_platform_driver(mtk_socinfo);
>
> module platform driver, because this is tristate and because this
> should
> be a module.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-12-22 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 10:38 [PATCH v3 0/3] mtk-socinfo driver implementation William-tw Lin
2023-12-20 10:38 ` [PATCH v3 1/3] arm64: dts: Add node for chip info driver William-tw Lin
2023-12-20 11:02 ` AngeloGioacchino Del Regno
2023-12-20 10:39 ` [PATCH v3 2/3] soc: mediatek: mtk-socinfo: Add driver for getting chip information William-tw Lin
2023-12-20 10:53 ` AngeloGioacchino Del Regno
2023-12-22 8:03 ` William-tw Lin (林鼎崴)
2023-12-20 11:34 ` Krzysztof Kozlowski
2023-12-20 13:13 ` AngeloGioacchino Del Regno
2023-12-22 8:03 ` William-tw Lin (林鼎崴) [this message]
2023-12-20 10:39 ` [PATCH v3 3/3] nvmem: mtk-efuse: Modify " William-tw Lin
2023-12-20 11:02 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc22f2164445dd02d04f7636171f1f521f998eab.camel@mediatek.com \
--to=william-tw.lin@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).