Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

[Rex-BC Chen (陳柏辰)]

On Sat, 2022-10-29 at 18:50 +0800, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
> 
> add gce header file to define the gce thread priority, gce subsys id,
>  event and constant for mt8188.
> v2 - use vendor in filename, use Dual license.
> 
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> Reviewed-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Thanks for the reviews, I have fixed them.
> 
Hello Elvis,

I think Krzysztof and I don't give you our "Reviewed-by" tag.
This tag shows that we accept you patch but we don't accept your patch.

You can add this tag if you see someone leave something like this:
"Reviewed-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>" and then you can
add it to your patch.

Please remove them.

Please read this:



https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

BRs,
Bo-Chen

Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

[Elvis Wang (王军)]

On Mon, 2022-10-31 at 03:04 +0000, Rex-BC Chen (陳柏辰) wrote:
> On Sat, 2022-10-29 at 18:50 +0800, Elvis.Wang wrote:
> > From: Elvis Wang <Elvis.Wang@mediatek.com>
> > 
> > add gce header file to define the gce thread priority, gce subsys
> > id,
> >  event and constant for mt8188.
> > v2 - use vendor in filename, use Dual license.
> > 
> > Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> > Reviewed-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > Thanks for the reviews, I have fixed them.
> > 
> 
> Hello Elvis,
> 
> I think Krzysztof and I don't give you our "Reviewed-by" tag.
> This tag shows that we accept you patch but we don't accept your
> patch.
> 
> You can add this tag if you see someone leave something like this:
> "Reviewed-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>" and then you
> can
> add it to your patch.
> 
> Please remove them.
> 
> Please read this:
> 
Hi Bo-Chen,

Sorry for the later reply, there is something wrong with the mail
system.
Regarding the "Reviewd-by" in the message, my previous understanding
was wrong. I understand is who reviewed it not accepted it. 
Sorry for the unnecessary misunderstanding, I will delete it in the
next version, thanks.
> 
> 
> 
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
> 
> BRs,
> Bo-Chen

Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

[AngeloGioacchino Del Regno]

Il 29/10/22 12:50, Elvis.Wang ha scritto:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
> 
> add gce header file to define the gce thread priority, gce subsys id,
>   event and constant for mt8188.
> v2 - use vendor in filename, use Dual license.
> 
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> Reviewed-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Thanks for the reviews, I have fixed them.

I can't see where/when Krzysztof gave you his R-b tag. Drop it.

Also, please fix the typo in the commit title. s/bingings/bindings/g.

Regards,
Angelo

Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

[Elvis Wang (王军)]

On Mon, 2022-10-31 at 14:49 +0100, AngeloGioacchino Del Regno wrote:
> Il 29/10/22 12:50, Elvis.Wang ha scritto:
> > From: Elvis Wang <Elvis.Wang@mediatek.com>
> > 
> > add gce header file to define the gce thread priority, gce subsys
> > id,
> >   event and constant for mt8188.
> > v2 - use vendor in filename, use Dual license.
> > 
> > Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> > Reviewed-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > Thanks for the reviews, I have fixed them.
> 
> I can't see where/when Krzysztof gave you his R-b tag. Drop it.

Sorry for the unnecessary misunderstanding,
Regarding the "Reviewd-by" in the message, my previous understanding
was wrong. I understand is who reviewed it not accepted it. I will
delete it in the next version, thanks.

> 
> Also, please fix the typo in the commit title. s/bingings/bindings/g.

will fix in next version, thanks for the review.

> 
> Regards,
> Angelo
> 

Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

[Krzysztof Kozlowski]

On 29/10/2022 06:50, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
> 
> add gce header file to define the gce thread priority, gce subsys id,
>  event and constant for mt8188.
> v2 - use vendor in filename, use Dual license.

That's not formatting expected in Linux kernel. Use git log to find
examples...

> 
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> Reviewed-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Not true.

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: mailbox: mediatek,gce-mailbox: add mt8188 compatible name

[AngeloGioacchino Del Regno]

Il 29/10/22 12:50, Elvis.Wang ha scritto:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
> 
> Add mt8188 compatible name.
> 
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH 2/2] dt-bindings: mailbox: mediatek,gce-mailbox: add mt8188 compatible name

[Krzysztof Kozlowski]

On 29/10/2022 06:50, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
> 
> Add mt8188 compatible name.
> 
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> ---
>  .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml        | 1 +
>  1 file changed, 1 insertion(+)
> 

Looks ok, but you need to resend making it a proper patchset. Without
fake tags.

Best regards,
Krzysztof