From: Krzysztof Kozlowski <krzk@kernel.org>
To: xianwei.zhao@amlogic.com,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: amlogic: s4: add ao secure node
Date: Fri, 12 Jul 2024 09:49:30 +0200 [thread overview]
Message-ID: <bc3b08ee-f500-458a-b23f-0be4bbe0ed8b@kernel.org> (raw)
In-Reply-To: <20240712-soc_info-v1-2-05ba95929d5a@amlogic.com>
On 12/07/2024 08:54, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>
> Add node for board info registers, which allows getting SoC family and
> board revision.
>
> For example, with MESON_GX_SOCINFO config enabled we can get the
> following information for board with Amlogic S4 SoC:
> soc soc0: Amlogic S4 (S805X2) Revision 37:a (2:1) Detecte
>
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index c11c947fa18c..316905ec191c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -763,6 +763,12 @@ reset: reset-controller@2000 {
> #reset-cells = <1>;
> };
>
> + sec_ao: ao-secure@10220 {
> + compatible = "amlogic,meson-gx-ao-secure", "syscon";
This is not gx, but s4, so incorrect compatible used. Same for all other
patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-12 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 6:54 [PATCH 0/5] Add new Amlogic SoCs info defines Xianwei Zhao via B4 Relay
2024-07-12 6:54 ` [PATCH 1/5] soc: amlogic: meson-gx-socinfo: add new SoCs id Xianwei Zhao via B4 Relay
2024-07-12 10:10 ` Neil Armstrong
2024-07-12 6:54 ` [PATCH 2/5] arm64: dts: amlogic: s4: add ao secure node Xianwei Zhao via B4 Relay
2024-07-12 7:49 ` Krzysztof Kozlowski [this message]
2024-07-15 3:31 ` Xianwei Zhao
2024-07-12 6:54 ` [PATCH 3/5] arm64: dts: amlogic: c3: " Xianwei Zhao via B4 Relay
2024-07-12 6:54 ` [PATCH 4/5] arm64: dts: amlogic: t7: " Xianwei Zhao via B4 Relay
2024-07-12 6:54 ` [PATCH 5/5] arm64: dts: amlogic: a4: " Xianwei Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc3b08ee-f500-458a-b23f-0be4bbe0ed8b@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).