From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Ben Wolsieffer <ben.wolsieffer@hefring.com>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock
Date: Tue, 21 Nov 2023 14:29:01 +0100 [thread overview]
Message-ID: <bc4d3beb-c233-4946-af2a-15b23adb5c67@foss.st.com> (raw)
In-Reply-To: <20231101155153.2767482-2-ben.wolsieffer@hefring.com>
Hi Ben
On 11/1/23 16:51, Ben Wolsieffer wrote:
> The syscfg syscon was missing its clock, therefore any attempt to
> read/write it after clk_disable_unused() silently failed. This was
> preventing external pin interrupts from working if they were initialized
> after this point.
>
> Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
> ---
> arch/arm/boot/dts/st/stm32f746.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/st/stm32f746.dtsi b/arch/arm/boot/dts/st/stm32f746.dtsi
> index 4942753d011e..cce6ab0e4617 100644
> --- a/arch/arm/boot/dts/st/stm32f746.dtsi
> +++ b/arch/arm/boot/dts/st/stm32f746.dtsi
> @@ -501,6 +501,7 @@ sdio1: mmc@40012c00 {
> syscfg: syscon@40013800 {
> compatible = "st,stm32-syscfg", "syscon";
> reg = <0x40013800 0x400>;
> + clocks = <&rcc 0 STM32F7_APB2_CLOCK(SYSCFG)>;
> };
>
> exti: interrupt-controller@40013c00 {
next prev parent reply other threads:[~2023-11-21 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 15:51 [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock Ben Wolsieffer
2023-11-21 13:29 ` Alexandre TORGUE [this message]
2023-11-21 13:30 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc4d3beb-c233-4946-af2a-15b23adb5c67@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=ben.wolsieffer@hefring.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).