From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 004473B42D1 for ; Thu, 30 Jul 2026 06:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785393629; cv=none; b=ZTf81fr1RSjPyyVsBUX66K41iAfMAAr1sIKZI7BkUwELKEfYN1+MA/ENZJ6sBOT0kkGScvs1rlsNI31vef08in3V3SbZs/QaT+5EWLOzJFvWTxTinC8jm/mLDLKyGHFOC0+IBi1Nksp42Rk+aEDVfZm7yOtm5vAWDso9tny5Cfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785393629; c=relaxed/simple; bh=Y3x16PPIVyHj8Uh+iuCq3XKJqgFqpJFXRbLoKKVW1rI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tJZAeHrZsDTMqAWsKRx+2D8dzjDC4j4a9l8H0eOdBFjaLyLE2r73O8/toXTTZcDq5izxLYdgO0E4oADIxxF45H+VZMfRCOzJ3NwK1DDAWoDC48NRraswjeemAqmEqcXXOHSbO6bnAkLJAAZbUSMXLLRXI8wVTzMZtOQqwO9bOmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ts8aN9wO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e49R6bGn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ts8aN9wO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e49R6bGn" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66U6aa5G466124 for ; Thu, 30 Jul 2026 06:40:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 59EmuRUbgg9pAUe86V2NHMrtVqPRLri3llHo5p/HhR0=; b=Ts8aN9wO+0Hi3lpv WqRUQgeVeTXb1912+2DTImx7Xzjyyeqggj1mcyos7Yov0F/Dxlao/xKaIQYUVJOz MBkkcC/szBmAxFy6XnNe7zXEunOflzbfTUfpgtnGkNZdshPQYX98eKQQYAiS6Qrr r5eK6mWUv1yHyPXDOp4tll+7APlP/ZY8dvDAosgER8//fdc46QNDM+Qb1GHuexDH f17+7Gn4pHJ+UCd9LQouUWHY3qm05YsDi2WWHXtGy1quKbVja28EaUvtnzFE5wd9 wjsH/04zKJ8EcPtAmyEdzZL3Gh1sK2GkJ0uCq70iM2J41ih6kQByQGXi2xl54k4G BofN+Q== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr18d8363-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 06:40:27 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c88cfe287e1so1431841a12.1 for ; Wed, 29 Jul 2026 23:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785393626; x=1785998426; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=59EmuRUbgg9pAUe86V2NHMrtVqPRLri3llHo5p/HhR0=; b=e49R6bGnNlpQkITzIbXl0D02xty7T/5Gcuhy+q6ELXESbtvRLZuZpoav8DAB4AqVzV 0SD2z2ljYWwOVTSWAwarpzjeeoSIrPF+4tNbLSEhe8/IUoO7rnq13VXmul8OpmGE+YwT G9VuyfMCH0UPea59zH+CfUc1uLykZ+VexctGU/Y4Ufffgq11XcbwwZQ2yTuHBhSdspj6 Yo+eb5/Cck3CthM+tKvv6kv49E9uu8Wa2Apdu7UDPXTIm48vtP+m1nRA+vs1X7gbLF5V jc4sO5Qt86ZykLTDF+3VZbZBptpqLsXLgz6UJMyUNDkC1out5KoHnqAHMEMbGA6X6Xgo Fncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785393626; x=1785998426; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=59EmuRUbgg9pAUe86V2NHMrtVqPRLri3llHo5p/HhR0=; b=WGYqfhQkE0i0oGXcmZ18fSycM8qhO4RrqshyNmMHCWMh+YoOMHSiekBpQxi/+cVryi BCbWd1DUDX9wrB8XQvs3IjFRq/3c+uUbJVUmVWLSC4np6d86cLyRiWeCAlQ68vk7SuTR uK4p/GhTxcVKDEKGYbhW2LQ/Mvg/96FE18Mt8GuP+l9ccIqlPbd7pyazfQOPK8EmucvF f0+Zq9KtZB4eH6YHFdZseuLn71FxYE6KbOcbG1/K1uf69s9p81nv0+zalfWIZ1xTe+u1 aLoXPleDviD1k4EDwKKmFSRGP+K2sv6337JLbIoLSpsP4C6axtQVmtvaFeiLB6P3iEFT GuHA== X-Forwarded-Encrypted: i=1; AHgh+RpIJ1Dtui0eGq10o63Oqv1TCgAwJy3yhGVVEHs58iFjYTmmecoHPVNLweVEdbBENurkR87EZcW6PNa3@vger.kernel.org X-Gm-Message-State: AOJu0YwrTmmkFxbZunTDrs5SJWZrdG/58tAhlD5mR0cRdUZ2Kji5zL9N WiNVgEIc15PtXPcSb0DQh6ux1QPz8/yIH+JLR0T5IB8RjpPvTA+gBSOFYcP5qSgpwKX5TYl9BWn Xuymro5SKXYpZVsu7cEIkZbAmEl5bhqddYTM34CeAgtDWthZnbSvZuu8zvufPF+aL X-Gm-Gg: AR+sD10gzSa+Y5CJv+V3m5GZHdIn+rmmb/gBx9pTY67W/XKU560T76anyBBrQe3QejF mbcvm3qDn+jUrFSc7vQLGapwBFVxF9DlE/QO3J+NYG/2I71FkGOmV/ufjCvRU1eq2v78VgPNMNB /z5+wHM84g4GfzOdzMAFn0FWorU0xyXkcX3zjk4sCk+wUSx4rx9u/jxIyGb0Cz51zbtJeRImPKH bQEgB913UE3jsSj+i9zQcV1TEIfYyG42OFXsdbjjF5ujODV/LQcXTJO+wtImNxEYWheRotrpIK/ vWpwo/5T/BYQfel/N8ARgXECPCZZrwcjgKWYNrZOKWicXvu5tAnmDwl/1cTt8s00HkSdqmNaNOO V4eMWObe0lLI5hmNn3pYIt/eQBILVxdT2ABCQquIjpq+TGb/7SL5vUBrVUyisGtYKYvY0rrr2rV TbgTtGee2lgOXOKg== X-Received: by 2002:a17:903:2c10:b0:2ca:b4b9:4586 with SMTP id d9443c01a7336-2d035bdf320mr14389285ad.19.1785393626603; Wed, 29 Jul 2026 23:40:26 -0700 (PDT) X-Received: by 2002:a17:903:2c10:b0:2ca:b4b9:4586 with SMTP id d9443c01a7336-2d035bdf320mr14389005ad.19.1785393626143; Wed, 29 Jul 2026 23:40:26 -0700 (PDT) Received: from [10.190.200.192] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022a45f1esm21550055ad.20.2026.07.29.23.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 23:40:25 -0700 (PDT) Message-ID: Date: Thu, 30 Jul 2026 12:10:20 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] platform: arm64: qcom-hamoa-ec: Retry I2C transfers on NACK To: Konrad Dybcio , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> <20260728-ec_add_more_commands-v1-6-771abd65ee1a@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: fNfWLo_VGilwjkmXQ2aHZ8Vt2rPS73X4 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA0NSBTYWx0ZWRfX29CEjlQl5B4o 6i3/SfcJOBv5VWqt57iMc0Phj+Aj/SacIlSPEfSrx8YBvcL1/KS4adkln8cOQjcRE0bSmbSGvMw YO2Y90TwKDhr2qH0X9rzTwPl90zJE/s= X-Proofpoint-GUID: fNfWLo_VGilwjkmXQ2aHZ8Vt2rPS73X4 X-Authority-Analysis: v=2.4 cv=Q5ziJY2a c=1 sm=1 tr=0 ts=6a6af1db cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=It6PG1r-qJMbqxhxAG0A:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA0NSBTYWx0ZWRfX9XC5Zs2H2nFA WY0YL4Vx6zbwZuFKeIvp2TsTtDVDJkSD/LF2HIpekB6U5yP2kN3SYk7XSk+J2jDcgbGT3i/6Mrw Qjpdesy0VU11B5XcLeGpCNAQePJoDt5kGUtnYwDKdaii1Fb5TcgmJi4hydCkI39P56VEQpOqyQE DGeVxeRrrkMOciA/uag+lukEeBSpv40j4QU6ql5G6oTy/axRvB9EhHMmY8CUc/TfhzxRUNdGKbx uT22CMvhc24JBcfAw7iiGhxVndQtfkZoQYYe6IbpR1v3NiYWtjnKfz32cbeAi8aDOCUwwEPemq9 1UzZfVLg4IE3aTcBK8D3SlaSIP/JSauXi3BAJgh1NAr4PxoagO+1X2+xd2kJLd+nj0j4ZIPN3Bj dpziAkXe5k4YNYNkahf9su5WbxzGgb50LwSKoWX/aZPrnGdMTu7DTTU+FnFLke7ue6weaZS8ZMe T1/Iv/D0oj24E1zOQqw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_02,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300045 On 7/29/2026 4:41 PM, Konrad Dybcio wrote: > On 7/28/26 7:44 PM, Anvesh Jain P wrote: >> The EC firmware NACKs the bus instead of clock-stretching while it is >> busy servicing internal work (e.g. right after boot, when it is also >> emitting a burst of SCI events). A transfer issued in that window fails >> with -ENXIO even though the EC is otherwise healthy. >> >> This isn't visible with the smbus-only command set used previously; it >> surfaced while stress-testing the new fan LUT command on Hamoa, which >> issues raw i2c_transfer() calls more aggressively and is thus more >> likely to land in the NACK window right after boot or during an SCI >> event burst. >> >> Retry qcom_ec_write() and qcom_ec_read() a bounded number of times with >> a short delay when the EC NACKs the transfer, before giving up. >> >> Signed-off-by: Anvesh Jain P >> --- > [...] > >> enum qcom_ec_sci_events { >> EC_FAN1_STATUS_CHANGE_EVT = 0x30, >> EC_FAN2_STATUS_CHANGE_EVT, >> @@ -233,11 +245,20 @@ static int qcom_ec_write(struct qcom_ec *ec, u8 cmd, const u8 *data, size_t len) >> msg.buf[0] = cmd; >> memcpy(&msg.buf[1], data, len); >> >> - ret = i2c_transfer(ec->client->adapter, &msg, 1); >> + for (int i = 0; i < EC_I2C_NACK_MAX_ATTEMPTS; i++) { >> + ret = i2c_transfer(ec->client->adapter, &msg, 1); >> + ret = ret == 1 ? 0 : (ret < 0 ? ret : -EIO); > Please break this monster up. I know it already exists in-tree, but > since you're moving it around, we might as well. Agreed, will break that up into an explicit if/else instead of the nested ternary in both qcom_ec_write() and qcom_ec_read(). -- Best Regards, Anvesh