From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Raymond Hackley <raymondhackley@protonmail.com>,
linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
Date: Mon, 23 Oct 2023 18:51:05 +0200 [thread overview]
Message-ID: <bc5bbf47-7bcb-4fc6-a88b-b92d74803a7a@linaro.org> (raw)
In-Reply-To: <20231017101636.62755-1-raymondhackley@protonmail.com>
On 17/10/2023 12:18, Raymond Hackley wrote:
> Input event code 139 stands for KEY_MENU, instead of KEY_OK as node name
> key-ok inplies. Fix it with correct event code 0x160.
>
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
> arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
> index 7daf25865551..3c1ae3c19828 100644
> --- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
> @@ -159,7 +159,7 @@ key-power {
>
> key-ok {
> gpios = <&gpx0 1 GPIO_ACTIVE_LOW>;
> - linux,code = <139>;
> + linux,code = <0x160>;
I applied this and was about to send in pull request, but it does not
seem right, sorry. The button was always called "menu" button. Why
changing it to OK? Just because of node name? The node name does not
matter, this could be called "key-1" as well..
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-23 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 10:16 [PATCH v2 0/2] ARM: dts: samsung: exynos4412-midas: fix key-ok and use Linux event codes Raymond Hackley
2023-10-17 10:18 ` [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code Raymond Hackley
2023-10-23 16:51 ` Krzysztof Kozlowski [this message]
2023-10-24 12:37 ` Raymond Hackley
2023-10-24 13:22 ` Krzysztof Kozlowski
2023-10-17 10:18 ` [PATCH v2 2/2] ARM: dts: samsung: exynos4412-midas: use Linux event codes for input keys Raymond Hackley
2023-10-18 6:24 ` [PATCH v2 0/2] ARM: dts: samsung: exynos4412-midas: fix key-ok and use Linux event codes Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc5bbf47-7bcb-4fc6-a88b-b92d74803a7a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).