From: Shan-Chun Hung <shanchun1218@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
pbrobinson@gmail.com, serghox@gmail.com, mcgrof@kernel.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
forbidden405@outlook.com, tmaimon77@gmail.com,
andy.shevchenko@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ychuang3@nuvoton.com, schung@nuvoton.com
Subject: Re: [PATCH v2 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI driver
Date: Fri, 28 Jun 2024 15:17:53 +0800 [thread overview]
Message-ID: <bc609725-9201-49e7-bb34-3b3b4077c0e6@gmail.com> (raw)
In-Reply-To: <8e633bf9-4891-4e5c-acac-187c7e7249f5@intel.com>
Dear Adrian,
Yes, that is correct. It relates to the AHB bus DMA burst size.
/*
* Split data into chunks of 16 or 8 bytes for sending.
* Each chunk transfer is guaranteed to be uninterrupted on the bus.
* This likely corresponds to the AHB bus DMA burst size.
*/
Best Regards,
Shan-Chun
On 2024/6/28 下午 02:59, Adrian Hunter wrote:
> On 28/06/24 09:30, Shan-Chun Hung wrote:
>> On 2024/6/27 下午 05:40, Adrian Hunter wrote:
>>> On 26/06/24 12:49, Shan-Chun Hung wrote:
>>>> + /* Enable INCR16 and INCR8 */
>>> Comment would be more useful if it said what INCR16 and
>>> INCR8 are
>> I will modify as follows:
>>
>> /*
>> * Split data into chunks of 16 or 8 bytes for sending.
>> * Each chunk transfer is guaranteed to be uninterrupted on the bus.
>> */
>>
> AFAICT, it relates to AHB bus DMA burst size, so maybe add
> that if it is correct.
>
next prev parent reply other threads:[~2024-06-28 7:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 9:48 [PATCH v2 0/2] Add support for Nuvoton MA35D1 SDHCI Shan-Chun Hung
2024-06-26 9:48 ` [PATCH v2 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller Shan-Chun Hung
2024-06-28 7:29 ` Krzysztof Kozlowski
2024-06-26 9:49 ` [PATCH v2 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI driver Shan-Chun Hung
2024-06-27 9:40 ` Adrian Hunter
2024-06-28 6:30 ` Shan-Chun Hung
2024-06-28 6:59 ` Adrian Hunter
2024-06-28 7:17 ` Shan-Chun Hung [this message]
2024-06-28 7:31 ` Krzysztof Kozlowski
2024-06-28 7:50 ` Shan-Chun Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc609725-9201-49e7-bb34-3b3b4077c0e6@gmail.com \
--to=shanchun1218@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pbrobinson@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=serghox@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).