From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426A1C6FA82 for ; Tue, 27 Sep 2022 14:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232340AbiI0O3S (ORCPT ); Tue, 27 Sep 2022 10:29:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232583AbiI0O3I (ORCPT ); Tue, 27 Sep 2022 10:29:08 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A3CF1D42 for ; Tue, 27 Sep 2022 07:28:59 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id o2so15949966lfc.10 for ; Tue, 27 Sep 2022 07:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=t/zPAMSAQWX7Jp2Kkrznx3pd8BaYj/V4IovrZOP0p7CA9dHLcTpMosv+TEf82eIdQN ZzPiXw9rKlWK7dgrb/2R9JIb8zq9h17dOUBhdV7CLo6ItGSkQYBffOF2Ou5wtqP2NA3T N9rEoP+h50jfo80xq4j1r3mCJzXfyYlWLZNzw2x5BGe+XyxiWRwC+2x4+yiqv6IzriEM fuXrcHsauWPdkNwTqAUt31tFVgYpbwvnD8NThfc3Z4YxzLdIRb1JExpoeuZAlbZVjurb kbFPPAxHbGw01+RTl5nssKqglXejrUk6qW39J2Eas+i02imuJL8VJjhw11y61M81MWAG 3WYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=92yZ7qnRQqA49V70vN00C9HGqUmmV5lex66grIlTbSc=; b=gXrnzqlX5Awh2NGNGrfO4aEcm+rvuW+s1PguIhE3XVjxKbHs4FX8x/csr7kneETZNN F3+cMni3C2JiVY5y6WQDY5+p669nEPNYG9UzKV1+I8JBXv48Skir3btDcsXxwJlj87x7 0KzlYQVkZ/rgh7QHYoDmLTmK5A1krDN6bYtBistVcjTOCUIPXEZpF4cRcYyfRMBQPBXO hchDqXOhIZFh3NXAbknRiiHub+4bwvn79QblxHfbXAKVm1I7+KtIocg+VetmGUtxxyEU XtRbAe/aYk6ThXzoWjGgKYlrX4TN2bCKLnDPYBd1+biVDumNE14NjijkXNelugVvt3zg dP7Q== X-Gm-Message-State: ACrzQf1F7/MlzRI0H1DIGYf7LHH6BpT1v+B3+xG1m1Fj7xIkIYbPp1TY iY5FLW/5WLgNTiOZuNk5Ob3ExA== X-Google-Smtp-Source: AMsMyM53dC3y7erBKfzBQ+Nze0zZtnLF71JT4J25PfiX1YCvYNVOBA7+2R4vFWpiZCxVk3PBax4BpA== X-Received: by 2002:a05:6512:308f:b0:49a:5a59:aa25 with SMTP id z15-20020a056512308f00b0049a5a59aa25mr10629204lfd.44.1664288937219; Tue, 27 Sep 2022 07:28:57 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q12-20020ac25a0c000000b00494a1b242dasm182416lfn.14.2022.09.27.07.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 07:28:55 -0700 (PDT) Message-ID: Date: Tue, 27 Sep 2022 16:28:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/09/2022 15:04, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dpi support to enable the HDMI path. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> index 72049a530ae1..27f029ca760b 100644 >>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>> .data = (void *)MTK_DPI }, >>> { .compatible = "mediatek,mt8192-dpi", >>> .data = (void *)MTK_DPI }, >>> + { .compatible = "mediatek,mt8195-dpi", >>> + .data = (void *)MTK_DPI }, >> >> It's compatible with the others. You don't need more compatibles. > > Hi Krzysztof, > > It's a bit confusing, because this compatible is used in both > mtk_drm_drv.c and in mtk_dpi.c > > Albeit it's entirely the same thing regarding the mtk_drm_drv module, > it's pretty different > regarding the mtk_dpi module. Sure, but this does not explain why do you need these entries here in mtk_drm_drv. Best regards, Krzysztof