From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f5.google.com (mail-pj2-f5.google.com [74.125.227.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A3BB3E024D for ; Fri, 18 Sep 2026 08:22:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789719744; cv=none; b=j2utnatVR6sXsHzOBUUKr08zE2otm1WOFjEwX9ql/SN/CAI7Gn4KeEjns1+bOCYl2UsgO6lWZFBUA9VmZfahPI9+m9YrHQjjdiqd3sePhZkmGRf9UlaWg/quuNh4xm3TGrt0qRnLoo2o6S0PUeZoaLDjacNJzO9TF3QstN3l/DA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789719744; c=relaxed/simple; bh=b7SZRiTdPjaH75CaQCp3RCsjKZl29SheZjvophXkDdY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=seId2t549pSzdd6Es/ORFlRb4yd/MpD+hfguIGbHtBMyvRv9NJuxu+MangSWpHjErJpX7TxjjXLr7QocWjBExRddJbWptyh1rHznqZu76MxHUNT9tJkNlbX1yRMEPNIe0iEP+qhZlJOOYx98KgEiBqPkay1qA86g5/uoV04P7+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h3kyv6bk; arc=none smtp.client-ip=74.125.227.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h3kyv6bk" Received: by mail-pj2-f5.google.com with SMTP id d9443c01a7336-2d6fbdc8772so2518745ad.0 for ; Fri, 18 Sep 2026 01:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789719742; x=1790324542; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CjigVRuOlpSLvwuFF0kw47lERwh/eIzaGM/o/mwNyVQ=; b=h3kyv6bkfvOurMS8Vxjiyw950RnY3q/94qxxzKLE2N4qEcfv03k+v3o99egdd6mL81 5+gXGi7PlYYpFi0cakG8fwYYxrtkM/KEBeucGHbfTpzHLaIRS4BGYaVHToMvBejEjIJT co9EVCVju1WQvtOFHwHmV9MlRtGu35aD/M/QvGH5dbGK6wWORoyVuUsCrbB/U/tdG4EY 850jC98Ywxk19rX6nzgwn2iGYP7blboWbXLj64WV7oknzH5ydQY5K73y/iuQivEpa1nl r/CbD+qBSvmEYNfHAZSmR/dhzVW+UkrzgjMuJzAbE+5ckheOBugMJdHv6ULWm0fq9lSW iWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789719742; x=1790324542; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CjigVRuOlpSLvwuFF0kw47lERwh/eIzaGM/o/mwNyVQ=; b=D+BN8sdqkASqge7e/kly6s6KytGid9AHbPLXgZwGtSp+93ZhZnvMGZNrOqDUTm9EI9 CMxfNap0axpBL3QMQTtB2AA+JCQ5eqXSOSst3AEjkVoaispH1tQc1cY46R0VTt/H6abj P/i2GHtw/+Y2eJo3hs0iJEI28kBvAko/fV4NO52gqhfBy7pSuCveWjhZ9AgSiCfXCQRS oiYfL2d52TZXJ0xgyRaART5/QB5O5ZnOrtfs+kQ7XJUQvJ6hfOk0W9V51G6fXncZyCZj sptxVeZAFOMMqGydy6OwW2GejkqHRXt6fq0fXjRL+8xXnCs2hKhUldR1So75/P/tqQSe ns/A== X-Forwarded-Encrypted: i=1; AKwUvBw5MvdRnmifYaEfztJQdJq1o9CBqxVG/399DFRkoJt90qEPbQcb2jYl60Llq5KQCbhomQip/3PbHkNh@vger.kernel.org X-Gm-Message-State: AFuF++luctVk82Y59XCEixqE1DkvUHpm9xpHXBN5S7PM7+4iikiQ8zRg UBeIiSfKYqgo7ykQ0315hhF4PvJhzl2WUyOVZTIhPZsKdIeqNDSTPU++ X-Gm-Gg: AYBFou08jF0mjssFsRnxOMUHzL+OoJr3H6dfXhr3iJN35bdW8V8IuYGVyYJV8OGn7A+ RxRxHM1OYj6DZxHm7NpKUkajY8WaupM0/1QQ+noU2hVWU0NQvJ/0I77CHUpsXnNyCvzR8dF6WH8 bUuVFLl3gsaGHlZVUq/jyTxJ5+6tm4r1yvKV64DpPu7Fw6TM71kqhTK6wdLiC09VSJwb068nvmm iLwUHgElJbjDGDdZitvPg47bvhRlgB4C//aZPQQ2EJI4FOePLTxwxLb0DI+KWWqxoCPk5OCB6cP FGh0w0Uscdj6Y48SLmP0V/ee08rEBYFwNlEmZqIdbR+lknauDPBISJhVD25qT+vbZ62ejjPneHN 8DN6fs11xPXAwDOpoQfbBs1qZyysidNAtdBUxRPUFxdoebo4OQlcv3c8uKzUTx/1qAXY1QPGhjJ XrgGGlbWGGsumzr4SqIfpj8pOM9cAfxpRGix5gn1L7AHuRiolT+yqGYqF6uc/ywxjRu0JXlm9Aw Po0ug== X-Received: by 2002:a05:6a00:4196:b0:874:708d:b637 with SMTP id d2e1a72fcca58-874df800839mr3426122b3a.35.1789719741686; Fri, 18 Sep 2026 01:22:21 -0700 (PDT) Received: from [10.125.112.20] ([122.11.210.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc5c50e79f1sm541488a12.30.2026.09.18.01.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2026 01:22:20 -0700 (PDT) Message-ID: Date: Fri, 18 Sep 2026 16:22:03 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 06/10] memblock: introduce MEMBLOCK_NODUMP flag To: Baoquan He Cc: catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, robh@kernel.org, saravanak@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, m.szyprowski@samsung.com, mark.rutland@arm.com, kernel@xen0n.name, alex@ghiti.fr, hpa@zytor.com, ruirui.yang@linux.dev, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20260902073116.802752-1-chenwandun1@gmail.com> <20260902073116.802752-7-chenwandun1@gmail.com> Content-Language: en-US From: Wandun In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/18/26 16:08, Baoquan He wrote: > On 09/02/26 at 03:31pm, Wandun Chen wrote: >> From: Wandun Chen >> >> Add MEMBLOCK_NODUMP to mark regions that should be excluded from >> kdump vmcores. >> >> The flag is meant for reserved memory that carries no data useful for >> crash analysis. Reusable reserved regions such as CMA may hold useful >> data, so these regions must not be marked MEMBLOCK_NODUMP. Subsequent >> patches wire this up for /reserved-memory and /memreserve/ entries. >> >> Suggested-by: Rob Herring >> Signed-off-by: Wandun Chen >> Tested-by: Meijing Zhao >> --- >> include/linux/memblock.h | 9 +++++++++ >> mm/memblock.c | 16 ++++++++++++++++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/include/linux/memblock.h b/include/linux/memblock.h >> index d62db9e776cf..b2fcf11fba2b 100644 >> --- a/include/linux/memblock.h >> +++ b/include/linux/memblock.h >> @@ -52,6 +52,8 @@ extern unsigned long long max_possible_pfn; >> * kernel that we know is good to use. It is the only memory that >> * allocations may happen from in this phase. >> * @MEMBLOCK_RSRV_HUGETLB: memory is reserved for hugetlb pages >> + * @MEMBLOCK_NODUMP: exclude from kdump vmcore. It carries no data useful >> + * for crash analysis (e.g. firmware carveouts). >> */ >> enum memblock_flags { >> MEMBLOCK_NONE = 0x0, /* No special request */ >> @@ -63,6 +65,7 @@ enum memblock_flags { >> MEMBLOCK_RSRV_KERN = 0x20, /* memory reserved for kernel use */ >> MEMBLOCK_KHO_SCRATCH = 0x40, /* scratch memory for kexec handover */ >> MEMBLOCK_RSRV_HUGETLB = 0x80, /* memory reserved for hugetlb pages */ >> + MEMBLOCK_NODUMP = 0x100,/* exclude from kdump vmcore */ >> }; >> >> /** >> @@ -160,6 +163,7 @@ int memblock_reserved_mark_noinit(phys_addr_t base, phys_addr_t size); >> int memblock_reserved_mark_kern(phys_addr_t base, phys_addr_t size); >> int memblock_mark_kho_scratch(phys_addr_t base, phys_addr_t size); >> int memblock_clear_kho_scratch(phys_addr_t base, phys_addr_t size); >> +int memblock_mark_nodump(phys_addr_t base, phys_addr_t size); >> >> void memblock_free(void *ptr, size_t size); >> void reset_all_zones_managed_pages(void); >> @@ -306,6 +310,11 @@ static inline bool memblock_is_kho_scratch(struct memblock_region *m) >> return m->flags & MEMBLOCK_KHO_SCRATCH; >> } >> >> +static inline bool memblock_is_nodump(struct memblock_region *m) >> +{ >> + return m->flags & MEMBLOCK_NODUMP; >> +} >> + >> int memblock_search_pfn_nid(unsigned long pfn, unsigned long *start_pfn, >> unsigned long *end_pfn); >> void __next_mem_pfn_range(int *idx, int nid, unsigned long *out_start_pfn, >> diff --git a/mm/memblock.c b/mm/memblock.c >> index f2952d725c10..2e87f39826dd 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -1204,6 +1204,21 @@ __init int memblock_clear_kho_scratch(phys_addr_t base, phys_addr_t size) >> MEMBLOCK_KHO_SCRATCH); >> } >> >> +/** >> + * memblock_mark_nodump - Mark a memory region with flag MEMBLOCK_NODUMP. >> + * @base: the base phys addr of the region >> + * @size: the size of the region >> + * >> + * Mark the region as not to be included in crash dumps. >> + * >> + * Return: 0 on success, -errno on failure. >> + */ >> +int __init_memblock memblock_mark_nodump(phys_addr_t base, phys_addr_t size) > ~~~~~~~~~~~~~~^ > Is it impossible to use at runtime even thought it claims to be generic? It is currently only used during initialization, so I added __init_memblock. If other modules need to use this function in the future, this annotation can be removed. Best regards, Wandun> > >> +{ >> + return memblock_setclr_flag(&memblock.memory, base, size, 1, >> + MEMBLOCK_NODUMP); >> +} >> + >> static bool should_skip_region(struct memblock_type *type, >> struct memblock_region *m, >> int nid, int flags) >> @@ -2887,6 +2902,7 @@ static const char * const flagname[] = { >> [ilog2(MEMBLOCK_RSRV_KERN)] = "RSV_KERN", >> [ilog2(MEMBLOCK_KHO_SCRATCH)] = "KHO_SCRATCH", >> [ilog2(MEMBLOCK_RSRV_HUGETLB)] = "RSV_HUGETLB", >> + [ilog2(MEMBLOCK_NODUMP)] = "NODUMP", >> }; >> >> static int memblock_debug_show(struct seq_file *m, void *private) >> -- >> 2.43.0 >>