Re: [PATCH v2 2/3] drm/mipi-dsi: add mipi_dsi_usleep_range helper

[Neil Armstrong <neil.armstrong@linaro.org>]

On 26/06/2024 16:22, Jerome Brunet wrote:
> Like for mipi_dsi_msleep(), usleep_range() may often be called
> in between mipi_dsi_dcs_*() functions and needs a multi compatible
> counter part.
> 
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>   include/drm/drm_mipi_dsi.h | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index 71d121aeef24..0f520eeeaa8e 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -10,6 +10,7 @@
>   #define __DRM_MIPI_DSI_H__
>   
>   #include <linux/device.h>
> +#include <linux/delay.h>
>   
>   struct mipi_dsi_host;
>   struct mipi_dsi_device;
> @@ -297,6 +298,12 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params,
>   			msleep(delay);	\
>   	} while (0)
>   
> +#define mipi_dsi_usleep_range(ctx, min, max)	\
> +	do {					\
> +		if (!(ctx)->accum_err)		\
> +			usleep_range(min, max);	\
> +	} while (0)
> +
>   /**
>    * enum mipi_dsi_dcs_tear_mode - Tearing Effect Output Line mode
>    * @MIPI_DSI_DCS_TEAR_MODE_VBLANK: the TE output line consists of V-Blanking

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>