From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552A8186299 for ; Wed, 26 Jun 2024 16:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719419718; cv=none; b=h6OX8lp5MGajYK8Nmr+SD1Oqj+D2yp6hqE/PHBWYyKzg39Wldx8xa2OkqClnLK5M3dBA7I7fB41JqwuOZjjbOIfVkTAqsGC4GTgaE4zSSqccGGS5mVD7NreDyrytgO3TMttg5t//1FFRDSAjv7tdP8vS0DVYLsT/BvDlcnUR+xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719419718; c=relaxed/simple; bh=kgGAP2jiX9oay6z5BxbbxJlZ5+1RVmCwiBdWsINvYMM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=BVRzsbagLdXBuGAmrGr+XfOwIRsOcv5uudLUc2La+iQKTdBd4uFjyRP0EDmpGkgm5HFOurHL8Nwb39ukevn1unL1csbcM7wNZyRVzhWeFb+OegxfxHPauXW2tBQBJnge4KF0tpvSO65o7/svcVTap/BEhiAgA7ZmiBVbIgH4MZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zwRHRWV9; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zwRHRWV9" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-424720e73e1so55663385e9.1 for ; Wed, 26 Jun 2024 09:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719419715; x=1720024515; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=IVNombFGh6XnGXwdeuW//QrSGHhjwRxXK5+Bp5Yi1fc=; b=zwRHRWV9ZF20Ai9uvhdKcVYYdTZ3BubjHyt10E6GL1mvsm+c36nTjwOmiVV+w0x3Ey r2N9fpINH6NCUKLTZf98fxScNUhfGtlhrGfiqvbSuXTKI+yDYSBCf3h2rVCOMbAlMUZq N2Mr+tctPB1wqZDGfqxiJxYDBegRWoB/v4/l9Tl3edag0YCgsIEhADPi3et0nUC0k+7q Ac/C3vk6VGydtGA/7n84Z80x5PV8ePMs9JH331kgu3MoVxH6e6JOyL9dkQhs5Abk5Sky UpicJMuN7XKe1eSKo+qyZoRj88Jdz0YSxNSGZuWyoebzh5R+TNZ+RBmL+1NLGIDku5S5 Fz8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719419715; x=1720024515; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IVNombFGh6XnGXwdeuW//QrSGHhjwRxXK5+Bp5Yi1fc=; b=FdOOCKaIK8/d0DuiSXx6K4RX0UDou3m/JwmP90jdo3wZ0TauWDp/ZXCbEkLHePq88p DWxo8wE3b/HlfV4GJ2QeKj5BhkO85YQ71cfMZl2Iv0TH2jiEPrlG86dhnIzuSZq623KC BBWcmL77Tz6zGiAdTmaIUOd9G0X5JIVNxjmSV4eY4VhQB1K2gCRR9N27VXQbHiz5W1aq lCGLEUxgmW+5Nd7YekroXKsrcLaOVubpEZYbgGwFQGSEdqLrekY7nBinXwrX8sBAsw8I 7/7AWgLyQP0IcCv+8CddtrMsPlqh3sX1iuZgpih+4BjcEth0QbBLr1+AEsqmAyQ7n74e 8FSw== X-Forwarded-Encrypted: i=1; AJvYcCUmB8wfFPlFpnsml1h+A7KA7C0f/QOw+L7BNO3KAQlc7FZe2iNTJeAUMj/K5S+I8yWzOJQ9cb82R2WI9N1Vi7I54CEX3h74KXTGrw== X-Gm-Message-State: AOJu0Yz2krUdbjao0CC7bcR97LA+uU7LzChiodWZo9dMJNDf0rZ8u8JL FSuaKVWMsbMFjGInBwexLEjObUPd3vvDjPRH9BtnYvp2J31cEhk2UBqjFx5wd/U= X-Google-Smtp-Source: AGHT+IF/H3qe3QkAkh67maafTcj7zPClcHcEdJ3mjvr0P7EcQetcMG/YNSoiIEG0zx2IAQ4inoE7dw== X-Received: by 2002:a05:600c:3c8d:b0:421:a575:99c9 with SMTP id 5b1f17b1804b1-4248fe3fa35mr63895905e9.20.1719419713858; Wed, 26 Jun 2024 09:35:13 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:afc0:84d8:433a:2d67? ([2a01:e0a:982:cbb0:afc0:84d8:433a:2d67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424c82519c8sm32498645e9.16.2024.06.26.09.35.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jun 2024 09:35:13 -0700 (PDT) Message-ID: Date: Wed, 26 Jun 2024 18:35:11 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/3] drm/mipi-dsi: add mipi_dsi_usleep_range helper To: Jerome Brunet , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, Dmitry Baryshkov References: <20240626142212.1341556-1-jbrunet@baylibre.com> <20240626142212.1341556-3-jbrunet@baylibre.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240626142212.1341556-3-jbrunet@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/06/2024 16:22, Jerome Brunet wrote: > Like for mipi_dsi_msleep(), usleep_range() may often be called > in between mipi_dsi_dcs_*() functions and needs a multi compatible > counter part. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Jerome Brunet > --- > include/drm/drm_mipi_dsi.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 71d121aeef24..0f520eeeaa8e 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -10,6 +10,7 @@ > #define __DRM_MIPI_DSI_H__ > > #include > +#include > > struct mipi_dsi_host; > struct mipi_dsi_device; > @@ -297,6 +298,12 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *dsi, const void *params, > msleep(delay); \ > } while (0) > > +#define mipi_dsi_usleep_range(ctx, min, max) \ > + do { \ > + if (!(ctx)->accum_err) \ > + usleep_range(min, max); \ > + } while (0) > + > /** > * enum mipi_dsi_dcs_tear_mode - Tearing Effect Output Line mode > * @MIPI_DSI_DCS_TEAR_MODE_VBLANK: the TE output line consists of V-Blanking Reviewed-by: Neil Armstrong