* [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl
@ 2022-08-19 10:14 Geert Uytterhoeven
2022-08-21 19:25 ` Caleb Connolly
2022-08-29 23:45 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-08-19 10:14 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Molly Sophia
Cc: linux-arm-msm, devicetree, linux-kernel, Geert Uytterhoeven
"make dtbs_check" says:
bias-disable: boolean property with value b'\x00\x00\x00\x00'
Fix this by dropping the offending value.
Fixes: be497abe19bf08fb ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Marked RFC as I do not have the hardware or documentation.
Perhaps the "bias-disable" property should be dropped instead?
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index 7747081b98875aad..dba7c2693ff50073 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -617,7 +617,7 @@ sde_dsi_active: sde-dsi-active {
pins = "gpio6", "gpio10";
function = "gpio";
drive-strength = <8>;
- bias-disable = <0>;
+ bias-disable;
};
sde_dsi_suspend: sde-dsi-suspend {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl
2022-08-19 10:14 [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl Geert Uytterhoeven
@ 2022-08-21 19:25 ` Caleb Connolly
2022-08-29 23:45 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Caleb Connolly @ 2022-08-21 19:25 UTC (permalink / raw)
To: Geert Uytterhoeven, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Molly Sophia
Cc: linux-arm-msm, devicetree, linux-kernel
On 19/08/2022 11:14, Geert Uytterhoeven wrote:
> "make dtbs_check" says:
>
> bias-disable: boolean property with value b'\x00\x00\x00\x00'
>
> Fix this by dropping the offending value.
>
> Fixes: be497abe19bf08fb ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
> Marked RFC as I do not have the hardware or documentation.
> Perhaps the "bias-disable" property should be dropped instead?
This is correct, the ` = <0>` is a downstream style, but it does actually mean to disable the bias
afaik, from downstream docs:
- bias-disable:
Usage: optional
Value type: <none>
Definition: The specified pins should be configued as no pull.
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> index 7747081b98875aad..dba7c2693ff50073 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> @@ -617,7 +617,7 @@ sde_dsi_active: sde-dsi-active {
> pins = "gpio6", "gpio10";
> function = "gpio";
> drive-strength = <8>;
> - bias-disable = <0>;
> + bias-disable;
> };
>
> sde_dsi_suspend: sde-dsi-suspend {
> --
> 2.25.1
>
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl
2022-08-19 10:14 [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl Geert Uytterhoeven
2022-08-21 19:25 ` Caleb Connolly
@ 2022-08-29 23:45 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-08-29 23:45 UTC (permalink / raw)
To: geert+renesas, Bjorn Andersson, mollysophia379, konrad.dybcio,
agross
Cc: linux-kernel, linux-arm-msm, devicetree
On Fri, 19 Aug 2022 12:14:23 +0200, Geert Uytterhoeven wrote:
> "make dtbs_check" says:
>
> bias-disable: boolean property with value b'\x00\x00\x00\x00'
>
> Fix this by dropping the offending value.
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl
commit: 5a0504945878b4af7534c1ce668a5678dc0201cf
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-29 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-19 10:14 [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl Geert Uytterhoeven
2022-08-21 19:25 ` Caleb Connolly
2022-08-29 23:45 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).