From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C80B29374B for ; Fri, 9 May 2025 13:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746798388; cv=none; b=UqUFVOz7F/jpWJFzQOSc+u54SH8N2OjzkeURiRvoDm+LFe4d+QvEeIykWsO+uC3REX5sRTXyhRqjDEDwy/IAR7i9f2t/CRuGOzlRKrUOF752Bu2tl3qR4CUfS9vg6vfycWzUqB8+jMfaqjDGtip/MSb2JN0OjfhUFDnQUOwCVpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746798388; c=relaxed/simple; bh=XO/wK7V6mXY9xU1mcWlD2Ct18mmjFn+FYLp11z65N7M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Alqti6hknvdVLdQvcgk8CfpnrTDBoc7RC2Vow/RZuhlEi3V0E1XtZlDk2Dn5XfGkWvnUOm6kkj1fhjEgc6dD+NPpZOT7p3+vaL8AoB2rTfFQwgxbe1DI/jstItq1At5HD3j83Iaw7S0of2bzwWCC4W4bRNKLOzbVVtbI1L0XRGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=q/2ONir3; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q/2ONir3" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a1b8e8b2b2so868935f8f.2 for ; Fri, 09 May 2025 06:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746798384; x=1747403184; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PZUF6Q4Qc9CPUkc04ir0Y5K/i90KczoIYGaKnAPCoYU=; b=q/2ONir32GkMPFC6dT/uDWYlpzm2wytlHIoVmvWpLmYwgZOs6JxM06D/RXz4jLvFNV Gm65lYDwf/zt7/ZRFp5/ew7R0dtj7mTooxybtt8hzKWf0ldHaLE9jhW41AqdJUm+Qlg0 jI6NtJvztVK0aTY4uOJ4rxYv8j1fj3rsTs8nfiwLAVZEueU0GP3CEQtcO/VvDKQv71/L IeYYVjMlT82hiCJM1Y0HN3C1CGQtFa7HAFpCRhfNXFxwdJISGyERrgSpwGwGZVOpQDsx oOMH8jkCNGyzfPEhHrOs+2dhsmTuWMsVrlFWMpO6OCVOwiG4DjLyBnVYyvKERNr8Rply g3Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746798384; x=1747403184; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PZUF6Q4Qc9CPUkc04ir0Y5K/i90KczoIYGaKnAPCoYU=; b=KXQPf/kWB6Sdbfs+RLep7Pe+3TCGtA81KTFtxlHAG6MPMHiBGNMi3KWH5BfBHCHRLW yYZipbZ6lvMW6tTC0CC/hrreL5RgReH+lsndncaalSDCaK1IDOdOqHa/d2i493SeZsYR qzlWL2GZ2s8xA8yh520Vk1m6UoAWd+FW/5EDRfVpCGhorwyj0gFlY6rdzQQlTWl9JqXM 9OZccGu8iV8d2SL4r8CXjTzh7UUYEmEh/vuWQSSkqR1PFa44ZMfGH8IJe/Hu/Gqvh4Nv yemJ0W9WeR8YQDPkDN/mYVdGbY+VaQaIt3KtOBRRXvYjsj6UL4lltJcEfxqAvse+M8om oi6g== X-Forwarded-Encrypted: i=1; AJvYcCXtp9oIgNbx10MVFD3Vd/wNw9mXRJsRZ7ZGYUW5WGrtjKgiNE/O8ksacY/M+K0m/V2e05oomPpwVteS@vger.kernel.org X-Gm-Message-State: AOJu0YwUBJ1xhAiytSaZtLm0uDvL9sjSr9x7mp+elilcCGCN1zkm6PAf Y82vBpkfFvdmTGIGmNPBAPmKu81g5EMMrjkrxw1P7MpcwEUIj4DZA0pQNNGvAtM= X-Gm-Gg: ASbGncvzhMo1zb1y04ftX9w8VUaipSk4ik0TR1QyEwEO8av0a7rXo04P6RgF5gFkbNg ZMZFyW0sYjyenL79dl8s4SJV0VV086sq2EAYlN4JbLSNOYaLYNsjRoUmrFmlbDGGVOwGf5Pg1QD yy5gMQv/+MEe9LwQVODsF0cIweKv0IA1h+MjviY5jYAVCsxEcbLfCnMn3UCHupSxqFH5knjtyVf zB2Aftz2vdHv4grIYd9PuBlSph4rQAQQiTucUqSWT00RJfNtWvNJ6N431mH7M/QQ0qswEmsbsUd nhJxMFhol2X2qEKop9eb1V2ztJi8hVIyyII+hxuWYsaRXuD77+/5Tg== X-Google-Smtp-Source: AGHT+IEo0jYrQRcALBtqnax8NWcKiAGj6scBJ0uiGs5jTKoY3ij/ij8y04Oz3H5GiqMjPbUsL8YJBQ== X-Received: by 2002:a5d:5f95:0:b0:3a0:b84c:7c64 with SMTP id ffacd0b85a97d-3a1f6435b6fmr3000885f8f.13.1746798384562; Fri, 09 May 2025 06:46:24 -0700 (PDT) Received: from [192.168.1.3] ([77.81.75.81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ecaeasm3290573f8f.28.2025.05.09.06.46.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 06:46:24 -0700 (PDT) Message-ID: Date: Fri, 9 May 2025 14:46:22 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/14] arm64: dts: Add DSPI entries for S32G platforms To: Matti Vaittinen , Krzysztof Kozlowski Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Radu Pirea (NXP OSS)" , Vladimir Oltean , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , NXP S32 Linux Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , larisa.grigore@nxp.com, arnd@linaro.org, andrei.stefanescu@nxp.com, dan.carpenter@linaro.org References: <20250509-james-nxp-spi-v1-0-32bfcd2fea11@linaro.org> <20250509-james-nxp-spi-v1-14-32bfcd2fea11@linaro.org> <3ddde799-76b5-43f9-971e-a52ec322e9b1@kernel.org> <16e91572-b132-4246-9fa9-8e8bc4c24f40@gmail.com> Content-Language: en-US From: James Clark In-Reply-To: <16e91572-b132-4246-9fa9-8e8bc4c24f40@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/05/2025 1:54 pm, Matti Vaittinen wrote: > On 09/05/2025 14:26, Krzysztof Kozlowski wrote: >> On 09/05/2025 13:06, James Clark wrote: >>> +&spi1 { >>> +    pinctrl-0 = <&dspi1_pins>; >>> +    pinctrl-names = "default"; >>> +    #address-cells = <1>; >>> +    #size-cells = <0>; >>> +    status = "okay"; >>> + >>> +    spidev0: spidev@0 { >> >> >> Node names should be generic. See also an explanation and list of >> examples (not exhaustive) in DT specification: >> https://devicetree-specification.readthedocs.io/en/latest/chapter2- >> devicetree-basics.html#generic-names-recommendation >> >> >>> +        compatible = "rohm,dh2228fv"; >> >> >> Nah, I really doubt. That's not the device you have there. It's >> possible, though, so can you share schematics? > > Actually, not even possible. There is no DH2228FV from ROHM. There is > BH2228FV though: > https://www.rohm.com/products/data-converter/d-a-converters/8bit-d-a/ > bh2228fv-product > > but as you know, it is unlikely this is the part populated on the board. > > For the author: > https://lore.kernel.org/linux-rockchip/20250213-calamity- > smuggler-5d606993be32@spud/T/ > > Yours, >     -- Matti Correct, I believe these go straight to a header and aren't connected, so this device is just an example placeholder for a 'generic' SPI device. It might be more accurate to remove this, and then anyone using the board for development would have to fill in themselves whatever device is attached to it. Thanks James