From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pankaj Patil <pankaj.patil@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sibi.sankar@oss.qualcomm.com,
rajendra.nayak@oss.qualcomm.com
Subject: Re: [PATCH 2/4] soc: qcom: llcc: Enable additional usecase id for Glymur
Date: Fri, 21 Nov 2025 11:37:07 +0100 [thread overview]
Message-ID: <bc8cbca0-3bfc-44e2-a7ff-401e52f76b90@kernel.org> (raw)
In-Reply-To: <20251121-glymur_llcc_enablement-v1-2-336b851b8dcb@oss.qualcomm.com>
On 21/11/2025 10:53, Pankaj Patil wrote:
> Update the list of usecase id's to enable additional clients
> for Glymur SoC
>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
> include/linux/soc/qcom/llcc-qcom.h | 4 ++++
That's not a separate patch. We do not want defines just for defines.
You add defines because some code uses it, so there is a user. Where? It
must be in this patch, for all typical cases.
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
> index 0287f9182c4d..8243ab3a12a8 100644
> --- a/include/linux/soc/qcom/llcc-qcom.h
> +++ b/include/linux/soc/qcom/llcc-qcom.h
> @@ -74,13 +74,17 @@
> #define LLCC_CAMSRTIP 73
> #define LLCC_CAMRTRF 74
> #define LLCC_CAMSRTRF 75
> +#define LLCC_OOBM_NS 81
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-21 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:53 [PATCH 0/4] soc: qcom: llcc: Add support for Glymur SoC Pankaj Patil
2025-11-21 9:53 ` [PATCH 1/4] dt-bindings: cache: qcom,llcc: Document Glymur LLCC block Pankaj Patil
2025-11-21 10:35 ` Krzysztof Kozlowski
2025-11-21 9:53 ` [PATCH 2/4] soc: qcom: llcc: Enable additional usecase id for Glymur Pankaj Patil
2025-11-21 10:37 ` Krzysztof Kozlowski [this message]
2025-11-21 11:05 ` Pankaj Patil
2025-11-21 9:53 ` [PATCH 3/4] soc: qcom: llcc: Fix usecase id macro alignment Pankaj Patil
2025-11-21 10:36 ` Krzysztof Kozlowski
2025-11-21 9:53 ` [PATCH 4/4] soc: qcom: llcc-qcom: Add support for Glymur Pankaj Patil
2025-11-21 13:16 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8cbca0-3bfc-44e2-a7ff-401e52f76b90@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=rajendra.nayak@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).