From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michal Simek <michal.simek@amd.com>,
Appana Durga Kedareswara rao
<appana.durga.kedareswara.rao@amd.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
michal.simek@xilinx.com, derek.kiernan@xilinx.com,
dragan.cvetic@xilinx.com, arnd@arndb.de,
gregkh@linuxfoundation.org
Cc: appanad@amd.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, git@amd.com,
git@xilinx.com,
Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
Subject: Re: [PATCH v2 3/4] dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject
Date: Wed, 20 Jul 2022 11:35:09 +0200 [thread overview]
Message-ID: <bc99e06b-1aa5-441e-c86f-0fbfb0945d0c@linaro.org> (raw)
In-Reply-To: <f45fccec-4496-19af-0e14-bd626e14c7bd@amd.com>
On 20/07/2022 10:26, Michal Simek wrote:
>
>
> On 7/20/22 08:15, Krzysztof Kozlowski wrote:
>> On 20/07/2022 08:00, Appana Durga Kedareswara rao wrote:
>>> From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
>>>
>>> The Triple Modular Redundancy(TMR) Inject core provides functional fault
>>> injection by changing selected MicroBlaze instructions, which provides the
>>> possibility to verify that the TMR subsystem error detection and fault
>>> recovery logic is working properly.
>>>
>>> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
>>> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
>>
>> Keep only one SoB.
>
> nit: First of all it is from xilinx.com that's why xilinx.com should be the first.
>
> Just for my understanding about guidance here.
> Code was developed by Xilinx before acquisition with AMD. And because it was
> picked from vendor tree origin xilinx.com was there to keep origin author there.
> And upstreaming is done by new company. I can't see nothing wrong on keeping
> both emails there but that's why my opinion. Definitely not a problem to remove
> one of them but wanted to make sure that we do it properly for all our submissions.
It's the same person. No need for two SoBs from the same person. Since
AMD acquired Xilinx, it holds all copyrights thus @amd.com person does
not have to include previous SoB. He/She/They has the permission from
employer to submit it. The second SoB is just redundant - brings no
actual information. Otherwise please tell me which piece of DCO the
additional SoB adds/solves (comparing to single SoB - @amd.com)?
Similarly when you change jobs while resending your patch - you do not
add new SoB but just keep SoB from @previous-company.com.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-20 9:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 6:00 [PATCH v2 0/4] drivers: misc: Add support for TMR Manager and Inject IPs Appana Durga Kedareswara rao
2022-07-20 6:00 ` [PATCH v2 1/4] dt-bindings: misc: tmr-manager: Add device-tree binding for TMR Manager Appana Durga Kedareswara rao
2022-07-20 6:15 ` Krzysztof Kozlowski
2022-07-20 6:00 ` [PATCH v2 2/4] drivers: misc: Add Support " Appana Durga Kedareswara rao
2022-07-28 14:27 ` Greg KH
2022-07-29 8:13 ` Rao, Appana Durga Kedareswara
2022-07-20 6:00 ` [PATCH v2 3/4] dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject Appana Durga Kedareswara rao
2022-07-20 6:15 ` Krzysztof Kozlowski
2022-07-20 8:26 ` Michal Simek
2022-07-20 9:35 ` Krzysztof Kozlowski [this message]
2022-07-20 12:09 ` Michal Simek
2022-07-20 12:21 ` Krzysztof Kozlowski
2022-07-20 12:35 ` Michal Simek
2022-07-20 13:21 ` Rao, Appana Durga Kedareswara
2022-07-20 6:00 ` [PATCH v2 4/4] drivers: misc: Add Support for TMR Inject IP Appana Durga Kedareswara rao
2022-07-28 14:24 ` Greg KH
2022-07-29 8:13 ` Rao, Appana Durga Kedareswara
2022-07-29 9:02 ` Greg KH
2022-08-03 6:35 ` Rao, Appana Durga Kedareswara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc99e06b-1aa5-441e-c86f-0fbfb0945d0c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=appana.durga.kedareswara.rao@amd.com \
--cc=appana.durga.rao@xilinx.com \
--cc=appanad@amd.com \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=git@amd.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).