From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control Date: Wed, 12 Oct 2016 13:43:57 +0530 Message-ID: References: <20161006051355.15947-1-mugunthanvnm@ti.com> <20161006051355.15947-2-mugunthanvnm@ti.com> <20161010131841.GA8391@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161010131841.GA8391@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , Tony Lindgren , netdev@vger.kernel.org, Sekhar Nori , linux-kernel@vger.kernel.org, Russell King , linux-omap@vger.kernel.org, David Miller , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Monday 10 October 2016 06:48 PM, Rob Herring wrote: > On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote: >> Add documention of ti,impedance-control which can be used to > > Needs updating. Oops, will update this in next version. > >> correct MAC impedance mismatch using phy extended registers. >> >> Signed-off-by: Mugunthan V N >> --- >> Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt b/Documentation/devicetree/bindings/net/ti,dp83867.txt >> index 5d21141..85bf945 100644 >> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt >> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt >> @@ -9,6 +9,18 @@ Required properties: >> - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h >> for applicable values >> >> +Optional property: >> + - ti,min-output-impedance - MAC Interface Impedance control to set >> + the programmable output impedance to >> + minimum value (35 ohms). >> + - ti,max-output-impedance - MAC Interface Impedance control to set >> + the programmable output impedance to >> + maximum value (70 ohms). > > Define what are valid range of values for these. The values are already mentioned in documentation as 35/70 ohms. Are you mentioning about the register values? Regards Mugunthan V N