From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 256F1C6FD1F for ; Thu, 9 Mar 2023 09:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230309AbjCIJp1 (ORCPT ); Thu, 9 Mar 2023 04:45:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231395AbjCIJop (ORCPT ); Thu, 9 Mar 2023 04:44:45 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A39EE4DB7 for ; Thu, 9 Mar 2023 01:44:16 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id o12so4494046edb.9 for ; Thu, 09 Mar 2023 01:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678355055; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=90Jk3Si6uTonOJsmd1LEY+OgSQcggQy5RH+0SOt5I8s=; b=dOhfUTM41wZZ96IVAsxvpXoIm+09crL9OwtPpXO2/9C3WgCiOgQZoWbhveayDi1l8i wEe52WGnCGz1MKwEyybqdKHQZ2+B8EM9x9RjxxQmRrtYN8Wh+HWlx9h9JKXMlsrwXs5u FA1npzSSv0YVzkcPFsrp2dtjCguP3lL0J9MFBsvksphVWFybyzIdT7rGGX5yR9D+eVyT dg+tJ9iTLBkhSDYByY37IZ6P8q0+N7SJTiR1y37UgeeUgIbY0nDqbpe+hQP3FB3Jg5Ug vMJTxWeEqi/6ggbuBkha2QJDmG7a4qTy4ZExIR6cQAnQ73CH9voEHo1rAnJmBEZ7leeQ kLAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678355055; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=90Jk3Si6uTonOJsmd1LEY+OgSQcggQy5RH+0SOt5I8s=; b=J0E601wBkBLCCRQ7f5LVPg0NTnCYAOeUk5+s9qF5FVc2aetMGCp8Fds8BTxsLZxYTS FhdpbjUS55wjJ4sLWrz/rkHJTk4xOTgehtmnvTbQhbNFGI+gfwst8vZerBrQNMhQ8rZW 7eMoMAK4Gi6dRqOmcbrgcruYTKO3EzFotEDlRwD9dtqMaJ3CwJF7i4JCuYvoIyErzGsw j0ctTnHcJAiIq1NPVxRcnrk/btotTCqrP2l53wNZubdNrBaw/PTod5rS7oSi09iCInce wYwP2HS3GUy24MyiCoFhPJAoAWoPJkhQSZtFKJpbUeN9n+I4t3yKRRlWciLnP270sG0r hbwQ== X-Gm-Message-State: AO0yUKUeS2M7yqLZpE39jmv5lY3xgs/pYaMHhHmtPHdiNdDkhLeQ+MPQ VGNxuldTwnPxtfNjPco8X/AYiQ== X-Google-Smtp-Source: AK7set/09lealAERy2wlmKs4hx+r/IyEPo7WcB5f+6WlfwAJt2Ph/Ds4GDlHx/FkRyfe1i9oY+Q35w== X-Received: by 2002:a17:907:c0c:b0:8af:2cf7:dd2b with SMTP id ga12-20020a1709070c0c00b008af2cf7dd2bmr26863543ejc.13.1678355054869; Thu, 09 Mar 2023 01:44:14 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:7ee2:e73e:802e:45c1? ([2a02:810d:15c0:828:7ee2:e73e:802e:45c1]) by smtp.gmail.com with ESMTPSA id fw20-20020a170907501400b00914fec9f40esm4206511ejc.71.2023.03.09.01.44.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Mar 2023 01:44:14 -0800 (PST) Message-ID: Date: Thu, 9 Mar 2023 10:44:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC 1/3] dt-bindings: clock: Add Renesas versa3 clock generator bindings To: Biju Das , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski Cc: Geert Uytterhoeven , "linux-renesas-soc@vger.kernel.org" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , Fabrizio Castro References: <20230220131307.269100-1-biju.das.jz@bp.renesas.com> <20230220131307.269100-2-biju.das.jz@bp.renesas.com> <36e06397-2189-4f1b-99cc-d39e720ebc71@linaro.org> <6cbe6c71-2d2d-0f79-1270-7f8ed2ddc1d6@linaro.org> <984f1689-459e-bd26-b96c-6c759417b3d1@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/03/2023 10:18, Biju Das wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Thursday, March 9, 2023 9:14 AM >> To: Biju Das ; Michael Turquette >> ; Stephen Boyd ; Rob Herring >> ; Krzysztof Kozlowski >> >> Cc: Geert Uytterhoeven ; linux-renesas- >> soc@vger.kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >> Fabrizio Castro >> Subject: Re: [PATCH RFC 1/3] dt-bindings: clock: Add Renesas versa3 clock >> generator bindings >> >> On 09/03/2023 08:57, Biju Das wrote: >>>>> It is clk generator HW specific. Clk generator is vital component >>>>> which provides clocks to the system. >>>> >>>> Every clock controller is vital... >>>> >>>>> We are providing some hardware feature which is exposed as dt >>>>> properties. >>>>> >>>>> Like clock output is fixed rate clock or dynamic rate clock/ >>>> >>>> OK, I wait then for proper description which will explain and justify >> this. >>> >>> Here it is, Please let me know is it ok? >>> >>> renesas,output-clock-fixed-rate-mode: >>> type: boolean >>> description: >>> In output clock fixed rate mode, the output clock frequency is >> always >>> fixed and the hardware will use the values from the OTP or full >> register >>> map initialized during boot. >>> If not given, the output clock rate is not fixed. >>> maxItems: 6 >> >> boolean is scalar, not array, so no maxItems. If the frequency is taken from >> OTP or register map, why they cannot also provide information the clock is >> fixed? > > OK, I will make an array property instead. From HW perspective each clock output from the > Clock generator is controllable ie, fixed rate or dynamic rate. > > If all the output clocks are fixed rate one, then frequency is taken from OTP or > register map. But if any one clock output generates dynamic rate, then it uses > dynamic settings. Second try, same question, let me know if it is not clear: "why they cannot also provide information the clock is fixed?" Best regards, Krzysztof