From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4CE4CCA47B for ; Thu, 14 Jul 2022 09:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237459AbiGNJzw (ORCPT ); Thu, 14 Jul 2022 05:55:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234827AbiGNJzu (ORCPT ); Thu, 14 Jul 2022 05:55:50 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F18D4C605 for ; Thu, 14 Jul 2022 02:55:49 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id bf9so1892144lfb.13 for ; Thu, 14 Jul 2022 02:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Ex1g5I3eoUQJiOv3dD/PtghCfWhfsmio59xIVAgsJyY=; b=bmzEn0AeCHc/TY+avf9KtSU84quEoJL6dmZlyUsuE0l2pZ6iCM/BC8laeeCstgT9pF 6SuM+wf7pbB7EHkdZTxAJSQW3EDljFcfoY0XrO3BL+1WsFbqMBJ1pXgBrSIw0KbMKPBo eOVjl7b0vbvcAnWL/6RJ7nuK2yoiNr2FiwPo5KoXj4p1VGeUMgkYdQiuez71ryLmW8sU p7z+1mi7ap9rqEngJm0sdJLZPAU1RnOzVKLqr5aD1l20eYaeKKV3rzHFUbQVP4ZdFEat RbVn0mwzV4zuhaPcXwN6ds/oRg/V566TJIkgcxPRYO6fJ2NOv8QxCswHrsRW684j9zU1 QacQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Ex1g5I3eoUQJiOv3dD/PtghCfWhfsmio59xIVAgsJyY=; b=DFYZ0RC8dqw+lS6VvRy1E4SJOJVeTtHktOejCBrY8AVCeZOaj51e24o3HEYtmjAlZf dpzSSssC4oFyT07M4I79ILfzhJ4MT2vzuYCOjnTuWKBX0wR2IDFTXFTmNQ+Qzh1J47I/ dXCN+iY0a8QbCBLeE+VxQtbgcZ22Fdd6n+tvUOK1EqWP6680XhuspVUovlOZ8sbEFVVn SZXQkJDjv/9GQywBUHi8ZqBxbDiwH0gu5WdVID6Amu1eV0IGKAY+QITfRfiKkw5sBvWj +oXT2VDPU+yS9o6OLCZNUN/C9OzvMGzPgjKmng+tay1YT4e+OiXOGv9URx8zvOOKlwDf /S9A== X-Gm-Message-State: AJIora+YP67Qu7Hh7cVlXFXh8bzh+TfrnEdpSUq+1Wsm6kFFVOmkfGji s74cqF3rTmifsw/7pQnpOUr+wMNOUU2xZw== X-Google-Smtp-Source: AGRyM1v6vyxwV1p3JiIAymxRsWpbXrpoNMXbQ26YuOQ8MllzgRe7lttKQ9LdNJ2m25DT//EHrOx7+w== X-Received: by 2002:a05:6512:3f27:b0:47f:a079:eeec with SMTP id y39-20020a0565123f2700b0047fa079eeecmr4530678lfa.46.1657792547841; Thu, 14 Jul 2022 02:55:47 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id s13-20020a056512214d00b0048110fd06c4sm272282lfr.53.2022.07.14.02.55.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 02:55:46 -0700 (PDT) Message-ID: Date: Thu, 14 Jul 2022 11:55:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/6] ARM: dts: qcom: msm8974: Disable remoteprocs by default Content-Language: en-US To: Stephan Gerhold , Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Sireesh Kodali , Luca Weiss , Stephan Gerhold , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org References: <20220712124421.3129206-1-stephan.gerhold@kernkonzept.com> <20220712124421.3129206-4-stephan.gerhold@kernkonzept.com> From: Krzysztof Kozlowski In-Reply-To: <20220712124421.3129206-4-stephan.gerhold@kernkonzept.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/07/2022 14:44, Stephan Gerhold wrote: > The remoteproc configuration in qcom-msm8974.dtsi is incomplete because > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi > index 814ad0b46232..35246bd02132 100644 > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi > @@ -1172,6 +1172,8 @@ remoteproc_mss: remoteproc@fc880000 { > qcom,smem-states = <&modem_smp2p_out 0>; > qcom,smem-state-names = "stop"; > > + status = "disabled"; > + > mba { > memory-region = <&mba_region>; > }; > @@ -1639,6 +1641,8 @@ remoteproc_adsp: remoteproc@fe200000 { > qcom,smem-states = <&adsp_smp2p_out 0>; > qcom,smem-state-names = "stop"; > > + status = "disabled"; > + > smd-edge { > interrupts = ; > > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts > index 58cb2ce1e4df..8a6b8e4de887 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts > @@ -147,10 +147,12 @@ wcnss { > }; > > &remoteproc_adsp { > + status = "okay"; These go to the end of properties. > cx-supply = <&pm8841_s2>; > }; > > &remoteproc_mss { > + status = "okay"; Ditto > cx-supply = <&pm8841_s2>; > mss-supply = <&pm8841_s3>; > mx-supply = <&pm8841_s1>; > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts > index d6b2300a8223..577cbffad010 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts > @@ -457,10 +457,12 @@ fuelgauge_pin: fuelgauge-int-pin { > }; > > &remoteproc_adsp { > + status = "okay"; Ditto > cx-supply = <&pma8084_s2>; > }; > > &remoteproc_mss { > + status = "okay"; > cx-supply = <&pma8084_s2>; > mss-supply = <&pma8084_s6>; > mx-supply = <&pma8084_s1>; Best regards, Krzysztof