From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 283D33DA5A0 for ; Fri, 10 Apr 2026 15:49:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775836153; cv=none; b=bedhWS0xwDQjdBQTrr5yh6jf9brxnDRTqDBGtDYyQ2/EB9dbj6TU+JMG4qQvIVbYybOZ9bjl646OfUyjFd/ciAdbUgaAgx43ScuWzHrsF/zfa/90YkL9dmZ/vXDf21ulFCqWnWah2vshIXNwxOEmPcUmaA3cXFqECTEkRxKVbJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775836153; c=relaxed/simple; bh=ocS+CBJKG3wcDKZoHOZrlxgABbQL5lFNKAXhEvNnJfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MjeHv6a2Wh80IBPq9+nLJeYsF0EfmB/CnivgHTSKvuKLElSUqw/jmWXUqAOYTwpEtxihEBVunJ0keRgP4phwEz5okXo20hUT8GPUY9GZzxbj9d15U0jJ4hBrWCRKGDicGnA+ILOzbNrNnUiJ+SIuuGQn9qwDohIUQosVjJaDBYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=USDIoOUB; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="USDIoOUB" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-12c1fcce8f8so1313700c88.1 for ; Fri, 10 Apr 2026 08:49:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775836151; x=1776440951; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=ex/7VQ4LuDb6TdbBF1Wf96owQWL8u54/cayoZYl1VgI=; b=USDIoOUBZPBnK5Hv4SyC/Og6FNfjOVwsADaAf71NyVSQnnYnFskvCuvuAi8Hq1Kg51 YfVmAwHq9ipy+iw8HAgVzpSuLYR+Gsxl7BAJf7h98Tg2aBaAS+WsmLP+N86bygIae43b zpwR2gFCXGVT6Jihlq+Q2QUokbsoScHPESnxlrdS156EFPqu09ZsMiOkUTONLsS4mMco DGIAcJ/RKhYtRtyQZXBMAF8ZzK5MuAnYQFvMaOnbnwZNgDkJtU9t3mQuFTUYqYLikJcr gCxfTQoHi6VinQ1Fp/vhH1yG/t8DqN3dp/agtqBrAsF4PDr9HyTWhRYx2LoGs08wZVVt BxoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775836151; x=1776440951; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ex/7VQ4LuDb6TdbBF1Wf96owQWL8u54/cayoZYl1VgI=; b=ihB4PrCnLoX6rR/vW4bRpQSOpTJYT1HFEEBtAS1iikG3APvUD1w9ixT1OgjTT1lE0s EFxJEqgqhwMpIn2p6L/Pm4y3PX8/gbkcDwYqaB0xgQNLh1nOcJwz7ETSY3u3chWwtzNr z5jsBc/vIzeqzvBN8dr0hxhieKL9c8QuO6qUhXsbvmTn3jobmc0miuXqRTrTofHsQWIz cRqakFTCHqYh1Zmq/KwmniWCrbi6iCvqLVLGHw23UZNpm41Z6lc27uRkgNvGcRHx6B9i Hv1nIqLV1zAp5nzErimLMr5ARihocwirrfsd6OOKQq23yLaAvmhESj0UX7ZVF8EPMbdV 71Rw== X-Gm-Message-State: AOJu0YwwXEp9J46o6c6TrChFTOHHPapX8fF6yhG2kns4PlFAC/r1bqQg gH5XW4d1ZG57llLWvn/wxBisV16OpAkWMd26gUirRMmQCAH/YbBwoKXN X-Gm-Gg: AeBDievgyOyDUY7Xs4WtoGS9CirQ8RDSu/2J2g7RkH91p6vwHIXhqQLeUdRv7/q2EuI rzepYkggQkf4w1P66JPbU7zWAxN4D/iPdKuqsXTmQzNVCK2QSM1S2jZww+ywUUxnQAWF3tdiNsJ vfBX/d8Rioi9c21I9U3r7wjJg2pfdni9sAVdZ0fTqL+/SnP4/5pl8hVuhP6NdeYfgZZLN/eEcwe IbB3+fW1pGvqxOGYFgt8vR+K5EYyBfGxVbhdDwpA5+1SOJTZe2ViEibNYuW/qLNogoserhg9ju9 W7ipVk3/bD9YaehW4uLBxCO7dOXgmTDOqjswEfvoO1A1voRM7lMUo3wa+4aBYcD0fl3kGzDbtEi z90eaZt0eru71ZI81K/U6VWV1NVbF8pqgImD1+/LmzRQBsftY04cIvm7OWBSy3sO0n5C770URgn /cnIJ5XZQldEx5Ms0ybNPyLBLxc9g/kCOfyRTLm01e6zMkF3VM1ocrHSp2Z78ls/61GgtvjM4o X-Received: by 2002:a05:7022:6290:b0:12a:6fb7:87e3 with SMTP id a92af1059eb24-12c34f05b51mr2604016c88.31.1775836151097; Fri, 10 Apr 2026 08:49:11 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c3459f7ffsm3777944c88.3.2026.04.10.08.49.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 08:49:10 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Fri, 10 Apr 2026 08:49:07 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/5] watchdog: aaeon: Add watchdog driver for SRG-IMX8P MCU To: "Thomas Perrot (Schneider Electric)" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , =?UTF-8?B?SsOpcsOpbWllIERhdXRoZXJpYmVz?= , Wim Van Sebroeck , Lee Jones Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, Thomas Petazzoni , Miquel Raynal References: <20260408-dev-b4-aaeon-mcu-driver-v5-0-ad98bd481668@bootlin.com> <20260408-dev-b4-aaeon-mcu-driver-v5-5-ad98bd481668@bootlin.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260408-dev-b4-aaeon-mcu-driver-v5-5-ad98bd481668@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/8/26 10:21, Thomas Perrot (Schneider Electric) wrote: > Add watchdog driver for the Aaeon SRG-IMX8P embedded controller. > This driver provides system monitoring and recovery capabilities > through the MCU's watchdog timer. > > The watchdog supports start, stop, and ping operations with a maximum > hardware heartbeat of 25 seconds and a default timeout of 240 seconds. > > Co-developed-by: Jérémie Dautheribes (Schneider Electric) > Signed-off-by: Jérémie Dautheribes (Schneider Electric) > Signed-off-by: Thomas Perrot (Schneider Electric) > --- > MAINTAINERS | 1 + > drivers/watchdog/Kconfig | 10 +++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/aaeon_mcu_wdt.c | 132 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 144 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2538f8c4bc14..7b92af42c9fd 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -193,6 +193,7 @@ S: Maintained > F: Documentation/devicetree/bindings/mfd/aaeon,srg-imx8p-mcu.yaml > F: drivers/gpio/gpio-aaeon-mcu.c > F: drivers/mfd/aaeon-mcu.c > +F: drivers/watchdog/aaeon_mcu_wdt.c > F: include/linux/mfd/aaeon-mcu.h > > AAEON UPBOARD FPGA MFD DRIVER > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index d3b9df7d466b..f67a0b453316 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -420,6 +420,16 @@ config SL28CPLD_WATCHDOG > > # ARM Architecture > > +config AAEON_MCU_WATCHDOG > + tristate "Aaeon MCU Watchdog" > + depends on MFD_AAEON_MCU > + select WATCHDOG_CORE > + help > + Select this option to enable watchdog timer support for the Aaeon > + SRG-IMX8P onboard microcontroller (MCU). This driver provides > + watchdog functionality through the MCU, allowing system monitoring > + and automatic recovery from system hangs. > + > config AIROHA_WATCHDOG > tristate "Airoha EN7581 Watchdog" > depends on ARCH_AIROHA || COMPILE_TEST > diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile > index ba52099b1253..2deec425d3ea 100644 > --- a/drivers/watchdog/Makefile > +++ b/drivers/watchdog/Makefile > @@ -37,6 +37,7 @@ obj-$(CONFIG_USBPCWATCHDOG) += pcwd_usb.o > # ALPHA Architecture > > # ARM Architecture > +obj-$(CONFIG_AAEON_MCU_WATCHDOG) += aaeon_mcu_wdt.o > obj-$(CONFIG_ARM_SP805_WATCHDOG) += sp805_wdt.o > obj-$(CONFIG_ARM_SBSA_WATCHDOG) += sbsa_gwdt.o > obj-$(CONFIG_ARMADA_37XX_WATCHDOG) += armada_37xx_wdt.o > diff --git a/drivers/watchdog/aaeon_mcu_wdt.c b/drivers/watchdog/aaeon_mcu_wdt.c > new file mode 100644 > index 000000000000..949b506d8194 > --- /dev/null > +++ b/drivers/watchdog/aaeon_mcu_wdt.c > @@ -0,0 +1,132 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Aaeon MCU Watchdog driver > + * > + * Copyright (C) 2026 Bootlin > + * Author: Jérémie Dautheribes > + * Author: Thomas Perrot > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#define AAEON_MCU_PING_WDT 0x73 > + > +#define AAEON_MCU_WDT_TIMEOUT 240 > +#define AAEON_MCU_WDT_HEARTBEAT_MS 25000 > + > +struct aaeon_mcu_wdt { > + struct watchdog_device wdt; > + struct regmap *regmap; > +}; > + > +static int aaeon_mcu_wdt_cmd(struct aaeon_mcu_wdt *data, u8 opcode, u8 arg) > +{ > + return regmap_write(data->regmap, AAEON_MCU_REG(opcode, arg), 0); > +} > + > +static int aaeon_mcu_wdt_start(struct watchdog_device *wdt) > +{ > + struct aaeon_mcu_wdt *data = watchdog_get_drvdata(wdt); > + > + return aaeon_mcu_wdt_cmd(data, AAEON_MCU_CONTROL_WDT_OPCODE, 0x01); > +} > + > +static int aaeon_mcu_wdt_status(struct watchdog_device *wdt, bool *enabled) > +{ > + struct aaeon_mcu_wdt *data = watchdog_get_drvdata(wdt); > + unsigned int rsp; > + int ret; > + > + ret = regmap_read(data->regmap, > + AAEON_MCU_REG(AAEON_MCU_CONTROL_WDT_OPCODE, 0x02), > + &rsp); > + if (ret) > + return ret; > + > + *enabled = rsp == 0x01; > + return 0; > +} > + > +static int aaeon_mcu_wdt_stop(struct watchdog_device *wdt) > +{ > + struct aaeon_mcu_wdt *data = watchdog_get_drvdata(wdt); > + > + return aaeon_mcu_wdt_cmd(data, AAEON_MCU_CONTROL_WDT_OPCODE, 0x00); > +} > + > +static int aaeon_mcu_wdt_ping(struct watchdog_device *wdt) > +{ > + struct aaeon_mcu_wdt *data = watchdog_get_drvdata(wdt); > + > + return aaeon_mcu_wdt_cmd(data, AAEON_MCU_PING_WDT, 0x00); > +} > + > +static const struct watchdog_info aaeon_mcu_wdt_info = { > + .identity = "Aaeon MCU Watchdog", > + .options = WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE > +}; > + > +static const struct watchdog_ops aaeon_mcu_wdt_ops = { > + .owner = THIS_MODULE, > + .start = aaeon_mcu_wdt_start, > + .stop = aaeon_mcu_wdt_stop, > + .ping = aaeon_mcu_wdt_ping, > +}; > + > +static int aaeon_mcu_wdt_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct watchdog_device *wdt; > + struct aaeon_mcu_wdt *data; > + bool enabled; > + int ret; > + > + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + data->regmap = dev_get_regmap(dev->parent, NULL); > + if (!data->regmap) > + return -ENODEV; > + > + wdt = &data->wdt; > + wdt->parent = dev; > + wdt->info = &aaeon_mcu_wdt_info; > + wdt->ops = &aaeon_mcu_wdt_ops; > + /* > + * The MCU firmware has a fixed hardware timeout of 25 seconds that > + * cannot be changed. The watchdog core will handle automatic pinging > + * to support longer timeouts. The software timeout of 240 seconds is > + * chosen arbitrarily as a reasonable value and is not user-configurable. > + */ Odd, unusual, unnecessary, I would argue that most people would consider a fixed timeout of 240s as anything but reasonable, and as the comment says arbitrary. Since I am sure that I pointed this out before, you still insist, and I am tired of arguing: Your funeral, so Acked-by: Guenter Roeck Guenter > + wdt->timeout = AAEON_MCU_WDT_TIMEOUT; > + wdt->max_hw_heartbeat_ms = AAEON_MCU_WDT_HEARTBEAT_MS; > + > + watchdog_set_drvdata(wdt, data); > + > + ret = aaeon_mcu_wdt_status(wdt, &enabled); > + if (ret) > + return ret; > + > + if (enabled) > + set_bit(WDOG_HW_RUNNING, &wdt->status); > + > + return devm_watchdog_register_device(dev, wdt); > +} > + > +static struct platform_driver aaeon_mcu_wdt_driver = { > + .driver = { > + .name = "aaeon-mcu-wdt", > + }, > + .probe = aaeon_mcu_wdt_probe, > +}; > + > +module_platform_driver(aaeon_mcu_wdt_driver); > + > +MODULE_DESCRIPTION("Aaeon MCU Watchdog Driver"); > +MODULE_AUTHOR("Jérémie Dautheribes "); > +MODULE_LICENSE("GPL"); >