From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A60446135 for ; Thu, 14 Sep 2023 07:17:57 +0000 (UTC) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBB6AE50 for ; Thu, 14 Sep 2023 00:17:56 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-31ae6bf91a9so555451f8f.2 for ; Thu, 14 Sep 2023 00:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694675875; x=1695280675; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TnyV9af3KTDSn5LmFo4v6eXcrqZ+B9e5Qxfuac0pjUY=; b=bBbpkGr2n0HTB6HQGlZEQHjLa0Tpxp1IpvUIgNVu3aEXG/u1wqNiL9RxT+wFLnVAYy lPYZSiSU4+dwTbDl+IGFoxUUQUosc8UeoUMfYbiUIl782pzdNqpyRwCktg9c4nVFRXLm gBkPYu82+qa7S3WbZfzhkViQiSBxJbOfQRAUi27r1hseHd+buQOw14PaM8URO0OxFhsX CMHqyrAl1/AKfEPm1sFEICCOjo4cdLFWHUtMAwrUgr/cS+hgl6ORmdowGd1C1Gdy9/bY RZ9iWU5fCtdPoj6s74p7WfHO38h1xLLtMb50CrDf/Y28likNu0J6nXW249GkdCUqp3Gj c+kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694675875; x=1695280675; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TnyV9af3KTDSn5LmFo4v6eXcrqZ+B9e5Qxfuac0pjUY=; b=pb8OD9I+zogo+e/vWZRmy6jz9bYCMJYv49vkymXCxIgxbbYPLaK1yq/rAbK+h2ZZcv vmSKVpciU8OcXKhxhdEdlVj7ITmw8Kr7NozRvd5T2REY/9mH3O0qkuLGap27aV3zzRll SOvQyCbjRp6hm7hgVy0dpfGKhmdoDVE5t6Wj4iAvyyvuDrKCknm6fXQh6gLu/3vQ1mci +64JorkPYic5oINQd6RGv/YKl/ZWPeOGcOVcpjrE87BIN7plFYiKHNddtAZPT/a2OLdj TfuOy7tU99P5e4oJQ4zjtwxvQIt/fj4AOULXJLAhMbSHKSeo2sDHDeEaKeVV1QvaZCA2 s87g== X-Gm-Message-State: AOJu0YwxmzrLS0Sp3ycL5XQCn1hdtEYQpB1WBblNZIZ0ZdeTUBnuCaRn QIluOgvhIsUtQriGYkb8S7OGcg== X-Google-Smtp-Source: AGHT+IEK6SYA+nBzWeG6lMDvkeq82QWkULn4oFR/HTZ2x3sw8wMbXcV31yc++OhQtubr4HHqola0wA== X-Received: by 2002:adf:de8a:0:b0:314:3bd7:6a0c with SMTP id w10-20020adfde8a000000b003143bd76a0cmr3970173wrl.33.1694675875014; Thu, 14 Sep 2023 00:17:55 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id q5-20020a5d6585000000b0031f5f0d0be0sm933196wru.31.2023.09.14.00.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 00:17:54 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 09:17:51 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2] scsi: ufs: qcom: dt-bindings: Add MCQ properties Content-Language: en-US From: Krzysztof Kozlowski To: Ziqi Chen , quic_asutoshd@quicinc.com, quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, martin.petersen@oracle.com, quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com Cc: linux-scsi@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "open list:ARM/QUALCOMM SUPPORT" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <1694675158-38301-1-git-send-email-quic_ziqichen@quicinc.com> <1e89183a-b42a-b447-0c1a-bbfe646705ef@linaro.org> In-Reply-To: <1e89183a-b42a-b447-0c1a-bbfe646705ef@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/09/2023 09:16, Krzysztof Kozlowski wrote: > On 14/09/2023 09:05, Ziqi Chen wrote: >> Remove the maxItem limitation to property 'reg', Your commit should answer to "why". Not "what". >> and add description for the property 'msi-parent'. >> >> Signed-off-by: Ziqi Chen >> --- >> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index bdfa86a..5ec2717 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -77,7 +77,13 @@ properties: >> >> reg: >> minItems: 1 >> - maxItems: 2 > > So 20 items are allowed? No, that's not correct. > > >> + description: >> + Register base addresses and lengths of the UFS areas. > > Drop description - it's useless and redundant. > >> + >> + reg-names: >> + minItems: 1 >> + description: >> + Names of the reg areas to use during resource lookup. > > Drop such description it's useless, instead list and describe items. > > Also, why all devices now have two regs? No, this is just wrong. And > haven't we been here with two items? > > >> >> required-opps: >> maxItems: 1 >> @@ -97,6 +103,10 @@ properties: >> description: >> GPIO connected to the RESET pin of the UFS memory device. >> >> + msi-parent: >> + description: >> + Pointer to the hardware entity that serves as the MSI controller for thi UFS controller. > > typo in "thi". Not wrapped according to Linux coding style (as written > in coding style document). BTW, this is usually just "true" and without > need for description. > BTW, for both my comments - for reg/reg-names and this property - where is the user? Except adding this to example, I expect to see users somewhere. Best regards, Krzysztof