From: Jeremy Kerr <jk@ozlabs.org>
To: Eddie James <eajames@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
wsa@the-dreams.de, robh+dt@kernel.org,
gregkh@linuxfoundation.org, joel@jms.id.au, andrew@aj.id.au,
"Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings
Date: Wed, 28 Jun 2017 11:08:17 +0800 [thread overview]
Message-ID: <bcd64ad6-2cb0-b3ba-b577-2fabf253084b@ozlabs.org> (raw)
In-Reply-To: <901bb9e4-a7b1-ce24-c68b-d96b61e1b274@linux.vnet.ibm.com>
Hi Eddie,
>> Those child nodes represent the downstream i2c buses, and so also
>> contain the i2c slave devices, right? If so, you may want to document
>> that, and/or add a simple device to that example (say, an EEPROM).
>
> Yes, good point, but the driver currently wouldn't do anything with that
> device information. It doesn't keep a list of populated devices on the
> bus or anything. Still worth adding them to the device tree?
Surely the i2c core needs this to be able to find i2c slave devices on
the bus though?
[You'll need to set i2c_adapter->dev.of_node for this to work though,
which I don't think you are with the current patch set]
Cheers,
Jeremy
next prev parent reply other threads:[~2017-06-28 3:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 19:29 [PATCH 0/6] drivers/i2c: Add FSI-attached I2C master algorithm Eddie James
2017-06-26 19:29 ` [PATCH 2/6] drivers/i2c: Add port structure to FSI algorithm Eddie James
2017-06-26 19:29 ` [PATCH 3/6] drivers/i2c: Add transfer implementation for " Eddie James
[not found] ` <1498505375-1454-1-git-send-email-eajames-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-26 19:29 ` [PATCH 1/6] drivers/i2c: Add FSI-attached I2C master algorithm Eddie James
2017-06-26 19:29 ` [PATCH 4/6] drivers/i2c: Add I2C master locking to FSI algorithm Eddie James
2017-06-26 19:29 ` [PATCH 5/6] drivers/i2c: Add bus recovery for " Eddie James
2017-06-26 19:29 ` [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Eddie James
[not found] ` <1498505375-1454-7-git-send-email-eajames-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-27 1:06 ` Jeremy Kerr
[not found] ` <ec4a5fec-fea0-09a7-8559-99d8eb071093-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
2017-06-27 17:28 ` Eddie James
2017-06-28 3:08 ` Jeremy Kerr [this message]
2017-06-28 23:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd64ad6-2cb0-b3ba-b577-2fabf253084b@ozlabs.org \
--to=jk@ozlabs.org \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=eajames@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).