From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5D07173; Thu, 9 Oct 2025 00:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759969936; cv=none; b=HGsJNOisyI9DVUQqCey2UuzT7d5+4mELMib6l4tLGnDCFxcmdxrgvgMxDhz2EOX1F9TVRNsaK+k56f05r576L4mn+TS66r6cgVF+/64sG4SacXsYLeW+m3U6W3wtjvXXKSXKARpWM0sUhcWExlyf1mRtonJHWDh5U5APGJogzyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759969936; c=relaxed/simple; bh=kWpLlcPiCbJutncPlmjdHXQbcAsO41pQ0yvyL9CXkoQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g19AsaGShJaw/cFcaMmgmcA3j1uBoDNItdgVcgSGfPAaxp57D+MRVQ41Yejlf2MZM3nWCM0zeSR/b1rwvN2aFATzvSPOFMbspGi+mWFJz2BOYERSorfTMS4shDd5dVjPJcMiVuOP5Tu9/vLDY9BvseL87LXHrDPfZre48ntnxqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dBx0JrZF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dBx0JrZF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 918FAC4CEE7; Thu, 9 Oct 2025 00:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759969934; bh=kWpLlcPiCbJutncPlmjdHXQbcAsO41pQ0yvyL9CXkoQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dBx0JrZF0JKhv0vBk4+DtiFvSCRMM3AsbB3NJ9ndBJoC35TASb/qWchIT7UOApSms 3CaLeH7Jro/svmcCSjfnhTiEPQA4aQtmhljNL+nCH2+aGarTGDoRkcuPFDLqDVO/0R SO/ljGXsr0k7RqpSxNz1SCaBiqjBkbrY3oEFJZ4kphEBQVyxDCWGoA+yu0aLR9DlFm U3XSQ+THzI77fOMsAaqFtnVK/Gz7RCVJ09K2fS/rFAmDyyVmopnlLLSPj1Ze+XfqeX CMjoPheUUwqGa8/zzcuM1zji7xlNf2f+Bxo0lgfqjOIAP9IOphnmUGZssswqlptQph /5x8HO5lA4RyQ== Message-ID: Date: Thu, 9 Oct 2025 09:32:05 +0900 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node To: Bryan O'Donoghue , Charan Teja Kalla , Bryan O'Donoghue , Bryan O'Donoghue , Dmitry Baryshkov Cc: Konrad Dybcio , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <7b6db4fa-2f73-376d-4eb3-64c1c7e6cda3@quicinc.com> <1ad2ca1e-1d57-4ad8-a057-ab0d804f1d49@oss.qualcomm.com> <7da769b4-88e9-401f-bb21-0ff123818b9c@kernel.org> <6840d462-8269-4359-a6e5-d154842b62db@oss.qualcomm.com> <2hh3zkdwgqbdurpr4tibr3gjat6arwl3dd3gxakdaagafwjdrm@aj5em4tbsjen> <4a32bbec-2baf-4210-a7c1-1ddcd45d30c8@oss.qualcomm.com> <4d87d1ca-55b2-426e-aa73-e3fd8c6fe7bd@kernel.org> <10a8ccda-4e27-4b06-9a0e-608d6ade5354@nxsw.ie> <4cb4a92d-2f20-47c7-881e-aadcc6f83aa0@kernel.org> <1516f21e-aee3-42cf-b75e-61142dc9578d@oss.qualcomm.com> <9bae595a-597e-46e6-8eb2-44424fe21db6@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <9bae595a-597e-46e6-8eb2-44424fe21db6@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 09/10/2025 09:10, Bryan O'Donoghue wrote: > On 08/10/2025 19:03, Charan Teja Kalla wrote: >>>>> Couldn't we list the entire set of iommus - then detach - subsequently >>>>> re-attaching in our platform code with FUNCTION_IDs we keep listed in >>>>> our drivers ? >>>>> >> TMK, there is no api exist to detach a device once it is attached to >> smmu. We used to have one but removed[1], not sure how well it will be >> received to introduce it again. >> >> There is other problem exist attaching the entire set of iommus in the >> first place: Usually writes to SMR registers are protected through >> emulation by hyp. Thus adding the sids of protected/non-protected >> usecases in the same iommu set will not allowed by the >> hypervisors(eg:gunyah), as all will end up in using the same context >> bank, thus there can be failure to attach to smmu in the first place. >> >> >> [1] >> https://lore.kernel.org/all/20230110025408.667767-1- >> baolu.lu@linux.intel.com/ >> >>>>> That way the DT is complete and correct, we have a compliant upstream DT >>>>> but we also find a way to make the FUNCTION_ID specific setup we need. >>>> i.e. you can keep the FUNCTION_ID "metadata" in the driver and >>>> associate specific iommu indexes with the FUNCTION_ID you want in there. >>>> >>>> That way you could have multiple FUNCTION_ID smmu entries in the DT >>>> and just associate the DT indexes locally in drivers/platform/qcom/ >>>> iris_metadata_goes_here.c >>>> >>>> --- >>>> bod >>> Actually why can't we specify FUNCTION_ID in the iommus = >>> >>> Surely we could do >>> >>>     #iommu-cells = <4>; >>>     iommus = <&apps_smmu 0x420 0x2 FUNCTION_ID>; >>> >>> and encode the real data we need directly in the iommus list... >>> >> Since it is the smmu device property , this suggestion expects all the >> devices, not just video, to define additional argument. Does this look >> valid? > > If it is legitimate meta-data for the SMMU setup then why _shouldn't_ it > go into the DT ? > We talked about this two or three months ago. I don't understand why you just ignored that entire part and come with new binding just to not touch iommu code. List of entries in iommu must have strict order, just like for every other list, and you should rely on that. Best regards, Krzysztof