From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37731C433EF for ; Sat, 9 Apr 2022 11:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241570AbiDILRv (ORCPT ); Sat, 9 Apr 2022 07:17:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241567AbiDILRv (ORCPT ); Sat, 9 Apr 2022 07:17:51 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5135821A5 for ; Sat, 9 Apr 2022 04:15:40 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id m30so16445766wrb.1 for ; Sat, 09 Apr 2022 04:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iGiuPg7lc4blNR5kNU/wL46Om1t3+4rWHXM4pA/ZsLU=; b=Q2TtATKglLqgEJQCNnsLg1XDdMtsVQ1Sju+9GXtwIN35OHELJLvar0CTxHvsVwIkPI vySloLG45YYjbEN8HezbotELVNyivU7FOslSAulbTTdOzy1kKasNrhCOHDKn4r2Hzz6s QgXEZovuhuf/qtV8H1ihRqqxIzpk2mv3iAzVxB83Iro84MSyFYdgcMTI9usiHlwBcLqp H1HzV6BLov1jmO0FeacnZq5Xzk4JGv/E370HtWlHmUI8FOHw943Dwvb1dBmawcRp7Gqc yvONqk0Yu5PkuepzWE5UjCrv0fa0r3yistq190tbKW5Bu/pYmNOryfh80B5tWn+dDqjY vrjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iGiuPg7lc4blNR5kNU/wL46Om1t3+4rWHXM4pA/ZsLU=; b=lKC7e6vPil+nq1G2fLam0WanRNQUXRxrWAs+oN7ild13r8BIg6tBzNdFSu9CZI1IFw PdfIy88TE85a6gy7ssOTKvLeSFPgo7yoNBKhQZve1I7Nwku5XW38cUdjfeX6vw0vKDi9 zvJLpXexjqlNkU6p/ieErCojSr7Iq57Jw3rDVNSzYMm0ymdZGo9ge+0qSoH12HdLjuK/ 13fE5pSvO1HcLTVSll1Sp10xjUMP5ZM4gHHe6c84jfU+oLnwX566wOCuIQiBNJuzlEyA waA9BD4ib1kWIljgwqe5LYMZdKFEEjGcMYiSqbgGahh64N7DdetPejcOe/5pJ9iRQjng XhJA== X-Gm-Message-State: AOAM531jkkVEIBBk4lyCkAjL3kcx7u2/PCV73u1FIK6C62K/F2rOOMOL EFM/awShtoXKZTXlWh7lUQ+ovA== X-Google-Smtp-Source: ABdhPJw8eqZ3CK46BraT1Tr6WfztP8qaMpRU2FvUlKqHNaMjCJOrHLE52SwW4f8CpwJVc+Kf4eLk8g== X-Received: by 2002:adf:db92:0:b0:205:9c92:f1e3 with SMTP id u18-20020adfdb92000000b002059c92f1e3mr17774537wri.515.1649502938951; Sat, 09 Apr 2022 04:15:38 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id u23-20020a7bcb17000000b0037bdfa1665asm16462177wmj.18.2022.04.09.04.15.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 04:15:38 -0700 (PDT) Message-ID: Date: Sat, 9 Apr 2022 13:15:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by dtbscheck Content-Language: en-US To: "H. Nikolaus Schaller" , Rob Herring , Paul Cercueil , Thomas Bogendoerfer Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org References: <298162bfa2e7225ccc753865e1ffa39ce2722b2a.1649443080.git.hns@goldelico.com> From: Krzysztof Kozlowski In-Reply-To: <298162bfa2e7225ccc753865e1ffa39ce2722b2a.1649443080.git.hns@goldelico.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/04/2022 20:37, H. Nikolaus Schaller wrote: > arch/mips/boot/dts/ingenic/ci20.dtb: usb@13500000: compatible: 'oneOf' conditional failed, one must be fixed: > ['ingenic,jz4780-otg', 'snps,dwc2'] is too long > ['ingenic,jz4780-otg', 'snps,dwc2'] is too short > 'brcm,bcm2835-usb' was expected > 'hisilicon,hi6220-usb' was expected > 'rockchip,rk3066-usb' was expected > 'ingenic,jz4780-otg' is not one of ['rockchip,px30-usb', 'rockchip,rk3036-usb', 'rockchip,rk3188-usb', 'rockchip,rk3228-usb', 'rockchip,rk3288-usb', 'rockchip,rk3308-usb', 'rockchip,rk3328-usb', 'rockchip,rk3368-usb', 'rockchip,rv1108-usb'] > 'lantiq,arx100-usb' was expected > 'lantiq,xrx200-usb' was expected > 'ingenic,jz4780-otg' is not one of ['amlogic,meson8-usb', 'amlogic,meson8b-usb', 'amlogic,meson-gxbb-usb', 'amlogic,meson-g12a-usb', 'intel,socfpga-agilex-hsotg'] > 'amcc,dwc-otg' was expected > 'apm,apm82181-dwc-otg' was expected > 'snps,dwc2' was expected > 'st,stm32f4x9-fsotg' was expected > 'st,stm32f4x9-hsotg' was expected > 'st,stm32f7-hsotg' was expected > 'st,stm32mp15-fsotg' was expected > 'st,stm32mp15-hsotg' was expected > 'samsung,s3c6400-hsotg' was expected > 'intel,socfpga-agilex-hsotg' was expected You really don't need to paste entire warning. > From schema: Documentation/devicetree/bindings/usb/dwc2.yaml > > Signed-off-by: H. Nikolaus Schaller > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index 2021836983c96..c5124459678b7 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -576,7 +576,7 @@ bch: bch@134d0000 { > }; > > otg: usb@13500000 { > - compatible = "ingenic,jz4780-otg", "snps,dwc2"; > + compatible = "snps,dwc2"; This looks wrong, the block usually should have a specific compatible. Please mention why it does not. Best regards, Best regards, Krzysztof